From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2716C433DB for ; Thu, 4 Mar 2021 00:45:34 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44BC66146D for ; Thu, 4 Mar 2021 00:45:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44BC66146D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=COVHH61OJJNWmpi0Wq0Ef0Z0c7ui8Iyb5/MtBYD3tyU=; b=AgEKh2vg6v0TEPFiClI35+pXi 9yIQZgA2OcfM8xu6/42mc74HbOfVdIz0vTdSByu/FBcUX4qhOjyD/7KilL90YyRn6J8DIG0DgSW0E oEBm3oXOJ4s4pKe62tv39VfmTuxUn/Jnbnj89rnBbOuDtHadfXeoDd9aygGxcyFI0lWsRvZ8mIlbT 4EmYo3DrR/V6mcsaXd/tTVHTEQl4KLW7XL73BvnaC6xgjqpKRCxO3puSJy56nioMrrFKw+MUSz9CI 7vGiLEpLit2gYq614o9CeAkl8lgnZcWo3knsiFbijdqK6ZyoDcwAsiad4n8QwfKRnHbu95o6OwpWy p/S3DplOg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHc5D-007Crr-By; Thu, 04 Mar 2021 00:43:16 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHX8b-006D1N-84 for linux-arm-kernel@lists.infradead.org; Wed, 03 Mar 2021 19:26:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614799582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zZak1YCTeDCL5z28NbOLP4nsAVAJ3AftCQx5HMPyNmg=; b=JoH3fXkqCzJ5DistIQWFAzm2fmxHzstXiI143mTmTXttbX+4tQnQpBk2XFvyc0YlvjRTQK mHmlCaVWBDrIGBxlNYbUDYvAZbPtprrijvLdAf3JXV99ExjUoDJlKr+ipZUfpDEA7idQ8V 97Zh584qD31iAz0697z3QG2p2vLo/fs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-191-qjA2q2YWP12qsw9B3FMcqA-1; Wed, 03 Mar 2021 14:24:50 -0500 X-MC-Unique: qjA2q2YWP12qsw9B3FMcqA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B1EAC73A0; Wed, 3 Mar 2021 19:24:49 +0000 (UTC) Received: from [10.36.112.28] (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C14E60BFA; Wed, 3 Mar 2021 19:24:45 +0000 (UTC) Subject: Re: [PATCH V2 1/2] arm64/mm: Fix pfn_valid() for ZONE_DEVICE based memory To: Catalin Marinas Cc: Anshuman Khandual , Will Deacon , Mark Rutland , linux-kernel@vger.kernel.org, Mike Rapoport , linux-mm@kvack.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , James Morse , Dan Williams , Robin Murphy , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org References: <20210202123215.GA16868@willie-the-truck> <20210202123524.GB16868@willie-the-truck> <20210202125152.GC16868@willie-the-truck> <4d8f5156-8628-5531-1485-322ad92aa15c@redhat.com> <0e649f28-4d54-319d-f876-8a93870cda7f@arm.com> <20210205185552.GA23216@willie-the-truck> <20210211115354.GB29894@willie-the-truck> <23e5eb93-a39c-c68e-eac1-c5ccf9036079@arm.com> <20210303190428.GB24035@arm.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <5c5eb731-a5b3-757b-fcf5-283eb268625b@redhat.com> Date: Wed, 3 Mar 2021 20:24:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210303190428.GB24035@arm.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03.03.21 20:04, Catalin Marinas wrote: > On Thu, Feb 11, 2021 at 01:35:56PM +0100, David Hildenbrand wrote: >> On 11.02.21 13:10, Anshuman Khandual wrote: >>> On 2/11/21 5:23 PM, Will Deacon wrote: >>>> ... and dropped. These patches appear to be responsible for a boot >>>> regression reported by CKI: >>> >>> Ahh, boot regression ? These patches only change the behaviour >>> for non boot memory only. >>> >>>> https://lore.kernel.org/r/cki.8D1CB60FEC.K6NJMEFQPV@redhat.com >>> >>> Will look into the logs and see if there is something pointing to >>> the problem. >> >> It's strange. One thing I can imagine is a mis-detection of early sections. >> However, I don't see that happening: >> >> In sparse_init_nid(), we: >> 1. Initialize the memmap >> 2. Set SECTION_IS_EARLY | SECTION_HAS_MEM_MAP via >> sparse_init_one_section() >> >> Only hotplugged sections (DIMMs, dax/kmem) set SECTION_HAS_MEM_MAP without >> SECTION_IS_EARLY - which is correct, because these are not early. >> >> So once we know that we have valid_section() -- SECTION_HAS_MEM_MAP is set >> -- early_section() should be correct. >> >> Even if someone would be doing a pfn_valid() after >> memblocks_present()->memory_present() but before >> sparse_init_nid(), we should be fine (!valid_section() -> return 0). > > I couldn't figure out how this could fail with Anshuman's patches. > Will's suspicion is that some invalid/null pointer gets dereferenced > before being initialised but the only case I see is somewhere in > pfn_section_valid() (ms->usage) if valid_section() && !early_section(). Indeed, it looks like a latent bug. > > Assuming that we do get a valid_section(ms) && !early_section(ms), is > there a case where ms->usage is not initialised? I guess races with > section_deactivate() are not possible this early. > Do you have access to that machine? We could identify which path is taken quite easily. > Another situation could be that pfn_valid() returns true when no memory > is mapped for that pfn. > >> As it happens early during boot, I doubt that some NVDIMMs that get detected >> and added early during boot as system RAM (via dax/kmem) are the problem. > > It is indeed very early, we can't even get the early console output. So even before any hotplug really happens. All sections should be early at that point I guess. > Debugging this is even harder as it's only misbehaving on a board we > don't have access to. > > On the logic in this patch, is the hot-added memory always covering a > full subsection? The arm64 pfn_valid() currently relies on > memblock_is_map_memory() but the patch changes it to > pfn_section_valid(). So if hot-added memory doesn't cover the full > subsection, it may return true even if the pfn is not mapped. Hotplugged System RAM always covers full sections. Hotplugged ZONE_DEVICE always covers full subsections. pfn_section_valid() properly handles both cases. (see generic pfn_valid()) -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel