From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3142FC433E0 for ; Tue, 2 Feb 2021 07:44:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C29B264EE2 for ; Tue, 2 Feb 2021 07:44:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C29B264EE2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qkWjbwTUMSzwT/0FFNEY2Q2+CkKAT6cQWsUmY0rwFog=; b=g5Ppe5vi4MpB+q089PzfzK4BR +8gN2HODiTrnvb17dS9UlnHXRNz5IpnDaSKZmYWFnxSbqxlixnrk/FdQi6kv+VpjSkzBCx8YaCK29 N9xlZ+soXMmMl8hDeYCFdD6tB+BWKkORP38I3ydZF3r7jevtWVPS8KpAfokgxC06/PeQw6+QgUVXV xIgawHeUn/+Z9Lmv+/IkrZwxYM882UQdW8p/uAQgijXbCu/1vxP7lMTPh288sZTk42f3dLJ0PS18A HJM16b1cB5KkTXFal9+R1lQbG0/oahthOfA3pvEGfSO12wzx47vIrNC0cQSpNUXz+vs9cIctc3tsT zYHUDiY5A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6qL9-00064F-0q; Tue, 02 Feb 2021 07:43:11 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6qL3-00063p-Ih for linux-arm-kernel@lists.infradead.org; Tue, 02 Feb 2021 07:43:09 +0000 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DVGwf696FzjFsT; Tue, 2 Feb 2021 15:41:54 +0800 (CST) Received: from [127.0.0.1] (10.69.38.203) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.498.0; Tue, 2 Feb 2021 15:42:55 +0800 Subject: Re: [PATCH] coresight: Remove duplicate header files of coresight drivers To: Mathieu Poirier References: <1612184564-26613-1-git-send-email-liuqi115@huawei.com> <20210201170537.GA1399621@xps15> From: "liuqi (BA)" Message-ID: <5c76cdc8-fa58-ddb0-c1b9-4a6db85f463a@huawei.com> Date: Tue, 2 Feb 2021 15:42:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20210201170537.GA1399621@xps15> Content-Language: en-GB X-Originating-IP: [10.69.38.203] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210202_024307_181106_F23E72AD X-CRM114-Status: GOOD ( 13.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, coresight@lists.linaro.org, linuxarm@openeuler.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/2/2 1:05, Mathieu Poirier wrote: > Good day, > > On Mon, Feb 01, 2021 at 09:02:44PM +0800, Qi Liu wrote: >> Remove duplicate included header files, as coresight-priv.h is included in >> these coresight drivers. >> >> Signed-off-by: Qi Liu >> --- >> drivers/hwtracing/coresight/coresight-catu.c | 2 -- >> drivers/hwtracing/coresight/coresight-core.c | 3 --- >> drivers/hwtracing/coresight/coresight-cpu-debug.c | 3 --- >> drivers/hwtracing/coresight/coresight-cti-core.c | 3 --- >> drivers/hwtracing/coresight/coresight-cti-platform.c | 1 - >> drivers/hwtracing/coresight/coresight-cti.h | 1 - >> drivers/hwtracing/coresight/coresight-etb10.c | 4 ---- >> drivers/hwtracing/coresight/coresight-etm-perf.c | 1 - >> drivers/hwtracing/coresight/coresight-etm3x-sysfs.c | 1 - >> drivers/hwtracing/coresight/coresight-etm4x-core.c | 5 ----- >> drivers/hwtracing/coresight/coresight-etm4x-sysfs.c | 1 - >> drivers/hwtracing/coresight/coresight-funnel.c | 3 --- >> drivers/hwtracing/coresight/coresight-platform.c | 2 -- >> drivers/hwtracing/coresight/coresight-replicator.c | 3 --- >> drivers/hwtracing/coresight/coresight-stm.c | 3 --- >> drivers/hwtracing/coresight/coresight-tmc-core.c | 3 --- >> drivers/hwtracing/coresight/coresight-tmc-etf.c | 1 - >> drivers/hwtracing/coresight/coresight-tmc-etr.c | 1 - >> drivers/hwtracing/coresight/coresight-tpiu.c | 4 ---- >> 19 files changed, 45 deletions(-) > > The idea is to make sure every file stands on its own without dependencies on > other header files. Otherwise it is difficult and expensive to move files > around or make changes to any header file. As such I will not move forward > with this set. > > Thanks, > Mathieu > Hi Mathieu, got it, thanks :). Qi > >> >> diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c >> index a61313f..fcc0367 100644 >> --- a/drivers/hwtracing/coresight/coresight-catu.c >> +++ b/drivers/hwtracing/coresight/coresight-catu.c >> @@ -7,10 +7,8 @@ >> * Author: Suzuki K Poulose >> */ >> >> -#include >> #include >> #include >> -#include >> #include >> #include >> >> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c >> index 4ba801d..5fb8b12 100644 >> --- a/drivers/hwtracing/coresight/coresight-core.c >> +++ b/drivers/hwtracing/coresight/coresight-core.c >> @@ -7,17 +7,14 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> #include >> #include >> #include >> #include >> -#include >> #include >> #include >> -#include >> >> #include "coresight-etm-perf.h" >> #include "coresight-priv.h" >> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c >> index e1d2324..f8df512 100644 >> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c >> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c >> @@ -4,15 +4,12 @@ >> * >> * Author: Leo Yan >> */ >> -#include >> -#include >> #include >> #include >> #include >> #include >> #include >> #include >> -#include >> #include >> #include >> #include >> diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c >> index 61dbc1a..ed7ab82 100644 >> --- a/drivers/hwtracing/coresight/coresight-cti-core.c >> +++ b/drivers/hwtracing/coresight/coresight-cti-core.c >> @@ -4,18 +4,15 @@ >> * Author: Mike Leach >> */ >> >> -#include >> #include >> #include >> #include >> #include >> #include >> #include >> -#include >> #include >> #include >> #include >> -#include >> #include >> #include >> >> diff --git a/drivers/hwtracing/coresight/coresight-cti-platform.c b/drivers/hwtracing/coresight/coresight-cti-platform.c >> index ccef04f..60b0580 100644 >> --- a/drivers/hwtracing/coresight/coresight-cti-platform.c >> +++ b/drivers/hwtracing/coresight/coresight-cti-platform.c >> @@ -2,7 +2,6 @@ >> /* >> * Copyright (c) 2019, The Linaro Limited. All rights reserved. >> */ >> -#include >> #include >> #include >> #include >> diff --git a/drivers/hwtracing/coresight/coresight-cti.h b/drivers/hwtracing/coresight/coresight-cti.h >> index acf7b54..0a3b313 100644 >> --- a/drivers/hwtracing/coresight/coresight-cti.h >> +++ b/drivers/hwtracing/coresight/coresight-cti.h >> @@ -7,7 +7,6 @@ >> #ifndef _CORESIGHT_CORESIGHT_CTI_H >> #define _CORESIGHT_CORESIGHT_CTI_H >> >> -#include >> #include >> #include >> #include >> diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c >> index 0cf6f0b..8d5bc04 100644 >> --- a/drivers/hwtracing/coresight/coresight-etb10.c >> +++ b/drivers/hwtracing/coresight/coresight-etb10.c >> @@ -10,17 +10,13 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> #include >> #include >> #include >> #include >> -#include >> #include >> -#include >> -#include >> #include >> #include >> #include >> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c >> index bdc34ca..01aba63 100644 >> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c >> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c >> @@ -4,7 +4,6 @@ >> * Author: Mathieu Poirier >> */ >> >> -#include >> #include >> #include >> #include >> diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c >> index e8c7649..5cf6660 100644 >> --- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c >> +++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c >> @@ -5,7 +5,6 @@ >> */ >> >> #include >> -#include >> #include >> #include "coresight-etm.h" >> #include "coresight-priv.h" >> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c >> index b20b6ff..0438ef7 100644 >> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c >> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c >> @@ -3,13 +3,11 @@ >> * Copyright (c) 2014, The Linux Foundation. All rights reserved. >> */ >> >> -#include >> #include >> #include >> #include >> #include >> #include >> -#include >> #include >> #include >> #include >> @@ -20,14 +18,11 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> -#include >> #include >> #include >> #include >> -#include >> #include >> >> #include >> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c >> index 989ce7b..347ccb7 100644 >> --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c >> +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c >> @@ -5,7 +5,6 @@ >> */ >> >> #include >> -#include >> #include >> #include "coresight-etm4x.h" >> #include "coresight-priv.h" >> diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c >> index 071c723..c79ded9 100644 >> --- a/drivers/hwtracing/coresight/coresight-funnel.c >> +++ b/drivers/hwtracing/coresight/coresight-funnel.c >> @@ -15,9 +15,6 @@ >> #include >> #include >> #include >> -#include >> -#include >> -#include >> #include >> >> #include "coresight-priv.h" >> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c >> index 3629b78..ca22409 100644 >> --- a/drivers/hwtracing/coresight/coresight-platform.c >> +++ b/drivers/hwtracing/coresight/coresight-platform.c >> @@ -13,8 +13,6 @@ >> #include >> #include >> #include >> -#include >> -#include >> #include >> #include >> >> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c >> index 7e2a2b7..36788de 100644 >> --- a/drivers/hwtracing/coresight/coresight-replicator.c >> +++ b/drivers/hwtracing/coresight/coresight-replicator.c >> @@ -6,14 +6,11 @@ >> */ >> >> #include >> -#include >> #include >> #include >> #include >> -#include >> #include >> #include >> -#include >> #include >> #include >> #include >> diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c >> index 9979177..75f0bd8 100644 >> --- a/drivers/hwtracing/coresight/coresight-stm.c >> +++ b/drivers/hwtracing/coresight/coresight-stm.c >> @@ -17,17 +17,14 @@ >> */ >> #include >> #include >> -#include >> #include >> #include >> -#include >> #include >> #include >> #include >> #include >> #include >> #include >> -#include >> #include >> >> #include "coresight-priv.h" >> diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c >> index 8169dff..4fff281 100644 >> --- a/drivers/hwtracing/coresight/coresight-tmc-core.c >> +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c >> @@ -9,7 +9,6 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> #include >> @@ -21,8 +20,6 @@ >> #include >> #include >> #include >> -#include >> -#include >> >> #include "coresight-priv.h" >> #include "coresight-tmc.h" >> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c >> index 989d965..b263f75 100644 >> --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c >> +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c >> @@ -6,7 +6,6 @@ >> >> #include >> #include >> -#include >> #include >> #include >> #include "coresight-priv.h" >> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c >> index bf5230e..1ab0b28 100644 >> --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c >> +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c >> @@ -5,7 +5,6 @@ >> */ >> >> #include >> -#include >> #include >> #include >> #include >> diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c >> index d5dfee9..c5675f9 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpiu.c >> +++ b/drivers/hwtracing/coresight/coresight-tpiu.c >> @@ -9,12 +9,8 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> -#include >> -#include >> -#include >> #include >> >> #include "coresight-priv.h" >> -- >> 2.8.1 >> > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel