From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ben Levinsky <ben.levinsky@amd.com>,
jassisinghbrar@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
michal.simek@amd.com, shubhrajyoti.datta@amd.com,
jaswinder.singh@linaro.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] mailbox: zynqmp: Enable Bufferless IPI usage on Versal-based SOC's
Date: Fri, 12 Jan 2024 08:24:28 +0100 [thread overview]
Message-ID: <5c789b3a-1a2c-47a4-b8f7-191bb13f060f@linaro.org> (raw)
In-Reply-To: <20240111172226.1816105-4-ben.levinsky@amd.com>
On 11/01/2024 18:22, Ben Levinsky wrote:
> /**
> * zynqmp_ipi_free_mboxes - Free IPI mailboxes devices
> *
> @@ -748,6 +861,9 @@ static const struct of_device_id zynqmp_ipi_of_match[] = {
> { .compatible = "xlnx,zynqmp-ipi-mailbox",
> .data = &zynqmp_ipi_setup,
> },
> + { .compatible = "xlnx,versal-ipi-mailbox",
Not documented.
Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-01-12 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 17:22 [PATCH v2 0/3] mailbox: zynqmp: Enable Bufferless IPIs for Versal based SOCs Ben Levinsky
2024-01-11 17:22 ` [PATCH v2 1/3] mailbox: zynqmp: Move of_match structure closer to usage Ben Levinsky
2024-01-11 17:22 ` [PATCH v2 2/3] mailbox: zynqmp: Move buffered IPI setup to of_match selected routine Ben Levinsky
2024-01-11 17:22 ` [PATCH v2 3/3] mailbox: zynqmp: Enable Bufferless IPI usage on Versal-based SOC's Ben Levinsky
2024-01-12 7:24 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c789b3a-1a2c-47a4-b8f7-191bb13f060f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ben.levinsky@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=robh+dt@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).