From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0A0CC4332F for ; Thu, 15 Dec 2022 11:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FNysF95+XJpskcMFQOUl3IfVUVB/IV2O7YnOqK0L3Nc=; b=pO08D744pO/N9v iahI0Npj2LdvRHN208gQYSYybIb1pI1+0E8snxnRFmAm2aiZNdGidbBR/xE+q1I7KTVCbF6Nwh1X0 TtJH30SRORXBvdP0mzEc4FPiufG+3ZLy2/vsvDn9mTh3jCb2kQCJgyqgfsrV6TC0UxKm2dCrDKRg6 DQTEGZD8dUdyj22NMiXBmv221KQSmSizXCKU5CgZhRseg7W6Xt4OI5pNdmqt0JMdDqLkECrojK+n/ B4ngkRYAxS3EVwZuzne0vPbYnQjpW71aeXDI7cjAsBiHeVa/uMJFqHULYRC4V9AqibTK3bcT/5fvN kPSB6Byr7ZdWdgnQpYbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5mXA-0092r4-5G; Thu, 15 Dec 2022 11:36:16 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5mX7-0092pm-MT for linux-arm-kernel@lists.infradead.org; Thu, 15 Dec 2022 11:36:15 +0000 Received: from [192.168.1.139] ([37.4.248.22]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MY60L-1pQWl52yyL-00YPIy; Thu, 15 Dec 2022 12:30:34 +0100 Message-ID: <5c963fd9-97c9-d513-a8ae-5d3f22ef57cc@i2se.com> Date: Thu, 15 Dec 2022 12:30:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 3/7] staging: vc04_services: Drop VCHIQ_ERROR usage To: Umang Jain , linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Kees Cook , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart References: <20221215065853.34477-1-umang.jain@ideasonboard.com> <20221215065853.34477-4-umang.jain@ideasonboard.com> Content-Language: en-US From: Stefan Wahren In-Reply-To: <20221215065853.34477-4-umang.jain@ideasonboard.com> X-Provags-ID: V03:K1:bGkgykONBpPpX1R6OdAO5MPBl5f1JNTz1nwaYLWn+4fGLciBgMJ /VWt6LyeTaZqwsut1MJb45AMkanBWgqGCiXI3rLFdZ06TpnQioP008UhAdv4WGxsE6/MwuU 7vjMPdFST0lsoaPLMalwQhij3wl9/IC/qHO/f4DJ29jUJZflQfzwq57FkCZSIG9DR7qEA6p X4HebJUgEyzx5ogRYFstw== UI-OutboundReport: notjunk:1;M01:P0:JzvnbawC/y0=;UBeFh/McymgWzME8tQ8tjuJ9PJY dijUc02+A3kmFtam9pD+LZHyFGRBv+OHnSvwy4mW/tPoYiU+WGAKgMgxBp3IKGRpPpmdPR4pK vBMMyXmDcAXuDdCZUxp3P7+84Z1eoxqeWhn7YKszLD4QDzoo+B5OSppb3sQ+G42O97mJUAJPd /GBZdJ86DWugh3L6KW2JBPxfGrk29zcHi7oEeDKnXA/38dVdkhV7cnOBWJw79N6PvHJnRTvnB Q9O8aiwApNTui0S4ELbxbBlyMCXOPMqt+zPi3rtiiwTgUr7eOhNB9whDDpu0SbMlm8UUFVGTh KNOwjZZfyE8RMGX5rNeR8V2OYC2ga90r8WLSy6p+3bulp0y5dMoQxiDY/DCkSlzjCswFfFTAA E1rOrbi4BGPDsYTww4VpKNT4khSJWTNdNmbzt9eO+F0/7+siCEB4ArS+IK/cK+Xs9W77PYzLf x3yiQty8zfb1NoSCJIouEUBY3a3eJMrWiQDvONuFV0UrA7XffuSuA25zApMCQVKcXEY+os8DP qm70iHgVYB4eXmVUkQrH+/koWiTh/WRCBxm738wUd14andoMeUfIVfQyGzjUnBMuZ33P68IJ0 8gRzIlo/11IEbB6xPN5WaLJduhRnv2xk9/F1V6/q/fxgpn8dH3AbUosNEYHpNkdiaVf2JahL2 4Xl6NOY/akCvOGPhYTLDZYU5MBJUr8tKK1TqYkTpfQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221215_033614_030349_2FA3DB59 X-CRM114-Status: UNSURE ( 7.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Umang, thanks for taking care of this. Am 15.12.22 um 07:58 schrieb Umang Jain: > Drop the usage of VCHIQ_ERROR vchiq_status enum type. Replace it with > -EINVAL to report the error. I would prefer to use adequate error codes like ENOMEM and so on. I agree simply replacing all VCHIQ_ERROR with -EINVAL is easier, but wasn't the real intention of the TODO item. The rest of the series looks good to me. Best regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel