From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A7B8D1815D for ; Tue, 15 Oct 2024 00:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6/06bc8oCZtyUeywqMc8qTFgfwd5N7FHrM9Z7htd1G0=; b=nlf/1syZf6ZypFMmM2z+sdZ/Y/ u42L6LkYN5pcV30RtMyL4kAPTbr3GcMwXMAgO0X+VjltbfK6sz3A/EU3wwGRzM97r7yC2LB9DTU8l Rdw12ulxCr3faln78mkZjgcP8kz8owK9QFVkzRpjLNL1sQG9/efRMc7UqRg1ckg/s2UVkXUclC0BK HFiLJGsiV7TorFJlJspqLEo4sh1SLks97TDhhTABZlHpbyoA2sQO4FJXmGAEszOktc2cod8NBCjgB ZGi4ipGlK7sGGSW1f0zT1VdZw7S9H/han/XABOQaLCI004Yxvq/2hn2ED59mbcssM9xvFS+d8FUjY IIAAfuXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0VbI-00000006i7B-0VfZ; Tue, 15 Oct 2024 00:39:48 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0VZs-00000006hu6-16eU for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2024 00:38:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1728952691; bh=6/06bc8oCZtyUeywqMc8qTFgfwd5N7FHrM9Z7htd1G0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Yr3vlzPPFYdNfF21gVd7sc9jkCqRu3O12LkVhdfZMDUdr2lIULQqlZ/m3DaEXQeB5 A2O9PXWnoZKl5FqwlqPYoHLE+dCBur3+TS5TqFhnhxYOj0dI/o9sJ/ADPgJUBPvZRn w9Od7APzUPV3yJD6HOT7K/3gTCZIE/9uVV71aG1rmtuhaAWwcAi7xxrIAeDGm7Ddec ehVmgt7l/WvAqE3YHyapNPS55d6Q8Lmyi8XHcq3ukIi3kka67W1FZRM4eJ6v5nF18I +s0t9MmKu+DSMsnc0lN0O0zZSYEJlaq/m6p0yGa+AomRGk2VvJToHHa5pkE7Q8aS1M 4WVbxmKP0cCiA== Received: from [192.168.68.112] (203-173-0-39.dyn.iinet.net.au [203.173.0.39]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id F16C4649A0; Tue, 15 Oct 2024 08:38:08 +0800 (AWST) Message-ID: <5ca25b137b955dc5e0d9607df104097e3de7b782.camel@codeconstruct.com.au> Subject: Re: [PATCH v5 1/2] dt-bindings: arm: aspeed: add IBM SBP1 board From: Andrew Jeffery To: Naresh Solanki Cc: "Rob Herring (Arm)" , devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Conor Dooley , Joel Stanley , Conor Dooley , linux-aspeed@lists.ozlabs.org Date: Tue, 15 Oct 2024 11:08:08 +1030 In-Reply-To: References: <20241010112337.3840703-1-naresh.solanki@9elements.com> <172857036038.1533242.5775916298170949713.robh@kernel.org> <4d596ac9a2215be8510369c948e0b9680ee2fce3.camel@codeconstruct.com.au> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_173820_735400_003FF743 X-CRM114-Status: GOOD ( 26.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Naresh, On Fri, 2024-10-11 at 13:38 +0530, Naresh Solanki wrote: > Hi Andrew, >=20 >=20 > On Fri, 11 Oct 2024 at 05:15, Andrew Jeffery > wrote: > >=20 > > Hi Naresh, > >=20 > > On Thu, 2024-10-10 at 09:30 -0500, Rob Herring (Arm) wrote: > > > On Thu, 10 Oct 2024 16:53:31 +0530, Naresh Solanki wrote: > > > > Document the new compatibles used on IBM SBP1. > > > >=20 > > > > Signed-off-by: Naresh Solanki > > > > Acked-by: Conor Dooley > > > > --- > > > > Changes in V4: > > > > - Retain Acked-by from v2. > > > > - Fix alphabetic order > > > > --- > > > > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > > > > 1 file changed, 1 insertion(+) > > > >=20 > > >=20 > > >=20 > > > My bot found new DTB warnings on the .dts files added or changed in t= his > > > series. > > >=20 > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warni= ngs > > > are fixed by another series. Ultimately, it is up to the platform > > > maintainer whether these warnings are acceptable or not. No need to r= eply > > > unless the platform maintainer has comments. > > >=20 > > > If you already ran DT checks and didn't see these error(s), then > > > make sure dt-schema is up to date: > > >=20 > > > pip3 install dtschema --upgrade > > >=20 > > >=20 > > > New warnings running 'make CHECK_DTBS=3Dy aspeed/aspeed-bmc-ibm-sbp1.= dtb' for 20241010112337.3840703-1-naresh.solanki@9elements.com: > > >=20 > >=20 > > ... > >=20 > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mux@77: interrupts:= False schema does not allow [[44, 4]] > > > from schema $id: http://devicetree.org/schemas/i2c/i2c-mux-pca954x.y= aml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-c= pu2@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccf= a-cpu2@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-c= pu1@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccf= a-cpu1@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-c= pu3@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccf= a-cpu3@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regu= lators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regu= lators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regu= lators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regu= lators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-c= pu0@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccf= a-cpu0@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > >=20 > > These still must be addressed as mentioned on v3 (with more specific > > comments regarding the infineon,ir38263 on v4). Please look through the > > binding documents for the affected nodes and make sure the nodes in > > your DTS conform to their definitions. You can check your work with > > `make CHECK_DTBS=3Dy aspeed/aspeed-bmc-ibm-sbp1.dtb` prior to sending. >=20 > These are the warnings coming for trivial devices. Even for regulator@5f >=20 > grep -rsn mp2973 Documentation/ > Documentation/devicetree/bindings/trivial-devices.yaml:286: > # Monolithic Power Systems Inc. multi-phase controller mp2973 > Documentation/devicetree/bindings/trivial-devices.yaml:287: - > mps,mp2973 >=20 Right, but if they're generating warnings, then you haven't specified the nodes in accordance with the bindings. From here one of two things is the case: 1. The bindings' specifications are incomplete, and you need to introduce patches updating them to match how you need to use the hardware 2. Your devicetree is incorrect, and the unexpected properties need to be removed from the listed nodes. The only third option is "don't use the hardware how you need to" (i.e. remove the unexpected properties despite needing them, because you don't want to update the bindings). Ultimately the tools are telling you something is wrong, and I need the warnings I've identified addressed before I can apply your patch, otherwise the hardware is not going to do what you might expect. > I've rebased it on top of for-next branch in [2] >=20 > I rebased on top of [1] & the volume of output did reduce for CHECK_DTBS. Great :) Andrew