From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBAB5C0015E for ; Tue, 11 Jul 2023 04:03:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F5DMRsL3FbmE4ckLvIVL5zXWyEBKpFsA6vCUDi4ov1E=; b=soaxcywWKtKToc H02jzvAX1NGiGQUU7HCoy8FFC7uaUZreV6x/q7EkJPD5HoXhSxZJhTYzPROgIrkFWkys+x6HwGM1K e3dYOWWHoUFTFzgVSSDYpzhhGM0P5iIqkNOIuE4zMEZi3XtW07iYEFIGGDcFl0THuX8GOR2SiQW/F syRVdz44T89lG3VZOmNZh13C2Gklrgp/2SYRYiKjXJ5npWf2//B7an3tRYfu/ZEY8jxYtRQ//+M8Z diAFLa5E4/XIiU3O9JKsO72sm6FkLFLStwn4OMTLQ6aarE5JyDj/YAaol4BSo/lS2ENxZiJEpRg5+ 1n0kz4Rqj9oup/e/ml1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJ4aD-00DYwj-2O; Tue, 11 Jul 2023 04:02:37 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJ4aA-00DYvp-2q for linux-arm-kernel@lists.infradead.org; Tue, 11 Jul 2023 04:02:36 +0000 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36B2r9GQ026472; Tue, 11 Jul 2023 04:02:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=iTB3oKekh3v/P5mRdFmw2Ck60e2TQ9FDGLFSuFnAUpY=; b=DT0javzcou1lMebwxt6CGdFIjRuQhxjRYPXoHTu9ssPnnL4IbFCKPlrCHbLpW0+Wi14h PqK471X71c9Sq/EBbo0uV9dk8cvGnVvxE1Ma7mzWtTf5ujo7WHdw8rCeZKbX03QEk2al T8VqsrXRSF8N7eACwk6tYe0ZZnPfC1AOQb3j5poKYlRYWEndYN2f9J48CEvSmQEbbux4 BllUNzm/J90MrGeV7wwIvq4MlGTed9MBKc6dta3fwgh8hCR1I8WNFE1ymOYCDXI/F/aL lZYGq4lq6ZP2pzgD9yqCxhnJqNmdl42+/bIYgOCDvjjTxYCKfv8iiB7yCNJokXqYTrxA Bg== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rrxpdg34x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jul 2023 04:02:27 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36B42R63020736 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jul 2023 04:02:27 GMT Received: from [10.239.133.73] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Mon, 10 Jul 2023 21:02:24 -0700 Message-ID: <5cf15f85-0397-96f7-4110-13494551b53b@quicinc.com> Date: Tue, 11 Jul 2023 12:02:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] arm64: Add the arm64.nolse_atomics command line option To: Will Deacon CC: , , , , , , , , , , References: <20230710055955.36551-1-quic_aiquny@quicinc.com> <20230710093751.GC32673@willie-the-truck> From: "Aiqun(Maria) Yu" In-Reply-To: <20230710093751.GC32673@willie-the-truck> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: JHx4b0WH-pw4ugh7VLyM_HW0t49wQcuf X-Proofpoint-GUID: JHx4b0WH-pw4ugh7VLyM_HW0t49wQcuf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-11_01,2023-07-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 adultscore=0 mlxlogscore=583 priorityscore=1501 phishscore=0 malwarescore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307110035 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_210234_929475_CE00BF6D X-CRM114-Status: GOOD ( 20.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/10/2023 5:37 PM, Will Deacon wrote: > On Mon, Jul 10, 2023 at 01:59:55PM +0800, Maria Yu wrote: >> In order to be able to disable lse_atomic even if cpu >> support it, most likely because of memory controller >> cannot deal with the lse atomic instructions, use a >> new idreg override to deal with it. > > This should not be a problem for cacheable memory though, right? > > Given that Linux does not issue atomic operations to non-cacheable mappings, > I'm struggling to see why there's a problem here. The lse atomic operation can be issued on non-cacheable mappings as well. Even if it is cached data, with different CPUECTLR_EL1 setting, it can also do far lse atomic operations. > > Please can you explain the problem that you are trying to solve? In our current case, it is a 100% reproducible issue that happened for uncached data, the cpu which support LSE atomic, but the system's DDR subsystem is not support this and caused a NOC error and thus synchronous external abort happened. > > Will -- Thx and BRs, Aiqun(Maria) Yu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel