From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A088BC48BD1 for ; Thu, 10 Jun 2021 16:08:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BF5E613DE for ; Thu, 10 Jun 2021 16:08:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BF5E613DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cw+eHaGXNGBg9E9YRi83wfvM2VJP6ls6Xw9nYtxqA4g=; b=GnFWWSqJy+6S7T2DTmtZjBm6cg RiMMND5wEhXmRQzYomAr7hpIajgYKWsliB/0OHSw+Cr9XvOMctGVI0IY63VuV/2H9sZfLqKPOApS9 zevSUhz341FPXaoz8rf2zOZXuWyA6wpa6to5FmjDmhKcIihNTsHLq8iTG3/RGAQL2jfghrMFapUNv OtoAGaPAI+NiYeWTh4AzhqxLC6slsra8Q9mMVQUG6K1qonk2m3Nzt89JGFPnv3lIZtm7Ra9m+ZCTK ZO2mjRbq/En/kMkwiLB834zCVBk+yg6t0t47UibLBcF7TFlMalKCcbJTShKhYsspzPR/lA/RbwuNk vO0vgr7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrNC9-001ZKh-Nc; Thu, 10 Jun 2021 16:06:13 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrNAk-001YuG-U9 for linux-arm-kernel@lists.infradead.org; Thu, 10 Jun 2021 16:04:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91672ED1; Thu, 10 Jun 2021 09:04:44 -0700 (PDT) Received: from [10.57.74.218] (unknown [10.57.74.218]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0A0CB3F719; Thu, 10 Jun 2021 09:04:41 -0700 (PDT) Subject: Re: [PATCH v1 0/3] coresight: Fix for snapshot mode To: Denis Nikitin , Leo Yan Cc: Arnaldo Carvalho de Melo , Mathieu Poirier , Mike Leach , Alexander Shishkin , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Jiri Olsa , Namhyung Kim , Daniel Kiss , Coresight ML , linux-arm-kernel , Linux Kernel Mailing List , linux-perf-users@vger.kernel.org References: <20210528161552.654907-1-leo.yan@linaro.org> From: Suzuki K Poulose Message-ID: <5cf3effb-fccc-9385-6328-6d1e2e5ccdf3@arm.com> Date: Thu, 10 Jun 2021 17:04:40 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210610_090447_081388_23B8A6A5 X-CRM114-Status: GOOD ( 20.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Denis On 10/06/2021 07:43, Denis Nikitin wrote: > Hi Leo, > > On Fri, May 28, 2021 at 9:16 AM Leo Yan wrote: >> >> This patch series is to correct the pointer usages for the snapshot >> mode. >> >> Patch 01 allows the AUX trace in the free run mode and only syncs the >> AUX ring buffer when taking snapshot. >> >> Patch 02 is to polish code, it removes the redundant header maintained >> in tmc-etr driver and directly uses pointer perf_output_handle::head. >> >> Patch 03 removes the callback cs_etm_find_snapshot() which wrongly >> calculates the buffer headers; we can simply use the perf's common >> function __auxtrace_mmap__read() for headers calculation. >> >> This patch can be cleanly applied on the mainline kernel with: >> >> commit 97e5bf604b7a ("Merge branch 'for-5.13-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu") >> >> And it has been tested on Arm64 Juno board. > > I have verified the patches on Chrome OS Trogdor device. > They fixed the problem discussed in > https://lists.linaro.org/pipermail/coresight/2021-May/006411.html. Are you able to confirm if the patch 3 alone fixes the above issue ? I am not convinced that Patch 1 is necessary. Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel