From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5926FC5472C for ; Sat, 24 Aug 2024 15:52:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5cyZK84w2Us0lGO2sQYjQnsuOgO/XxSuKCL7oSJjQ6s=; b=JgwiSY+xBWXtv9QEGT+RxOxCZP 9nRRt6SnkhIn6PeVQyW2mHy3UVcp41xldNqMEFHgtRo/jxW5kFZGHpAfZd9ySXJ26FFJwxisn9x3J vBGEvM720DvLcQiJCneJnaaoTCqfxqJ+qFevBlfecGHIOk6PUO53DE01zB1uA4yBdDshyrhXVYIjw 8hcs6PBA0o4dN8bSJX9Y1xVsch+7XWvfojZ5BVvB+tWCBXcPXIddSk5bkPN79OGaxihWJUFue9OKd YT5nUsdA6hfjS1XgMW0eS+8+nSYFhEQU1MdOc1jHg1FaPsSGGu8HGmt7JE9RYM1LIZRK0LL4XlcpI L8mnNsPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sht49-00000002ThK-1PgR; Sat, 24 Aug 2024 15:52:37 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sht3N-00000002TXl-0LMA for linux-arm-kernel@lists.infradead.org; Sat, 24 Aug 2024 15:51:50 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5bec4e00978so2945560a12.0 for ; Sat, 24 Aug 2024 08:51:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724514707; x=1725119507; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5cyZK84w2Us0lGO2sQYjQnsuOgO/XxSuKCL7oSJjQ6s=; b=f+8tRMmTp1SaA4QcROqybuRt/htI+dmoQd25F9OE17PbaExladPBlBa+8VynRUrhmO hPywsBkyoQfARjETPkYngSv4GkV5OrlLXbhvYe8PBLBXLUmjp5fSa0LVxQe2/czPA7N1 1nAwKPEDQ4j1gVhhdzP0W5SJdf5JIvx35iUGgkvqOnzwmqrSzcEtS8I8/TKnlTTYRDPh 8DLsg4bABrw9Hhpx9EmAb4J8Dn66rI4nhosSTTcQ6YQfoJ6JnMoGr6HMFp+JYelTkA3m q2dSu8FFbYgCjvFy4oe2mONSvuORQipAYtQCikADkATWeKAlsMvL6DqmH9YUNvoi1Dgk Mm0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724514707; x=1725119507; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5cyZK84w2Us0lGO2sQYjQnsuOgO/XxSuKCL7oSJjQ6s=; b=qapZ1RAD8KOr5t1zNvPKFjwj67tK+4ZlsJ2lDT6XiG5S5Jh02PJnE7D5g5GnhBbUPH bhLYAFxaXIZodgtVvAC9+FFVW2gI+FwlVY0o76AeJsPIiGFewNf+pHaOFRYDyDCpNHcI ObIPfLF7LQhAaMKARB+SGGJMdEibx2tg/JzjkE1e+MZTEce/MINxbnbqydjWXRf2/3a+ Wych7Tydnky5bCjfYQjsLvGXyKAqBIAjBay6KwLqsDao+pMPrlrrVLfS622jIQ2uU45k 3QA7+DOVfLZV4oQEGOU8q5dNZJHWAj/exqtuZXhLF0kyUn/uYSsU316aIH/m5s4jN+dT n5+A== X-Forwarded-Encrypted: i=1; AJvYcCUqW9yu57krcVWqmh9Vln9OcMTE154NszgeRTsgCfpZMMVSKDO5rhptzT2kWskQB8bqExwqRMnNtsbn2FnWCjh6@lists.infradead.org X-Gm-Message-State: AOJu0YyP1AL6bS/9mvQhyk5GjEMzsJ35SuD2uPDi6qnMGMq2w/w/2pPb uSSPzuxbLY1U5DMF4mQjMCMIglZOWdr5DtzTpIMdvFJBeRZZF7arV3BW2rvHmOjOBB/Uxp8lH/o c X-Google-Smtp-Source: AGHT+IERgC66zmHL2W8RzwCYkyDM4LDBBVFXQSL98eF9JOj0PY+R9szkItVKcF/bn7lZrb4grpQMHA== X-Received: by 2002:a05:6402:34d6:b0:5a3:283d:b05a with SMTP id 4fb4d7f45d1cf-5c089171c7emr4131347a12.17.1724514707235; Sat, 24 Aug 2024 08:51:47 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.94]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a3ca4d2sm3434336a12.36.2024.08.24.08.51.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Aug 2024 08:51:46 -0700 (PDT) Message-ID: <5d2a6498-57c5-4fb4-9a68-e35072f4b8e3@tuxon.dev> Date: Sat, 24 Aug 2024 18:51:46 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 08/12] nvmem: microchip-otpc: Add warnings for bad OTPC conditions on probe Content-Language: en-US To: Alexander Dahl Cc: Christian Melki , Srinivas Kandagatla , "moderated list:MICROCHIP OTPC DRIVER" , open list References: <20240821105943.230281-1-ada@thorsis.com> <20240821105943.230281-9-ada@thorsis.com> From: claudiu beznea In-Reply-To: <20240821105943.230281-9-ada@thorsis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240824_085149_158895_15306F79 X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21.08.2024 13:59, Alexander Dahl wrote: > These conditions could affect correct function of the driver. Can you please detail why this has been added, what was the issue you identified etc? > > Signed-off-by: Alexander Dahl > --- > drivers/nvmem/microchip-otpc.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/nvmem/microchip-otpc.c b/drivers/nvmem/microchip-otpc.c > index 4630e96243ac..a80535c3d162 100644 > --- a/drivers/nvmem/microchip-otpc.c > +++ b/drivers/nvmem/microchip-otpc.c > @@ -8,6 +8,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -260,6 +261,7 @@ static int mchp_otpc_probe(struct platform_device *pdev) > struct nvmem_device *nvmem; > struct mchp_otpc *otpc; > u32 size; > + u32 reg; > int ret; > > otpc = devm_kzalloc(&pdev->dev, sizeof(*otpc), GFP_KERNEL); > @@ -270,6 +272,16 @@ static int mchp_otpc_probe(struct platform_device *pdev) > if (IS_ERR(otpc->base)) > return PTR_ERR(otpc->base); > > + reg = readl_relaxed(otpc->base + MCHP_OTPC_WPSR); > + if (reg) > + dev_warn(&pdev->dev, > + "Write Protection Status Register Bit set: 0x%08x\n", reg); There are many status bits in WPSR. Some of these bits suggests warnings even when their values are zero (e.g., ECLASS, SWETYP). I don't know how accurate is this message. > + > + reg = readl_relaxed(otpc->base + MCHP_OTPC_ISR); > + if (reg & MCHP_OTPC_ISR_COERR) > + dev_warn(&pdev->dev, > + "A corruption occurred since the last read of OTPC_ISR.\n"); > + > otpc->dev = &pdev->dev; > ret = mchp_otpc_init_packets_list(otpc, &size); > if (ret)