Re: [PATCH 2/2] irqchip/apple-aic: Add support for "apple,t8122-aic3"

[Sven Peter <sven@kernel.org>]

On 25.01.26 12:08, Janne Grunau wrote:
> Introduce support for the new AICv3 hardware block in t8122 and t603x
> SoCs. AICv3 is similar to AICv2 but has an increased IRQ config offset.
> These MMIO offsets are coded as properties of the "aic,3" node in
> Apple's device tree. The actual offsets are the same for all SoCs
> starting from M3 through at least M5. So do not bother to follow suit
> but use AICv3 specific defines in the driver.
> The compatible string is SoC specific so future SoCs with AICv3 and
> different offsets would just use their own compatible string as base and
> add their new offsets.
> 
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
>   drivers/irqchip/irq-apple-aic.c | 27 +++++++++++++++++++++++++--
>   1 file changed, 25 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 3c70364e7cddd6ed6285595f136146ab04b897b2..f4efc325bebad1ae6119aa4eab47819a267da207 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -54,6 +54,7 @@
>   #include <linux/irqdomain.h>
>   #include <linux/jump_label.h>
>   #include <linux/limits.h>
> +#include <linux/of.h>

Did we miss this include previously or why is it added now?

Looks good to me otherwise:

Reviewed-by: Sven Peter <sven@kernel.org>


Best,


Sven