From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CCDECE7A88 for ; Sat, 23 Sep 2023 18:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AAOklcfGrOJx1Y/votqB3eVUCvR116hYvBGLbqRKetI=; b=N7dJs4ntMLlW2P tkFYu6z+NAIZ5Tb0V11iAGRFUnZ2HCVygrGNSwzPeqEzdRkA014TZIneFX7xkooXdetwLsQB+o6PH W75r8Ze9tTDHH/Mi/mReEOiVrOd+pOu3qvj3trCJJ9vLQ5psC4jwoQY2494p4RZCzuNQhrT40cTLa mgjXOVrBsMGBBUWESOXYnd4uVYPLSsWHRgt3tBDhkJfi7ffsdDrU0lr7aZh5ovp7gQ+csVoAK7s7S H4JnDQ9RpBVMm2k9ExJGDgF5IhYz4jVCXq+ns0YV3lJWgmKIX6RjrEJkUWLZJy8IhzNxdeHozWTI1 uZZ+gqz7QquwQWENGCnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qk6yv-00BIUI-2u; Sat, 23 Sep 2023 18:03:53 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qk6yt-00BISK-0g for linux-arm-kernel@lists.infradead.org; Sat, 23 Sep 2023 18:03:52 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9a58dbd5daeso484939066b.2 for ; Sat, 23 Sep 2023 11:03:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695492226; x=1696097026; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xze0269DJpz1msfiE6vhhaaDti5lnwQMTzvMi8h07ck=; b=HAycZvAMSWpcyVKguapxCo2O8FLZw/HHyr2pvWwImIBLazySy4Fl4yUa0ICBKp8hcB 9qDGi0R+x3nv1Iv67BJyvrQHfFK4orHGLZsI3DDdRO19vz4kfsxPo+3PkfVY3wL9drju ChK7zZ1NYZmBrhonyeiS1V84ygyVa7DBa0WHEwzPa/B1+FPLRdUuerRpYv4MXifVt239 FRzMiRJVibOL/PjJiEgL/ow4BmfRIFVR+X0uFraQIs77ju/EmTgVjVkHbLkjtxVxhu3c W4FgLbgPx791I/UlLnXr5dU+VSTn8JveWiNHR0DufNQk66i/sGqJxNujQvsXGd2fuCdZ aIrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695492227; x=1696097027; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xze0269DJpz1msfiE6vhhaaDti5lnwQMTzvMi8h07ck=; b=FJVAYa6z1+mhhFmO1DzFfjl5mfmwNT59BpPPX2lvDQd0H9UEeENNr/Aucrl+5vhvOp EULpPrQP/3OJthP1wgQHHASrEagCK+pc6aBoduEC+cB241dfPwnTknQ3eZrNdP1aiM6o kHRTYLY+xeWUqOYIXn0W+0IHoU+hL0ghGeBEOJKBTrlzWfvTICaI21nPeDxpmIDCt6WC dHg7hGS9UkNLLWBM/1bJ0QZ+udWOEuEW13XFV03dSvBBM6buZasNzBMIEdvM4zJOoGtx EBdHj36gCShc7RJXdeg4oqg2QG1lKB7Em3ii6HE45j2Kiq/yZpiWzLRbHrxTLRoQvWzs 1g8Q== X-Gm-Message-State: AOJu0YzJB0H20Sxq9lJPdsHBDg0sniL4BfiwShPBl6LkiKwIsi/BvS3R cwqwgE4xs0fw/CSbcDrE6Gnf6g== X-Google-Smtp-Source: AGHT+IFIyimj0pgZ7ge+avAiCLM3XDnvT7w8KKsHu4Up7SRj6VF0hmPmN9BzVV/4AJRLlC92qYiVLw== X-Received: by 2002:a17:907:7897:b0:9a5:ac56:3b63 with SMTP id ku23-20020a170907789700b009a5ac563b63mr2138758ejc.63.1695492226723; Sat, 23 Sep 2023 11:03:46 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.100]) by smtp.gmail.com with ESMTPSA id gs10-20020a170906f18a00b009ae40563b7csm4129447ejb.21.2023.09.23.11.03.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Sep 2023 11:03:46 -0700 (PDT) Message-ID: <5d528036-e506-7b95-69bb-7748b26d2aa8@linaro.org> Date: Sat, 23 Sep 2023 20:03:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 07/15] mailbox: mediatek: Add loop pkt flag and irq handling for loop command Content-Language: en-US To: "Jason-JH.Lin" , Jassi Brar , Krzysztof Kozlowski , Rob Herring , Matthias Brugger , Chun-Kuang Hu , AngeloGioacchino Del Regno Cc: Conor Dooley , Jason-ch Chen , Johnson Wang , Elvis Wang , Singo Chang , Nancy Lin , Shawn Sung , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20230918192204.32263-1-jason-jh.lin@mediatek.com> <20230918192204.32263-8-jason-jh.lin@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20230918192204.32263-8-jason-jh.lin@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230923_110351_247798_8ABE3306 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/09/2023 21:21, Jason-JH.Lin wrote: > CMDQ client can use a loop flag for the CMDQ packet to make current > command buffer jumps to the beginning when GCE executes to the end > of commands buffer. > > GCE irq occurs when GCE executes to the end of command instruction. > If the CMDQ packet is a loopping command, GCE irq handler can not > delete the CMDQ task and disable the GCE thread. > > Add cmdq_mbox_stop to support thread disable How or where do you add it? I do not see it in this patch. Your patchset looks randomly organized. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel