From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AAEDC388F9 for ; Thu, 19 Nov 2020 09:04:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F629221F1 for ; Thu, 19 Nov 2020 09:04:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CVsBMZhC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F629221F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wfZxnDiLAYflPOTLKJzHgX7SBlR9jFid6oQeZUPpRIs=; b=CVsBMZhCxXlJNZoFMsoWoK6WN XpOgnOlDr/t4FJ1+CWwne+zB95ScWgnlyiieZbQYriYN/uMMWQg4rRX8k0LLnXdmVs/yeewAIsfqr GXkM0gh1r194IQ8oxCMOa0SMe2qXKjEPsmEg89JkhG8l+TAsXlGuSAZUjhoKdgd2+fhAAZTyDiNcj 4jR6/fKVNw1ohQsAP5MjNfE4WZKQR997dqd5ht0uH/C4mtFcp+qIG7MKcZdbYKA3TmF3GGPDwOgwn hk1hACSaElTCKMPWpqiganoVlqKF4Vr0p0Z5ptN7vcODoq8KUjoaNSsklAyIr431cK5Sq0udy0PdQ qs9Sf3I/A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kffqs-0004AW-VV; Thu, 19 Nov 2020 09:03:39 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kffqp-00049e-P7 for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 09:03:36 +0000 Received: by mail-ed1-f67.google.com with SMTP id y4so5026292edy.5 for ; Thu, 19 Nov 2020 01:03:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4EQbK8dZn3wmlGNgXi+byhifmTHWQPZyV9gwXQJzxwQ=; b=b8Krmvl6DyUCJ97XqmhMg0ZKwepQrzplzeTMRZEINHka9pox0oV4Qtelb1rhAvyn8g Osd+TCuhfNgiuRMiugA64OW7Or5+Rh/8TmeHvJ+02yBEHiNXPu3yV9VUOuRvGwMCfE7O ekdCT7G+HTbC64AFfpAhOQFAIv/r5E1f0xFy4Xj1c0X8ntyRplL2ivRo1DHQ3LqNGs3r PAD8IQaY5S8FdqYO/KgGqGerrFnliKqECa3N9IHEY4/zH//GSrQELJ8adk3j2CCJOljF JkoPWveHTg5o2vE0n26pcQeRNvAlvG8Mgc0BEfArG0ynz7FLJN/xDnuFQRSB8Fth+8Ve X/Cg== X-Gm-Message-State: AOAM530riVi1W4drrQYoUV6KlYHGvrv8edeCH7ELXERnG1CyJa030QLJ Z74S3pnRAhTsIxa0dxdm6Mc= X-Google-Smtp-Source: ABdhPJyCVoDl/4U59qZyrK2bLtGHzj2zS5F1Zh8a7W02AHfggCa6dmkvPIt3f3ZK0lWvU6+O11/LYw== X-Received: by 2002:aa7:c886:: with SMTP id p6mr28956302eds.352.1605776612681; Thu, 19 Nov 2020 01:03:32 -0800 (PST) Received: from ?IPv6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id n22sm773330edo.43.2020.11.19.01.03.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2020 01:03:31 -0800 (PST) Subject: Re: [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ To: Tian Tao , gregkh@linuxfoundation.org, afaerber@suse.de, manivannan.sadhasivam@linaro.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1605776489-16283-1-git-send-email-tiantao6@hisilicon.com> From: Jiri Slaby Message-ID: <5d722862-f0a8-629e-b01e-5269350762e5@kernel.org> Date: Thu, 19 Nov 2020 10:03:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1605776489-16283-1-git-send-email-tiantao6@hisilicon.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_040335_901017_4CEC5604 X-CRM114-Status: GOOD ( 19.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19. 11. 20, 10:01, Tian Tao wrote: > The code has been in a irq-disabled context since it is hard IRQ. There > is no necessity to do it again. > > Signed-off-by: Tian Tao Reviewed-by: Jiri Slaby > --- > drivers/tty/serial/owl-uart.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/owl-uart.c b/drivers/tty/serial/owl-uart.c > index c149f8c3..472fdaf 100644 > --- a/drivers/tty/serial/owl-uart.c > +++ b/drivers/tty/serial/owl-uart.c > @@ -251,10 +251,9 @@ static void owl_uart_receive_chars(struct uart_port *port) > static irqreturn_t owl_uart_irq(int irq, void *dev_id) > { > struct uart_port *port = dev_id; > - unsigned long flags; > u32 stat; > > - spin_lock_irqsave(&port->lock, flags); > + spin_lock(&port->lock); > > stat = owl_uart_read(port, OWL_UART_STAT); > > @@ -268,7 +267,7 @@ static irqreturn_t owl_uart_irq(int irq, void *dev_id) > stat |= OWL_UART_STAT_RIP | OWL_UART_STAT_TIP; > owl_uart_write(port, stat, OWL_UART_STAT); > > - spin_unlock_irqrestore(&port->lock, flags); > + spin_unlock(&port->lock); > > return IRQ_HANDLED; > } > -- js suse labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel