From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36562C4320A for ; Fri, 13 Aug 2021 10:04:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0269C60E09 for ; Fri, 13 Aug 2021 10:04:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0269C60E09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4zbAmQ7RjLGUpNsXKTIV5pO8/2obCs7Y7Vie8PTfYZw=; b=jYdqfQ4/6BB7/+ MgB5f/52UL4gCaEjQbMOFlTaPl67DGrPGU//1W+jLc5/9+sjOYAajRKjrbvFPtTFygTcR6FHYBfF1 QfMTz1T8w1O25vl/GVvsYK5q7Ka0JEA++bOtrFuLj/MUeNI7vZvyZdsKytt4Co/amOAwjOlIMfIWB k6ckb79eCRef3ncZozwPZEyN5459NhAfWqmWIMZ/DP6JBTUqmJc1XcnG3zpltcEFQi1jz4gRrz1Vd H3VYNTdzSdmPavYfF6CxBjtBRj2Qp+XRhkICgsLQ6i+nSisZHu2Xtgv6WbSQp3A5dwSYz2bKpn1zI QIgnBadZ/feF27sRJZVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEU1F-00CPbb-W1; Fri, 13 Aug 2021 10:02:30 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEU1B-00CPa3-NL for linux-arm-kernel@lists.infradead.org; Fri, 13 Aug 2021 10:02:26 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEU14-0003CR-44; Fri, 13 Aug 2021 12:02:18 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1mEU11-0003w2-Fx; Fri, 13 Aug 2021 12:02:15 +0200 Message-ID: <5da35c2030e57621fa56795cd193e727f53205fe.camel@pengutronix.de> Subject: Re: [v11 2/2] pwm: Add Aspeed ast2600 PWM support From: Philipp Zabel To: Billy Tsai , lee.jones@linaro.org, robh+dt@kernel.org, joel@jms.id.au, andrew@aj.id.au, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Cc: BMC-SW@aspeedtech.com Date: Fri, 13 Aug 2021 12:02:15 +0200 In-Reply-To: <20210812040942.5365-3-billy_tsai@aspeedtech.com> References: <20210812040942.5365-1-billy_tsai@aspeedtech.com> <20210812040942.5365-3-billy_tsai@aspeedtech.com> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210813_030225_803285_6FA29FA9 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Billy, On Thu, 2021-08-12 at 12:09 +0800, Billy Tsai wrote: > This patch add the support of PWM controller which can be found at aspeed > ast2600 soc. The pwm supoorts up to 16 channels and it's part function > of multi-function device "pwm-tach controller". > > Signed-off-by: Billy Tsai > --- [...] > diff --git a/drivers/pwm/pwm-aspeed-ast2600.c b/drivers/pwm/pwm-aspeed-ast2600.c > new file mode 100644 > index 000000000000..f89ce1d4cd67 > --- /dev/null > +++ b/drivers/pwm/pwm-aspeed-ast2600.c > @@ -0,0 +1,327 @@ [...] > +static int aspeed_pwm_probe(struct platform_device *pdev) > +{ [...] > + priv->clk = devm_clk_get(&parent_dev->dev, 0); > + if (IS_ERR(priv->clk)) > + return dev_err_probe(dev, PTR_ERR(priv->clk), > + "Couldn't get clock\n"); > + > + ret = clk_prepare_enable(priv->clk); > + if (ret) > + return dev_err_probe(dev, ret, "Couldn't enable clock\n"); > + > + priv->reset = devm_reset_control_get_shared(&parent_dev->dev, NULL); > + if (IS_ERR(priv->reset)) { > + ret = dev_err_probe(dev, PTR_ERR(priv->reset), > + "Get reset failed\n"); > + goto err_disable_clk; > + } I suggest to request the reset control before enabling the clock. That way you can simplify the error path and avoid enabling the clock in case of reset_control_get failure. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel