From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83650C43603 for ; Wed, 7 Apr 2021 15:50:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16D7F6138B for ; Wed, 7 Apr 2021 15:50:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16D7F6138B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:Cc:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YXvOkzG6Vl0o+/LzxrUYfGFRO2/BqTpclTwywQU4MaA=; b=NT+7B9ypeGu4X/egvo76mKHWw HA+PymW7FnNqHAUrXbQt5BgvMQ8tqBvn4r+K3PxHHQ9hjQIFolmL0zQODzGSZcRw8z6as3dr1JsBe oOeK5SqP4cyZoCHy9FCo3Gi/bqEmjFPp4UyGFTNsCBGigfwre1UlUwiLMy1tmWnE5+iBFxmVEc+aK vZ/DSEWE6hEr7bKdxmbkEnP1fz2CMtHwGPf5e4Lu7bRV1IlV7SIOfgCaUP3OwXpIqvs/p6Q/5GfHh hurC+as2785YEQhjYNhofqfW0+7nUu2MZhDFaTz9YLWBbP0yNofUhwXQdn/scS38Gvn4BfzKG1DVs supKNt0Xg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUAQ4-005JvG-Cv; Wed, 07 Apr 2021 15:48:40 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUAPx-005JtP-37; Wed, 07 Apr 2021 15:48:35 +0000 Received: by mail-wm1-x32e.google.com with SMTP id b133-20020a1c678b0000b02901231346381dso1431750wmc.0; Wed, 07 Apr 2021 08:48:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=VXyrtGnwTjNkgIA1jrziNG4eeLUP6i3fUCHQ1vhVTNk=; b=AT3fDu5INkxhj3Ycskj+25gD7VvEaPZFZOqS+dhmjSsFiVZ01PPcXhLNUTnVfU6F9T E0XhY4u1NBJm5jTKMs7AcK+gzPIAXkVqEgk+T49IfKZLkDo5mqKZKRVFf11vkcvr5LUA jXeX/IYQl6oBAUQLk3c2+KmMoN8w+LME7R5+tp200su1i7v4ClMarRdCiNqfPZnLAqX1 k7FMPChv+9NMP1ym25RwMfvTL/6KVRO1Kh1ziGhSI4x7ijLJK86xHGHdwQJ+fVlh/7Be Z1oGWwNYGPu9/pqRHVoHZRW8mBI6HXAVhCeK00BOayKoSU9s9USmOKT4eQRZ/kGHWoJ4 5u1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=VXyrtGnwTjNkgIA1jrziNG4eeLUP6i3fUCHQ1vhVTNk=; b=T61SjKdwcEuhU9na0/0Z2BP3MnUr2LERtmIpJlAznqSywfC1r8toGVcZz5H57BRDyX /VdNav6oZPL97S5P0KvJ2y08pvrNugoagafgivGDLtjl5tAhobc9sqKnsBOm3DYkIqCw KWs3mL50DUrOpuLaXPeNnCXedrjnM8cmWwZmLz+bDl+Nv+MP5CsHFXpa+3bC6r+V9wZL aGK5ay6rDglH0GlzkHAoe49tXKycRY+KgpKQ6joYv+F45tyV3531LPJwKz/SIolBrR6V t5TKlJC4SblXljtbstvPJxBl40e8Fop80vnESXHZpet+DSxDY7tKCB2jVK2LQzot+WFI zYjg== X-Gm-Message-State: AOAM5319WArocoDam3rMNVpSk6PonzW+Lo0V/KU4tAKDSdmo8PfNnAhA b0dsnPjaaZghten2lnRM/Ds= X-Google-Smtp-Source: ABdhPJzD7dxKEjfVHj/Mt5EH5n5S/dlaxsmEkejN73MZv+TvkDOrEI5rgccyVlOqrKVUnws2nEHr5A== X-Received: by 2002:a05:600c:2946:: with SMTP id n6mr3655449wmd.52.1617810511641; Wed, 07 Apr 2021 08:48:31 -0700 (PDT) Received: from 192.168.10.5 ([39.46.7.73]) by smtp.gmail.com with ESMTPSA id v185sm9224838wmb.25.2021.04.07.08.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 08:48:31 -0700 (PDT) Message-ID: <5daaeac37cfa5c07a1880ae49b712566a561ba1a.camel@gmail.com> Subject: Re: [PATCH] staging: axis-fifo: media/meson: remove redundant dev_err call From: Muhammad Usama Anjum To: Hans Verkuil Cc: musamaanjum@gmail.com, linqiheng@huawei.com, kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com, Greg Kroah-Hartman , Neil Armstrong , Mauro Carvalho Chehab , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "open list:STAGING SUBSYSTEM" , open list , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "moderated list:ARM/Amlogic Meson SoC support" Date: Wed, 07 Apr 2021 20:48:21 +0500 In-Reply-To: <93218bc8-2cbb-bacc-f985-876a842261c4@xs4all.nl> References: <20210407101047.GA1491258@LEGION> <93218bc8-2cbb-bacc-f985-876a842261c4@xs4all.nl> User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_164833_333634_86C387B4 X-CRM114-Status: GOOD ( 19.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-04-07 at 16:05 +0200, Hans Verkuil wrote: > Hi Muhammad, > > On 07/04/2021 12:10, Muhammad Usama Anjum wrote: > > devm_ioremap_resource() prints error message in itself. Remove the > > dev_err call to avoid redundant error message. > > Please split this up into two separate patches! They are independent > changes and these two drivers are maintained by different people as well. > > The patch itself looks OK, but it really has to be two separate patches. > Okay. I'll send two separate patches. Thank you. Regards, Usama > Regards, > > Hans > > > Signed-off-by: Muhammad Usama Anjum > > --- > > drivers/staging/axis-fifo/axis-fifo.c | 1 - > > drivers/staging/media/meson/vdec/vdec.c | 8 ++------ > > 2 files changed, 2 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > > index 2bb1c2e9cb57..ed9281089738 100644 > > --- a/drivers/staging/axis-fifo/axis-fifo.c > > +++ b/drivers/staging/axis-fifo/axis-fifo.c > > @@ -853,7 +853,6 @@ static int axis_fifo_probe(struct platform_device *pdev) > > fifo->base_addr = devm_ioremap_resource(fifo->dt_device, r_mem); > > if (IS_ERR(fifo->base_addr)) { > > rc = PTR_ERR(fifo->base_addr); > > - dev_err(fifo->dt_device, "can't remap IO resource (%d)\n", rc); > > goto err_initial; > > } > > > > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c > > index 5d4db7a5b4b5..e51d69c4729d 100644 > > --- a/drivers/staging/media/meson/vdec/vdec.c > > +++ b/drivers/staging/media/meson/vdec/vdec.c > > @@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev) > > > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos"); > > core->dos_base = devm_ioremap_resource(dev, r); > > - if (IS_ERR(core->dos_base)) { > > - dev_err(dev, "Couldn't remap DOS memory\n"); > > + if (IS_ERR(core->dos_base)) > > return PTR_ERR(core->dos_base); > > - } > > > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser"); > > core->esparser_base = devm_ioremap_resource(dev, r); > > - if (IS_ERR(core->esparser_base)) { > > - dev_err(dev, "Couldn't remap ESPARSER memory\n"); > > + if (IS_ERR(core->esparser_base)) > > return PTR_ERR(core->esparser_base); > > - } > > > > core->regmap_ao = > > syscon_regmap_lookup_by_phandle(dev->of_node, > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel