From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C9E2C433DB for ; Fri, 12 Mar 2021 14:06:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA74664FFB for ; Fri, 12 Mar 2021 14:06:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA74664FFB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bdB9Befp4uW48eW7rhqUYw/yMXVzEmfnV/5QyXBZYNQ=; b=hczi9Cfx1LpGEYQvxRQd12U/F 8ji31V/xPvDKK1D7BggcZMaMWbqzNjW8Gbao6Stws5TRWkdmArX99xZi9+I2XfG5pA6WhU/O3r7z2 9ITEfZkubDyg7K+X4fITfD3bldi8+ZxgvAB3g4PVVhjv42T7x2hiAteHcG9ft8VF3/E6v2VAfCl9M GKfRtwd/H/z/qrN7q5U++AlXOpUSpfkAkrj+oXfqP1t+PLt4J6JPyZhtsWFRPhs08WyCdh6fPMdkr c1kw6S4O6V90jcppFmbcGiQwXxLWsJmL/yQaqwCjSPxmJoc1vUeNrOOFzk+7KtInnBYrprrDcX6I3 f9dpwp9rg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKiPi-00BaC9-16; Fri, 12 Mar 2021 14:05:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKhCc-00BSGs-8Z for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 12:49:41 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E8A7864FE0; Fri, 12 Mar 2021 12:47:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615553256; bh=tC9vXuNeMt2BcsSWomDvOlVNAT15v0VJGkzD4Spk0nk=; h=Subject:List-Id:To:References:From:Date:In-Reply-To:From; b=SBXMNvUWf1XVnDxY8VlIAVrxvfKd50uGoa3aJz0VWBFfyDk+qHSm85xZM/9jbmrt2 GPFZ1bPWPXGlPlEXPslBLW1OCbV0GnsJui1JTq+UmleN7b49Wf0AqoJiTPnvdS41/E Yu0Libd3eiVPXFm3dNSuZAZC19beLgkXEDaPrqgtdC4CxHjLwPwFa8QYvTpa83nXFo 0LeqqdQ3WESLGfE0z2xrUhduHLXfAvxoIdsF/CsclCyLWmL/fxb69A7vpr8jhbBzM+ L+4Ed9UBxDCULa+USnF4te+wbOUgTTbjOug9B3xkUwAZcmyA8I5wVjECfuZhnM9QtC JTnAl9rdPo93Q== Subject: Re: [PATCH v3 05/15] clk: socfpga: build together Stratix 10, Agilex and N5X clock drivers List-Id: To: Krzysztof Kozlowski , Russell King , Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Vinod Koul , Borislav Petkov , Tony Luck , James Morse , Robert Richter , Moritz Fischer , Tom Rix , Lee Jones , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Philipp Zabel , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, dmaengine@vger.kernel.org, linux-edac@vger.kernel.org, linux-fpga@vger.kernel.org, linux-i2c@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20210311152545.1317581-1-krzysztof.kozlowski@canonical.com> <20210311152545.1317581-6-krzysztof.kozlowski@canonical.com> From: Dinh Nguyen Message-ID: <5dc72298-a44a-1f99-c7d6-b69001f7c7fe@kernel.org> Date: Fri, 12 Mar 2021 06:47:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210311152545.1317581-6-krzysztof.kozlowski@canonical.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_124939_803957_0BA02C57 X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/11/21 9:25 AM, Krzysztof Kozlowski wrote: > On a multiplatform kernel there is little benefit in splitting each > clock driver per platform because space savings are minimal. Such split > also complicates the code, especially after adding compile testing. > > Build all arm64 Intel SoCFPGA clocks together with one entry in > Makefile. This also removed duplicated line in the Makefile (selecting > common part of clocks per platform). > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/clk/socfpga/Kconfig | 6 +++--- > drivers/clk/socfpga/Makefile | 7 +++---- > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/clk/socfpga/Kconfig b/drivers/clk/socfpga/Kconfig > index 3c30617169bf..bc102e0f0be0 100644 > --- a/drivers/clk/socfpga/Kconfig > +++ b/drivers/clk/socfpga/Kconfig > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > config CLK_INTEL_SOCFPGA64 > bool > - # Intel Agilex / N5X clock controller support > - default (ARCH_AGILEX || ARCH_N5X) > - depends on ARCH_AGILEX || ARCH_N5X > + # Intel Stratix / Agilex / N5X clock controller support > + default (ARCH_AGILEX || ARCH_N5X || ARCH_STRATIX10) > + depends on ARCH_AGILEX || ARCH_N5X || ARCH_STRATIX10 > diff --git a/drivers/clk/socfpga/Makefile b/drivers/clk/socfpga/Makefile > index c6db8dd4ab35..ebd3538d12de 100644 > --- a/drivers/clk/socfpga/Makefile > +++ b/drivers/clk/socfpga/Makefile > @@ -1,7 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > obj-$(CONFIG_ARCH_SOCFPGA) += clk.o clk-gate.o clk-pll.o clk-periph.o > obj-$(CONFIG_ARCH_SOCFPGA) += clk-pll-a10.o clk-periph-a10.o clk-gate-a10.o > -obj-$(CONFIG_ARCH_STRATIX10) += clk-s10.o > -obj-$(CONFIG_ARCH_STRATIX10) += clk-pll-s10.o clk-periph-s10.o clk-gate-s10.o > -obj-$(CONFIG_CLK_INTEL_SOCFPGA64) += clk-agilex.o > -obj-$(CONFIG_CLK_INTEL_SOCFPGA64) += clk-pll-s10.o clk-periph-s10.o clk-gate-s10.o > +obj-$(CONFIG_CLK_INTEL_SOCFPGA64) += clk-s10.o \ > + clk-pll-s10.o clk-periph-s10.o clk-gate-s10.o \ > + clk-agilex.o > Acked-by: Dinh Nguyen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel