From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
To: Robert Marko <robert.marko@sartura.hr>,
srini@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, nicolas.ferre@microchip.com,
horatiu.vultur@microchip.com, daniel.machon@microchip.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: luka.perkov@sartura.hr
Subject: Re: [PATCH v3 2/3] nvmem: lan9662-otp: add support for LAN969x
Date: Sat, 16 May 2026 19:27:08 +0300 [thread overview]
Message-ID: <5dfea4a0-3f10-44e4-8be4-cf011db09016@tuxon.dev> (raw)
In-Reply-To: <20260515115954.701155-2-robimarko@gmail.com>
Hi, Robert,
> static int lan9662_otp_probe(struct platform_device *pdev)
> @@ -196,6 +194,7 @@ static int lan9662_otp_probe(struct platform_device *pdev)
>
> otp_config.priv = otp;
> otp_config.dev = dev;
> + otp_config.size = (uintptr_t) device_get_match_data(dev);
>
> nvmem = devm_nvmem_register(dev, &otp_config);
>
> @@ -203,7 +202,14 @@ static int lan9662_otp_probe(struct platform_device *pdev)
> }
>
> static const struct of_device_id lan9662_otp_match[] = {
> - { .compatible = "microchip,lan9662-otpc", },
> + {
> + .compatible = "microchip,lan9662-otpc",
> + .data = (const void *) SZ_8K,
> + },
> + {
> + .compatible = "microchip,lan9691-otpc",
> + .data = (const void *) SZ_16K,
> + },
Some checks from checkpatch:
[Checkpatch] CHECK: No space is necessary after a cast
#51: FILE: drivers/nvmem/lan9662-otpc.c:197:
+ otp_config.size = (uintptr_t) device_get_match_data(dev);
CHECK: No space is necessary after a cast
#62: FILE: drivers/nvmem/lan9662-otpc.c:207:
+ .data = (const void *) SZ_8K,
CHECK: No space is necessary after a cast
#66: FILE: drivers/nvmem/lan9662-otpc.c:211:
+ .data = (const void *) SZ_16K,
total: 0 errors, 0 warnings, 3 checks, 44 lines checked
next prev parent reply other threads:[~2026-05-16 16:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 11:59 [PATCH v3 1/3] dt-bindings: nvmem: lan9662-otpc: Add LAN969x series Robert Marko
2026-05-15 11:59 ` [PATCH v3 2/3] nvmem: lan9662-otp: add support for LAN969x Robert Marko
2026-05-16 16:27 ` Claudiu Beznea [this message]
2026-05-15 11:59 ` [PATCH v3 3/3] arm64: dts: microchip: lan969x: add OTP node Robert Marko
2026-05-16 16:26 ` Claudiu Beznea
2026-05-16 16:27 ` [PATCH v3 1/3] dt-bindings: nvmem: lan9662-otpc: Add LAN969x series Claudiu Beznea
2026-05-19 15:11 ` (subset) " Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dfea4a0-3f10-44e4-8be4-cf011db09016@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=nicolas.ferre@microchip.com \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox