From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53708C433E2 for ; Thu, 3 Sep 2020 17:33:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2400B206C0 for ; Thu, 3 Sep 2020 17:33:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YZVevAVI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="QNI5HP0m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2400B206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oX1AHun5y7p0yD8uSJmnKd3z+npPvc7NAEc63GrOwFs=; b=YZVevAVIsMK9mRVpLmDQ3pFQc hleLKOSzeviHpLB8mbioGn7slsJf4t+xgq/85pGgM87uWCB8Y3VnCyvLFKy3LNP/Iu9w8ymXBoZBW 3uW98nl1Yg0rN25semFvZhHhE9KuVM1ip2RiZjIhHhKdBKUC6IDp0z5MjLCnVyHllFDYb/r8jeX8L R7QUnfFzLdiKkEqotPeg8OCSLXXCizS071Wa2KW0Y/TRmQz8ghCupEQlkLuZvoGxF7S/rjF1xygHi mahU24JjfsPE2bKQfP7tTZvP4hHrm+A4QS/Onkns1yy+bdblR/t9sbgDCpnpRHQ5SxvkRybYo+yM0 QmCwyERuw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDt5T-0002Kd-CE; Thu, 03 Sep 2020 17:31:51 +0000 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDt5Q-0002Jh-Pf for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 17:31:50 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 03 Sep 2020 10:31:32 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 03 Sep 2020 10:31:46 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 03 Sep 2020 10:31:46 -0700 Received: from rcampbell-dev.nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 3 Sep 2020 17:31:45 +0000 Subject: Re: [PATCH 1/2] arm64/mm: Change THP helpers to comply with generic MM semantics To: Catalin Marinas , Anshuman Khandual References: <1597655984-15428-1-git-send-email-anshuman.khandual@arm.com> <1597655984-15428-2-git-send-email-anshuman.khandual@arm.com> <20200903165631.GC31409@gaia> From: Ralph Campbell X-Nvconfidentiality: public Message-ID: <5e148194-58c2-89c2-2cd8-9f2086f1e090@nvidia.com> Date: Thu, 3 Sep 2020 10:31:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200903165631.GC31409@gaia> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1599154292; bh=f2fM2vwocWZ3kjufXMQxbdqVic6XFgHZzhjDyCnkunM=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=QNI5HP0mnE11hwdtt//Zo7KAtHH9mutFkC4v29SLNtD3RB0sKvljOyjJnoPg+nCNM g+qnLvvVo8HmZ/lXWGqm0dCvXsip0qT67hm2Pi5MyMMb9CeerPM3SMY1oBZWFU+GLi iDyu+m1RiBar/mNEX68xxKokJtsOiKYauiJaX5OpW5taL58vgmY+vUh/oPN/eVXnZr r2yFhkOEOz1gESPASBuELH47vVnksoAmeTIpU8qRKYseB7Ky2Jj9MQZDLq/lb7VWla m5aCR0YsGQSuBd26pUDXoM3Ji2XbK+mMbD797bTL+BujGtVTSA4uXS6c5OA64PUjX/ 0nR2261UeRJRw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_133148_908364_5445C8E2 X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suzuki Poulose , Marc Zyngier , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/3/20 9:56 AM, Catalin Marinas wrote: > On Mon, Aug 17, 2020 at 02:49:43PM +0530, Anshuman Khandual wrote: >> pmd_present() and pmd_trans_huge() are expected to behave in the following >> manner during various phases of a given PMD. It is derived from a previous >> detailed discussion on this topic [1] and present THP documentation [2]. >> >> pmd_present(pmd): >> >> - Returns true if pmd refers to system RAM with a valid pmd_page(pmd) >> - Returns false if pmd does not refer to system RAM - Invalid pmd_page(pmd) > > The second bullet doesn't make much sense. If you have a pmd mapping of > some I/O memory, pmd_present() still returns true (as does > pte_present()). > >> diff --git a/arch/arm64/include/asm/pgtable-prot.h b/arch/arm64/include/asm/pgtable-prot.h >> index 4d867c6446c4..28792fdd9627 100644 >> --- a/arch/arm64/include/asm/pgtable-prot.h >> +++ b/arch/arm64/include/asm/pgtable-prot.h >> @@ -19,6 +19,13 @@ >> #define PTE_DEVMAP (_AT(pteval_t, 1) << 57) >> #define PTE_PROT_NONE (_AT(pteval_t, 1) << 58) /* only when !PTE_VALID */ >> >> +/* >> + * This help indicate that the entry is present i.e pmd_page() > > Nit: add another . after i.e Another nit: "This help indicate" => "This helper indicates" Maybe I should look at the series more. :-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel