From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04E3AC433EF for ; Thu, 14 Oct 2021 11:04:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C123C60EE2 for ; Thu, 14 Oct 2021 11:04:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C123C60EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vbh5ShMJBVYjIYfLhv+PdcfAJcXJ2auKjsIfoQrAenM=; b=euk94jVr/GjLGlNNH9Odt22dCn W+Tit8LXxl4p2EULTamH4O2iMJtfPcGCig2wFA/W5lEPkP56rj892q0jUv/fhn+H96LMFsYCwipIo 80/lCiKY4kXt9Scz0fSCXOokhQQk0ZrKOTUlY/9YSZr8ez9Vo7xGzrh3amrIKQP93/hTLRbM8FPJf zTgDO++GIzBISoPDFaRPWlwqyjjNASvd70iSOlEYMyA6BKhcrty3A3tZhd7k87t8dRkD42yGyef84 TE4ohuO8ftDRArRj1oEuV3d7cOnQIRQ6stCKLHq9qnR4pgSH3YEWM8VlQeaEgoiDrHEtGGVAKZO2V /kQvHUOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mayVr-002k4U-Au; Thu, 14 Oct 2021 11:03:03 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mayVm-002k1Q-Hp; Thu, 14 Oct 2021 11:03:00 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 2A1B11F44A4A Subject: Re: [PATCH v7, 12/15] media: mtk-vcodec: Support 34bits dma address for vdec To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20211011070247.792-1-yunfei.dong@mediatek.com> <20211011070247.792-13-yunfei.dong@mediatek.com> From: AngeloGioacchino Del Regno Message-ID: <5e1c165d-176c-0141-dc96-0fdbda367c03@collabora.com> Date: Thu, 14 Oct 2021 13:02:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211011070247.792-13-yunfei.dong@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211014_040258_733178_E2512B9E X-CRM114-Status: GOOD ( 19.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Use the dma_set_mask_and_coherent helper to set vdec > DMA bit mask to support 34bits iova space(16GB) that > the mt8192 iommu HW support. > > Whole the iova range separate to 0~4G/4G~8G/8G~12G/12G~16G, > regarding which iova range VDEC actually locate, it > depends on the dma-ranges property of vdec dtsi node. > > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > index de83e3b821b4..da963cdac96b 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > @@ -376,6 +376,9 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > } > } > > + if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL)) > + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); > + This function returns 0 for success, or negative number for failure: please check the return value, or this driver may not work correctly in some corner cases. Regards, - Angelo > for (i = 0; i < MTK_VDEC_HW_MAX; i++) > mutex_init(&dev->dec_mutex[i]); > spin_lock_init(&dev->irqlock); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel