From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13537CA5FDD for ; Fri, 2 Oct 2026 15:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kcjfQ5ymIisttB0GsRJsoZ1cbdsf3RMR9qOADxiZqgI=; b=T/5NJFVAs1RtEKBwHzRqeN8tnP WysSDXHKLxbzwy+U9Tz164umXpIcbyBzd+dW4tot+RmBSS/UVN3p43Lsfgk7N8p1gyY1EaTcQefIh XDQdUZgsIq4bmVvTySruJz4p7sEjfc7wZjPfhv2dVqBdK2BuYb32eNo1ETsdETLnYI29M4/CUe8e9 NhCEl/hQFTIPqzAAp+KiuFD3GIeUNGrL2beaBMxV5kJuZ+E4hW3DE8ZwoOllrx/ZieFcIlWXmB2ti MWXdVOWiJ3+HHCrCiUDxv/yHT9MancDfN3UJtbj1J4Fk/lCM6ERBCvC+ISTx9wsUVyEhBRQzhLsWV ZrtVoglA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xCfK8-0000000Bx0g-2hLm; Fri, 02 Oct 2026 15:37:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xCfK0-0000000BwxJ-0ZHM for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2026 15:37:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B9ED2143D; Fri, 2 Oct 2026 08:37:11 -0700 (PDT) Received: from [10.211.55.3] (unknown [10.57.85.160]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B7A793F85F; Fri, 2 Oct 2026 08:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1790955435; bh=foa6XwYtr8xyzw32x0UaY54r5ooOR0Xwx4/wTj49JHQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RMAi+p1uYvwpcb4tdmvngdBqFCAZkEc1A8CfLpANi736kw9NTfzbJRVQVwWQzuPz2 lqAEfDfBSZ6q+L/SD7MScIMOFbMEYvEaa3o7TCsJ5PL1IsDl82XSWJ85MaIJxkye7p FDLuUJoWyZvNgpqSQqeGLn7/B6u5hVJ8+MHUFCW0= Message-ID: <5e762f77-96a8-46c2-8f3b-04e8eed576dc@arm.com> Date: Fri, 2 Oct 2026 16:37:10 +0100 MIME-Version: 1.0 User-Agent: Thunderbird Daily Subject: Re: [PATCH v12 09/13] arm_mpam: propagate MSC access errors in mpam_reset_class_locked() To: Andre Przywara , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , James Morse , Reinette Chatre , Fenghua Yu Cc: Jonathan Cameron , Srivathsa L Rao , Ganapatrao Kulkarni , Trilok Soni , Srinivas Ramana , Niyas Sait , Lee Trager , Ritwick Sharma , Gavin Shan , linux-acpi@vger.kernel.org--cc, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20261001153439.3295416-1-andre.przywara@arm.com> <20261001153439.3295416-10-andre.przywara@arm.com> Content-Language: en-US From: Ben Horgan In-Reply-To: <20261001153439.3295416-10-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261002_083716_275247_CD567537 X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andre, On 01/10/2026 16:34, Andre Przywara wrote: > The mpam_reset_ris() function can return an error, propagate this up > through mpam_reset_component_locked() to mpam_reset_class_locked(), > which is exported. The external caller is a void function, so cannot > really handle the error at the moment, but at least we report everything > on the MPAM interface side. > > Signed-off-by: Andre Przywara > Reviewed-by: Jonathan Cameron Reviewed-by: Ben Horgan Thanks, Ben > --- > drivers/resctrl/mpam_devices.c | 24 ++++++++++++++++++------ > drivers/resctrl/mpam_internal.h | 2 +- > 2 files changed, 19 insertions(+), 7 deletions(-) > > diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c > index 60f6a39176ea1..c639aaa5f38e1 100644 > --- a/drivers/resctrl/mpam_devices.c > +++ b/drivers/resctrl/mpam_devices.c > @@ -3007,7 +3007,7 @@ static void mpam_enable_once(void) > mpam_partid_max + 1, mpam_pmg_max + 1); > } > > -static void mpam_reset_component_locked(struct mpam_component *comp) > +static int mpam_reset_component_locked(struct mpam_component *comp) > { > struct mpam_vmsc *vmsc; > > @@ -3021,26 +3021,38 @@ static void mpam_reset_component_locked(struct mpam_component *comp) > srcu_read_lock_held(&mpam_srcu)) { > struct mpam_msc *msc = vmsc->msc; > struct mpam_msc_ris *ris; > + int ret; > > list_for_each_entry_srcu(ris, &vmsc->ris, vmsc_list, > srcu_read_lock_held(&mpam_srcu)) { > - if (!ris->in_reset_state) > - mpam_touch_msc(msc, mpam_reset_ris, ris); > + if (!ris->in_reset_state) { > + ret = mpam_touch_msc(msc, mpam_reset_ris, ris); > + if (ret) > + return ret; > + } > ris->in_reset_state = true; > } > } > + > + return 0; > } > > -void mpam_reset_class_locked(struct mpam_class *class) > +int mpam_reset_class_locked(struct mpam_class *class) > { > struct mpam_component *comp; > + int ret; > > lockdep_assert_cpus_held(); > > guard(srcu)(&mpam_srcu); > list_for_each_entry_srcu(comp, &class->components, class_list, > - srcu_read_lock_held(&mpam_srcu)) > - mpam_reset_component_locked(comp); > + srcu_read_lock_held(&mpam_srcu)) { > + ret = mpam_reset_component_locked(comp); > + if (ret) > + return ret; > + } > + > + return 0; > } > > static void mpam_reset_class(struct mpam_class *class) > diff --git a/drivers/resctrl/mpam_internal.h b/drivers/resctrl/mpam_internal.h > index 68a6cf2b9cc73..09f8168fb4d2c 100644 > --- a/drivers/resctrl/mpam_internal.h > +++ b/drivers/resctrl/mpam_internal.h > @@ -465,7 +465,7 @@ void mpam_enable(struct work_struct *work); > void mpam_disable(struct work_struct *work); > > /* Reset all the RIS in a class under cpus_read_lock() */ > -void mpam_reset_class_locked(struct mpam_class *class); > +int mpam_reset_class_locked(struct mpam_class *class); > > int mpam_apply_config(struct mpam_component *comp, u16 partid, > struct mpam_config *cfg);