From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10B66C27C4F for ; Thu, 13 Jun 2024 17:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lmCat4yFzakLoPqsICLGJKZ86qrL9CrdVXXkrAz9XWA=; b=AKIZ8U7VYocZOFO48h4Q5oXuU/ sR84P/vYUjM7gAS/iKIac84yQCP+L8sglIzzZQz81q7y5L/9Afz2O2MHM+Q05zln80fpbphj+oxFy YmUzoK4sjpTli3q92l3V2hzKn7JlpKh9CgE4aatZYQ95cHqCq4eY5xv16ipjDErEJ2SWJojVZGLQo eCvs1nGlD+ZtsEQObXROoL48pyqJAPIT3ornXUrXNVauSJ0HSluWhjqwSDg8OjsimX8yol/IyXONP 9SBcqSh9P7WTVXmM+XSc1zNVNmya3ojlL3QtcDExCZmcVWILr7ZGwGkNqv3ekImjnxHrq1NA6Qf94 djp95m5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHo7v-0000000HVPF-0r2P; Thu, 13 Jun 2024 17:20:43 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHo7m-0000000HVJt-37ya for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2024 17:20:37 +0000 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-52c84a21b8cso1250585e87.1 for ; Thu, 13 Jun 2024 10:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718299232; x=1718904032; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lmCat4yFzakLoPqsICLGJKZ86qrL9CrdVXXkrAz9XWA=; b=JKEKikx6c9JLj6RZANDJ96sdLbjpZGe9DZr6bi9jUQP2Fhd4fK2460NsG84Yjx86Ka RTiZnBj9hRsp2aX/KkL3QHVmmsQ/TAdVjvI34wQlxSr/9xauSzPsk+NrHAL7S+F4KzAx jutxhn/Eh9PaA2mfkxiHOMbdoRdRJjNeUt6GS8VM2m7Y6mFTgVPV7/mawlkhLeV2CXtv 8cY1HuoE2HuNMc/n6lHTJQ15N0NJOMmFbLly+BzITxkhta3ma+Vj7g2l6ePfNJw52RZe MBRY8pbVbpw+vaaTrQN1hAJvH1+oQX8iZCj+dqj8XdBHbYG+QnRsinTcXUsAF8gnD1Dx z4Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718299232; x=1718904032; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lmCat4yFzakLoPqsICLGJKZ86qrL9CrdVXXkrAz9XWA=; b=wSRzMFBbOiOydXHpaFUzUDWeVXuIfEuu5LRIWHKDODrdmpSpinSKsMlwvLrTUQ5xeN 6FfpyeYtvjtXFZVmX1e/gW3RCcBSYqc/+RPub6HWo16pcmC53p8weTjrgoALDzT/gywL XMDpVCmAV96U5x6JeHTSFP1NHB9DMncpe3La3JEC6cja59K9zak6p3c+eJPwrcIWAlmN SsgmTMan0Ye/o6kc0l08j8reQxIuDrV1OY8lUZvpFPW7GrJhEHgSyo0SpG1f2ETbmT26 Sx2ucN8KiWLyfN2epWuWuhvG9ILV0KyLH2vFtB8zrCm5wO5kpToiQMt/xRUfH9zJs8ZM P1ZA== X-Forwarded-Encrypted: i=1; AJvYcCVbxmzraxILV+0SCicvKS66lOzPS5QBQ+f/2yKRXnB4VvmfwdmXH8h13eYLyB3kljVJ6E0TK4qjxllC7QDWtVot1Ueg2zXBmkQQYyOIl8GGsc49YIs= X-Gm-Message-State: AOJu0YzmvKke1U5M5StPBUGmvARqwKdR6F0RSkg8HPViki0o5OUkQq7F JHcwQ1AG5oH0wI8wIb5bFrcZ55AQ3yAU50eqTGV1ffXOKkt79cOVjT+UIoEOKHM= X-Google-Smtp-Source: AGHT+IE4j3HMxhLWYVU29TQZzIBVMZHRaQ5xZ54nQ/SRi+BohkpWnbIsKLlp0bKYqGHndxwko/uGhQ== X-Received: by 2002:ac2:5183:0:b0:52c:8daf:da1c with SMTP id 2adb3069b0e04-52ca6cb877emr133289e87.20.1718299232137; Thu, 13 Jun 2024 10:20:32 -0700 (PDT) Received: from ?IPV6:2a00:f41:900a:a4b1:9ab2:4d92:821a:bb76? ([2a00:f41:900a:a4b1:9ab2:4d92:821a:bb76]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52ca2887effsm295391e87.257.2024.06.13.10.20.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jun 2024 10:20:31 -0700 (PDT) Message-ID: <5e916d38-7dce-43d7-bee0-a10842faabfe@linaro.org> Date: Thu, 13 Jun 2024 19:20:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ARM: dts: qcom: motorola-falcon: add accelerometer, magnetometer To: Stanislav Jakubek Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org References: <2b39d763-5b79-4b21-85f9-22fee9f87468@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240613_102034_821615_03B1AE46 X-CRM114-Status: GOOD ( 10.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/13/24 19:18, Stanislav Jakubek wrote: > On Thu, Jun 13, 2024 at 09:48:26AM +0200, Konrad Dybcio wrote: >> >> >> On 6/9/24 13:05, Stanislav Jakubek wrote: >>> Add the accelerometer and magnetometer that are present on the Motorola >>> Moto G (2013) device. >>> >>> Signed-off-by: Stanislav Jakubek >>> --- >> >> [...] >> >>> +&blsp1_i2c2 { >> >> Consider setting a clock-frequency = <> > > Hi Konrad, > > checking downstream [1], qcom,i2c-bus-freq for I2C2 is 100000, which seems > to be the default. Should I specify it anyway? Yes, at the very least to silence the dmesg warning ;) Konrad