From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B1C6C5321D for ; Fri, 23 Aug 2024 16:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZWSBeG+QwbjFSDvLyDhLEv05keKw5jJM6jqldDdTU5o=; b=sZhfd4lTYijyOMJRQGrsYKM9A3 n+20Cx6vgbUxbya51nANCu93HVWfExrMUPXvpbZRHhwUM10rfEeI4Y7Gqp+W9DhA0tJMDgz644yR6 7DINm4aWT+hZtV2h9WruuwxfBIJz/36wM8GgwIdOPZzWKUTLRKbsjbpaxYmT4fchPbRWt7BcxWhhs c/k/bwHtP4BdlSLDL+p8hUpIFBUIOE/YbMPuRCzZEpp2SruYVkefTdnnI6dHEzgzKYrWkYYRgMo7W 2dW2JDuzUK48XVVEcpsV1+jtWf+kCXKYD7Lg/o/9jpsE9B76ySYQ02z1StH4zf1RghCtp3gMb6idv 4objNcfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shX95-0000000HZ94-0Kk8; Fri, 23 Aug 2024 16:28:15 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shX7f-0000000HYTn-3bpn for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 16:26:49 +0000 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2f3f90295a9so23036491fa.0 for ; Fri, 23 Aug 2024 09:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724430406; x=1725035206; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZWSBeG+QwbjFSDvLyDhLEv05keKw5jJM6jqldDdTU5o=; b=dm+eDpUOICmQya7SKpfuQyWDSpYo95dpieYZPjvr1uVzOxQ4Gs+C6Y7ggdKbXeobWO +hbhyD62C/lbd7MPwO4OxOcn+Q1LIF4QcligzD1xJG0UoKftFqaoixEFNeRebU9bF5VP jTotObLRF2BKqZubxnG5m7fqWyOClLaSBXUeLkYyzB7Iq+KZtL4qmXrqzDMY2YoY/Fvi HgxgGaXU4en+cnifrXqDtjYKWRE+PFdizJQgeTJ2/CHvtCEVfkjoJ3fa70XgzPxadm8q oQCSxS4MARiN/G9NJN3BAUC/SLkmsMyoJqgkoCb4XyXK3RGobsNY2YnWMsDFF+aN9ErW p4/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724430406; x=1725035206; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZWSBeG+QwbjFSDvLyDhLEv05keKw5jJM6jqldDdTU5o=; b=Tqetz8PAvAG2lKR8zBQ3b7lcct2HA31AKcxwE2kXNZJn5yJ5IqggNcTxpsgfxgLM68 +42f34djG5Zti5QmGJuvWLj5zqZ1nopikcaSZHTLLCoLJXgmZA5kV13db5SONJCmEmbY U7kn2zoyf+o+/n62K+67M+mah7hUEEDuzdGD6VVInL/8LmCu1itiza0wrAojayNikdb0 JdasFmjakXIuOC58F+SSCLO+oC6FPxuqvpUe6iZN+1Vq9LL1q5PKZmYf0Obo+b2zCa7d 9lMAMbQYDTogi/0KKnvofrHMuXI/hD6+xjZ6SMYv3VtgaBSce4HwKdAWRtBI6IKPrMYo a85A== X-Forwarded-Encrypted: i=1; AJvYcCWEIb2B4FmbxeLz/pp1HpvJbLFpqAi5I9kJxWsWi+pRyxmIeEPvtJotJBBq+gTPmeKGKCqeS6fg8VzezITpYU0E@lists.infradead.org X-Gm-Message-State: AOJu0YyNOOt0tqzsR3Ehy1IB7L9MI5VY26n3/s+XtWqt9H+bTNrsed3G Jtqoe56o6SxuNTRoF+AaKS+WRDD+tRuYADzOhz0BJRi3ji/5ZDPZUPlchFctH58= X-Google-Smtp-Source: AGHT+IGq9Z87mcKzdsOfA4Kh7hIWO8zyssaqdNEEpmiVif++gK9Zdc/x8LpKsPD+5iPCumWhJubVcQ== X-Received: by 2002:a2e:9996:0:b0:2f2:9a2e:c257 with SMTP id 38308e7fff4ca-2f4f4941e50mr16465901fa.41.1724430405344; Fri, 23 Aug 2024 09:26:45 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a3ea610sm2309974a12.51.2024.08.23.09.26.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Aug 2024 09:26:44 -0700 (PDT) Message-ID: <5eae2ddb-2a7b-4c1d-a7f7-41fb39058de1@tuxon.dev> Date: Fri, 23 Aug 2024 19:26:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/16] dt-bindings: soc: renesas: renesas,rzg2l-sysc: Add #reset-cells for RZ/G3S Content-Language: en-US To: Conor Dooley Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, yoshihiro.shimoda.uh@renesas.com, biju.das.jz@bp.renesas.com, ulf.hansson@linaro.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Claudiu Beznea References: <20240822152801.602318-1-claudiu.beznea.uj@bp.renesas.com> <20240822152801.602318-3-claudiu.beznea.uj@bp.renesas.com> <20240822-vanilla-enigmatic-f0b05ecca4b6@spud> <0d8b1322-cf15-4ed9-b958-06516bbb64c7@tuxon.dev> <20240823-plywood-unfixed-d8d8a2d93f14@spud> From: claudiu beznea In-Reply-To: <20240823-plywood-unfixed-d8d8a2d93f14@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_092647_949707_8F46036A X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23.08.2024 19:18, Conor Dooley wrote: > On Fri, Aug 23, 2024 at 10:54:06AM +0300, claudiu beznea wrote: >> Hi, Conor, >> >> On 22.08.2024 19:42, Conor Dooley wrote: >>> On Thu, Aug 22, 2024 at 06:27:47PM +0300, Claudiu wrote: >>>> From: Claudiu Beznea >>>> >>>> The RZ/G3S System controller has registers to control signals that need >>>> to be de-asserted/asserted before/after different SoC areas are power >>>> on/off. This signals are implemented as reset signals. For this document >>>> the #reset-cells property. >>>> >>>> Signed-off-by: Claudiu Beznea >>>> --- >>>> .../bindings/soc/renesas/renesas,rzg2l-sysc.yaml | 16 ++++++++++++++++ >>>> 1 file changed, 16 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >>>> index 4386b2c3fa4d..6b0bb34485d9 100644 >>>> --- a/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >>>> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >>>> @@ -42,12 +42,28 @@ properties: >>>> - const: cm33stbyr_int >>>> - const: ca55_deny >>>> >>>> + "#reset-cells": >>>> + const: 1 >>>> + >>>> required: >>>> - compatible >>>> - reg >>>> >>>> additionalProperties: false >>>> >>>> +allOf: >>>> + - if: >>>> + properties: >>>> + compatible: >>>> + contains: >>>> + const: renesas,r9a08g045-sysc >>>> + then: >>>> + required: >>>> + - "#reset-cells" >>> >>> Given this is new required property on an existing platform, I'd expect >>> some mention of why it used to be okay to not have this but is now >>> required. Did firmware or a bootloader stage take things out of reset? >> >> On previous SoCs the SYS controller has no support for controlling the >> signals going to different peripherals (USB, PCIE in case of RZ/G3S). >> I'll add a note about this on next version. > > My initial thought here wasn't about previous SoCs though, it was > because you didn't add the compatible in this series for /this/ SoC. RZ/G3S compatible is already present in this file: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml#n26 Thank you, Claudiu Beznea > What's worth noting isn't about the prior SoCs, it is about what makes > it okay for this one.