From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F9BC433E0 for ; Thu, 24 Dec 2020 12:03:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13DAF20789 for ; Thu, 24 Dec 2020 12:03:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13DAF20789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qPT33wgbykiVPRY6IetlSv49d5Lj7LLK0sW//N/7nxI=; b=suPPCevqE7G79auWAPyrVciP8 5Etm8wDvUaSfsWwr7dwWd6IFXsppL1Opxzh9NekJnH+jQIOcGUOnRnSeWUOM0NksnLZlTgr9iTFDj ayXzGt186CsMWH0bpOL+098G7isBggVYj/ICiHOiQE1YEuQKljssw689ZxjfdQrOmomHUwabPdB5o VyxJJefuaROENr99rlResesmqz0SDgl6eH1VNgEFuQhrYSx+zN6RDoSk4CmelvSdyFeIerhzLi8Pw +gRzfp2XrssliCkslDj4Vsgr7F1Dr6F/jLzyu20s93NyTRXfV/qQ0Ghpw0viWSv9i3HSsoDnBlyzJ vgh4pPYiA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ksPJY-0003n5-Qx; Thu, 24 Dec 2020 12:01:52 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ksPJV-0003le-2x; Thu, 24 Dec 2020 12:01:49 +0000 Received: by mail-ed1-x52a.google.com with SMTP id i24so1939720edj.8; Thu, 24 Dec 2020 04:01:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=yzsn8Vxs757yl7BHdUzFyubVzeoZHsr9IiDUX1zD8zc=; b=FpJp+IlhsmMdNnsUqF8aI4pdK4FqwjQh3HB1yyOQIt5Oo0ZFqETQgxAIFM75ALPYTC FvCI6KxRazcUKJc4c7WkI8DPN6DB+hJJdNJCddYF72hMQSFIuqNK9O62j7zRLj80BCLH ozLQeLNCX9wiChonQ+oaCk5T8vEUXITckpEqLJ951854ggOsigYdJXWWbrV6C9pJ1Emn g8WMns50PjTT0KBOneP7R7ulTEJccOt3fC93pewVXTJbouAgu/g/A/fUDnjLFXhbpYJo 2f5QQJa1ZuZLmzOFiMSNNIRfnsj39mZ7NuL1eui6Z2dfv/0vNVm96mrM8eF9z0hzBimw YSkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=yzsn8Vxs757yl7BHdUzFyubVzeoZHsr9IiDUX1zD8zc=; b=O/xPX4oruuw2nAwavucyZA27ujEOJF4GcZoNi1cKJ9ecGZ3D6wldrx9/GFVn8piuL6 1YmwHQGr2ChLSpiueoZPiEvYGCLmejtD5mOqXj85P4J3SuhFrQlOsGgK3AD1+rJOROBP ief6SWTktRPgHKVGCOhtPM1vUeEBWhY+M/z8xGi9pVadj0I3+RL/CtWWrx3v3jFuZd8S xNvLOWkSnQNHg1zUiizrEQgvyamS9XV4hBe8yY6sEVuMvLmZl0IlP1dg1hKGt7YzTYtq cXhRry3sEI+GQIshMwDO0xTkUPir604VoQSuwUUP6BeOf+h8YSug7EqDk3fo/P8A81Hd 5MKQ== X-Gm-Message-State: AOAM531UtkGP+hANR8KWUSgLE/6bxikBil28B7/q1jE9VoR7lIKSc596 2CCksNlw/kFzLLweGbMYVfg= X-Google-Smtp-Source: ABdhPJxLczptfWF++SxwxaJX138UWcvlI/ti2uNMxZ4xxghDoEqg027sexvcopSPGShyw+hEBUxv+w== X-Received: by 2002:aa7:c2d8:: with SMTP id m24mr28190070edp.300.1608811306048; Thu, 24 Dec 2020 04:01:46 -0800 (PST) Received: from ubuntu-laptop (ip5f5bfce9.dynamic.kabel-deutschland.de. [95.91.252.233]) by smtp.googlemail.com with ESMTPSA id i13sm22800403edu.22.2020.12.24.04.01.43 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Dec 2020 04:01:45 -0800 (PST) Message-ID: <5eb12622222bd9ba5e705801a204f3160ba3966b.camel@gmail.com> Subject: Re: [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL From: Bean Huo To: Avri Altman , Stanley Chu , Can Guo Date: Thu, 24 Dec 2020 13:01:43 +0100 In-Reply-To: References: <20201222072928.32328-1-stanley.chu@mediatek.com> <1608697172.14045.5.camel@mtkswgap22> <1608796334.14045.21.camel@mtkswgap22> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201224_070149_166455_EEA4E2A9 X-CRM114-Status: GOOD ( 17.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "andy.teng@mediatek.com" , "jejb@linux.ibm.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "linux-kernel@vger.kernel.org" , "cc.chou@mediatek.com" , "jiajie.hao@mediatek.com" , "alice.chao@mediatek.com" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "alim.akhtar@samsung.com" , "matthias.bgg@gmail.com" , "beanhuo@micron.com" , "chaotian.jing@mediatek.com" , "bvanassche@acm.org" , "linux-arm-kernel@lists.infradead.org" , "asutoshd@codeaurora.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-12-24 at 11:03 +0000, Avri Altman wrote: > > > Do you see any substantial benefit of having > > > fWriteBoosterBufferFlushEn > > > disabled? > > > > 1. The definition of fWriteBoosterBufferFlushEn is that host allows > > device to do flush in anytime after fWriteBoosterBufferFlushEn is > > set as > > on. This is not what we want. > > > > Just Like BKOP, We do not want flush happening beyond host's > > expected > > timing that device performance may be "randomly" dropped. > > Explicit flush takes place only when the device is idle: > if fWriteBoosterBufferFlushEn is set, the device is idle, and before > h8 received. > If a request arrives, the flush operation should be halted. > So no performance degradation is expected. Hi Stanley Avri's comment is correct, fWriteBoosterBufferFlushEn==1, device will flush only when it is in idle, once there is new incoming request, the flush will be suspended. You should be very careful when you want to skip this stetting of this flag. Bean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel