* [PATCH 0/5] media: add FSD MIPI-CSI2 Rx controller driver
[not found] <CGME20221120184648epcas5p3e08766377944a2c5850f9600bf75cf8f@epcas5p3.samsung.com>
@ 2022-11-20 18:52 ` Sathyakam M
[not found] ` <CGME20221121045301epcas5p1d6195b5dc6cafebfb429044b41d0d123@epcas5p1.samsung.com>
2022-11-21 9:31 ` [PATCH 0/5] media: add FSD MIPI-CSI2 " Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Sathyakam M @ 2022-11-20 18:52 UTC (permalink / raw)
To: sathya
Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Pankaj Kumar Dubey,
Alim Akhtar, Aswani Reddy, Andi Shyti, Hans Verkuil, Ming Qian,
Jacopo Mondi, Will Deacon, Shawn Guo, Marcel Ziswiler,
linux-arm-kernel, linux-kernel
This patch series adds the V4L2 media driver for
Tesla Full Self Driving (FSD) SoC MIPI-CSI2 Rx controller.
The controller is compliant to MIPI CSI2 v1.3 specification.
It receives images from camera sensors over the D-PHY interface.
The D-PHY interface is compliant to MIPI D-PHY v1.2 specification. It
supports up to maximum of 4 data lanes.
V4L2 user control is provided to set the desired number of data lanes.
Maximum of up to 4 streams can be received simultaneously by one Rx
port. (Each streams identified by designated Virtual Channel
Identifier).
The controller instances consist of port property describing the endpoints.
When combined with remote-endpoint property the driver instantiates
video device nodes using V4L2 async subdev methods.
Streaming formats supported:
- YUV420
- RGB565, RGB666, RGB888
- RAW8, RAW10, RAW12
- JPEG
The driver implementation is verified on FSD evaluation board.
Thanks, Sathyakam
Cc: Sathyakam M <sathya@samsung.com>,Vinod Koul <vkoul@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>,Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Pankaj Kumar Dubey <pankaj.dubey@samsung.com>,Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,Shashank Prashar <s.prashar@samsung.com>
Cc: Aswani Reddy <aswani.reddy@samsung.com>,Chandrasekar R <rcsekar@samsung.com>
Cc: Andi Shyti <andi@etezian.org>,Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Ming Qian <ming.qian@nxp.com>,Dmitry Osipenko <digetx@gmail.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>,Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>,Bjorn Andersson <andersson@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>,Arnd Bergmann <arnd@arndb.de>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,linux-phy@lists.infradead.org,devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,linux-media@vger.kernel.org
Sathyakam M (5):
dt-bindings: phy: fsd: MIPI CSI2 Rx controller syscon node
media: dt-bindings: fsd: MIPI CSI2 Rx controller device nodes
arm64: dts: fsd: add device tree nodes for MIPI CSI2 Rx controller
media: fsd: add MIPI CSI2 Rx controller driver
arm64: defconfig: enable FSD MIPI CSI2 Rx controller driver
.../bindings/media/tesla-fsd-csis.yaml | 148 +
.../bindings/phy/fsd-csis-syscon.yaml | 48 +
.../media/drivers/fsd-csis-uapi.rst | 78 +
MAINTAINERS | 12 +
arch/arm64/boot/dts/tesla/fsd-evb.dts | 232 ++
arch/arm64/boot/dts/tesla/fsd.dtsi | 162 +
arch/arm64/configs/defconfig | 1 +
drivers/media/platform/Kconfig | 1 +
drivers/media/platform/Makefile | 1 +
drivers/media/platform/fsd/Kconfig | 73 +
drivers/media/platform/fsd/Makefile | 1 +
drivers/media/platform/fsd/fsd-csis.c | 2664 +++++++++++++++++
drivers/media/platform/fsd/fsd-csis.h | 785 +++++
include/uapi/linux/fsd-csis.h | 19 +
include/uapi/linux/v4l2-controls.h | 5 +
15 files changed, 4230 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/tesla-fsd-csis.yaml
create mode 100644 Documentation/devicetree/bindings/phy/fsd-csis-syscon.yaml
create mode 100644 Documentation/userspace-api/media/drivers/fsd-csis-uapi.rst
create mode 100644 drivers/media/platform/fsd/Kconfig
create mode 100644 drivers/media/platform/fsd/Makefile
create mode 100644 drivers/media/platform/fsd/fsd-csis.c
create mode 100644 drivers/media/platform/fsd/fsd-csis.h
create mode 100644 include/uapi/linux/fsd-csis.h
base-commit: 77c51ba552a1c4f73228766e43ae37c4101b3758
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 5/5] arm64: defconfig: enable FSD MIPI CSI2 Rx controller driver
[not found] ` <CGME20221121045301epcas5p1d6195b5dc6cafebfb429044b41d0d123@epcas5p1.samsung.com>
@ 2022-11-21 4:58 ` Sathyakam M
2022-11-21 9:26 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Sathyakam M @ 2022-11-21 4:58 UTC (permalink / raw)
To: catalin.marinas, will, andersson, shawnguo, arnd,
krzysztof.kozlowski, marcel.ziswiler, vkoul, dmitry.baryshkov,
broonie, pankaj.dubey, linux-arm-kernel, linux-kernel
Cc: Sathyakam M
Add build rule for FSD MIPI CSI2 Rx controller driver support
This enables CSI2 compatible Camera streaming
with D-PHY as 1600Mbps default data rate.
D-PHY interface can be configured for data rate of 800, 1000,1500,
1600, 2100 Mbps. The corresponding PHY parameters are set accordingly.
Signed-off-by: Sathyakam M <sathya@samsung.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Pankaj Kumar Dubey <pankaj.dubey@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 0b6af3348e79..9d152a26dc0b 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -698,6 +698,7 @@ CONFIG_USB_VIDEO_CLASS=m
CONFIG_V4L_PLATFORM_DRIVERS=y
CONFIG_SDR_PLATFORM_DRIVERS=y
CONFIG_V4L_MEM2MEM_DRIVERS=y
+CONFIG_VIDEO_FSD_MIPI_CSIS=m
CONFIG_VIDEO_QCOM_CAMSS=m
CONFIG_VIDEO_QCOM_VENUS=m
CONFIG_VIDEO_RCAR_ISP=m
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 5/5] arm64: defconfig: enable FSD MIPI CSI2 Rx controller driver
2022-11-21 4:58 ` [PATCH 5/5] arm64: defconfig: enable FSD MIPI CSI2 " Sathyakam M
@ 2022-11-21 9:26 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-21 9:26 UTC (permalink / raw)
To: Sathyakam M, catalin.marinas, will, andersson, shawnguo, arnd,
marcel.ziswiler, vkoul, dmitry.baryshkov, broonie, pankaj.dubey,
linux-arm-kernel, linux-kernel
On 21/11/2022 05:58, Sathyakam M wrote:
> Add build rule for FSD MIPI CSI2 Rx controller driver support
>
> This enables CSI2 compatible Camera streaming
> with D-PHY as 1600Mbps default data rate.
>
> D-PHY interface can be configured for data rate of 800, 1000,1500,
> 1600, 2100 Mbps. The corresponding PHY parameters are set accordin
You need to answer in commit msg to: why? E.g. by describe where it is used.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/5] media: add FSD MIPI-CSI2 Rx controller driver
2022-11-20 18:52 ` [PATCH 0/5] media: add FSD MIPI-CSI2 Rx controller driver Sathyakam M
[not found] ` <CGME20221121045301epcas5p1d6195b5dc6cafebfb429044b41d0d123@epcas5p1.samsung.com>
@ 2022-11-21 9:31 ` Krzysztof Kozlowski
2022-11-23 8:45 ` Sathyakam M
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-21 9:31 UTC (permalink / raw)
To: Sathyakam M
Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Pankaj Kumar Dubey,
Alim Akhtar, Aswani Reddy, Andi Shyti, Hans Verkuil, Ming Qian,
Jacopo Mondi, Will Deacon, Shawn Guo, Marcel Ziswiler,
linux-arm-kernel, linux-kernel
On 20/11/2022 19:52, Sathyakam M wrote:
> This patch series adds the V4L2 media driver for
> Tesla Full Self Driving (FSD) SoC MIPI-CSI2 Rx controller.
>
> The controller is compliant to MIPI CSI2 v1.3 specification.
> It receives images from camera sensors over the D-PHY interface.
>
> The D-PHY interface is compliant to MIPI D-PHY v1.2 specification. It
> supports up to maximum of 4 data lanes.
>
> V4L2 user control is provided to set the desired number of data lanes.
>
> Maximum of up to 4 streams can be received simultaneously by one Rx
> port. (Each streams identified by designated Virtual Channel
> Identifier).
>
> The controller instances consist of port property describing the endpoints.
> When combined with remote-endpoint property the driver instantiates
> video device nodes using V4L2 async subdev methods.
>
> Streaming formats supported:
> - YUV420
> - RGB565, RGB666, RGB888
> - RAW8, RAW10, RAW12
> - JPEG
>
> The driver implementation is verified on FSD evaluation board.
>
> Thanks, Sathyakam
>
> Cc: Sathyakam M <sathya@samsung.com>,Vinod Koul <vkoul@kernel.org>
> Cc: Kishon Vijay Abraham I <kishon@kernel.org>,Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Pankaj Kumar Dubey <pankaj.dubey@samsung.com>,Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>,Shashank Prashar <s.prashar@samsung.com>
> Cc: Aswani Reddy <aswani.reddy@samsung.com>,Chandrasekar R <rcsekar@samsung.com>
> Cc: Andi Shyti <andi@etezian.org>,Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Ming Qian <ming.qian@nxp.com>,Dmitry Osipenko <digetx@gmail.com>
> Cc: Jacopo Mondi <jacopo@jmondi.org>,Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>,Bjorn Andersson <andersson@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>,Arnd Bergmann <arnd@arndb.de>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,Mark Brown <broonie@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org,linux-phy@lists.infradead.org,devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org,linux-media@vger.kernel.org
>
> Sathyakam M (5):
> dt-bindings: phy: fsd: MIPI CSI2 Rx controller syscon node
> media: dt-bindings: fsd: MIPI CSI2 Rx controller device nodes
> arm64: dts: fsd: add device tree nodes for MIPI CSI2 Rx controller
> media: fsd: add MIPI CSI2 Rx controller driver
I did not get your patch #4. Don't Cc selectively.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 0/5] media: add FSD MIPI-CSI2 Rx controller driver
2022-11-21 9:31 ` [PATCH 0/5] media: add FSD MIPI-CSI2 " Krzysztof Kozlowski
@ 2022-11-23 8:45 ` Sathyakam M
0 siblings, 0 replies; 5+ messages in thread
From: Sathyakam M @ 2022-11-23 8:45 UTC (permalink / raw)
To: 'Krzysztof Kozlowski'
Cc: 'Kishon Vijay Abraham I', 'Krzysztof Kozlowski',
'Pankaj Kumar Dubey', 'Alim Akhtar',
'Aswani Reddy', 'Andi Shyti',
'Hans Verkuil', 'Ming Qian',
'Jacopo Mondi', 'Will Deacon',
'Shawn Guo', 'Marcel Ziswiler', linux-arm-kernel,
linux-kernel
Hi Krzysztof,
Thank you for taking your time to review the patches.
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 21 November 2022 15:01
> To: Sathyakam M <sathya@samsung.com>
> Cc: Kishon Vijay Abraham I <kishon@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Pankaj Kumar Dubey
> <pankaj.dubey@samsung.com>; Alim Akhtar <alim.akhtar@samsung.com>;
> Aswani Reddy <aswani.reddy@samsung.com>; Andi Shyti
> <andi@etezian.org>; Hans Verkuil <hverkuil-cisco@xs4all.nl>; Ming Qian
> <ming.qian@nxp.com>; Jacopo Mondi <jacopo@jmondi.org>; Will Deacon
> <will@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Marcel Ziswiler
> <marcel.ziswiler@toradex.com>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 0/5] media: add FSD MIPI-CSI2 Rx controller driver
>
> On 20/11/2022 19:52, Sathyakam M wrote:
> > This patch series adds the V4L2 media driver for Tesla Full Self
> > Driving (FSD) SoC MIPI-CSI2 Rx controller.
> >
> > The controller is compliant to MIPI CSI2 v1.3 specification.
> > It receives images from camera sensors over the D-PHY interface.
> >
> > The D-PHY interface is compliant to MIPI D-PHY v1.2 specification. It
> > supports up to maximum of 4 data lanes.
> >
> > V4L2 user control is provided to set the desired number of data lanes.
> >
> > Maximum of up to 4 streams can be received simultaneously by one Rx
> > port. (Each streams identified by designated Virtual Channel
> > Identifier).
> >
> > The controller instances consist of port property describing the endpoints.
> > When combined with remote-endpoint property the driver instantiates
> > video device nodes using V4L2 async subdev methods.
> >
> > Streaming formats supported:
> > - YUV420
> > - RGB565, RGB666, RGB888
> > - RAW8, RAW10, RAW12
> > - JPEG
> >
> > The driver implementation is verified on FSD evaluation board.
> >
> > Thanks, Sathyakam
> >
> > Cc: Sathyakam M <sathya@samsung.com>,Vinod Koul <vkoul@kernel.org>
> > Cc: Kishon Vijay Abraham I <kishon@kernel.org>,Rob Herring
> > <robh+dt@kernel.org>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> > Cc: Pankaj Kumar Dubey <pankaj.dubey@samsung.com>,Mauro Carvalho
> > Chehab <mchehab@kernel.org>
> > Cc: Alim Akhtar <alim.akhtar@samsung.com>,Shashank Prashar
> > <s.prashar@samsung.com>
> > Cc: Aswani Reddy <aswani.reddy@samsung.com>,Chandrasekar R
> > <rcsekar@samsung.com>
> > Cc: Andi Shyti <andi@etezian.org>,Laurent Pinchart
> > <laurent.pinchart@ideasonboard.com>
> > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,Jernej Skrabec
> > <jernej.skrabec@gmail.com>
> > Cc: Ming Qian <ming.qian@nxp.com>,Dmitry Osipenko
> <digetx@gmail.com>
> > Cc: Jacopo Mondi <jacopo@jmondi.org>,Catalin Marinas
> > <catalin.marinas@arm.com>
> > Cc: Will Deacon <will@kernel.org>,Bjorn Andersson
> > <andersson@kernel.org>
> > Cc: Shawn Guo <shawnguo@kernel.org>,Arnd Bergmann
> <arnd@arndb.de>
> > Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,Mark Brown
> > <broonie@kernel.org>
> > Cc:
> > linux-arm-kernel@lists.infradead.org,linux-phy@lists.infradead.org,dev
> > icetree@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org,linux-media@vger.kernel.org
> >
> > Sathyakam M (5):
> > dt-bindings: phy: fsd: MIPI CSI2 Rx controller syscon node
> > media: dt-bindings: fsd: MIPI CSI2 Rx controller device nodes
> > arm64: dts: fsd: add device tree nodes for MIPI CSI2 Rx controller
> > media: fsd: add MIPI CSI2 Rx controller driver
>
> I did not get your patch #4. Don't Cc selectively.
Sorry for that. There was problem with sending the bundled patch set. I see that you got "[PATCH 4/5] media: fsd: add MIPI CSI2 Rx controller driver".
I will address the comments for the same.
>
> Best regards,
> Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-23 8:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20221120184648epcas5p3e08766377944a2c5850f9600bf75cf8f@epcas5p3.samsung.com>
2022-11-20 18:52 ` [PATCH 0/5] media: add FSD MIPI-CSI2 Rx controller driver Sathyakam M
[not found] ` <CGME20221121045301epcas5p1d6195b5dc6cafebfb429044b41d0d123@epcas5p1.samsung.com>
2022-11-21 4:58 ` [PATCH 5/5] arm64: defconfig: enable FSD MIPI CSI2 " Sathyakam M
2022-11-21 9:26 ` Krzysztof Kozlowski
2022-11-21 9:31 ` [PATCH 0/5] media: add FSD MIPI-CSI2 " Krzysztof Kozlowski
2022-11-23 8:45 ` Sathyakam M
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).