From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB2E9C4167B for ; Mon, 27 Nov 2023 17:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V28AFayawLHRp7Lpi0hOGjUWwyvY3PdNE0aU+mebElo=; b=GtHyi+wdGUNFHo pLQ4ii0gAht6OOUJNQ1n4JOt9w8LuoS5ccD8AN5i7d/WE+vzPoq5xGRnLT6BFEJH6pjdWPLZcWRTV z0pYXrLxYllh+Mh99pcqQ+tP2HJnaOzZh+WKwxstpwY08eeACYYQ4Cy8+pRD0GPzoTY/zsXwiUxc9 uidCQrmWfVTyXQMRYbxRg9HtOmrskiZp9XfGrELR90Cb2TN3/onHD1S/+zW4nCiDnxRiWmYcfPc/T wlR9pMwVApock+uGyZ46h0f9J0uP20V9Y11+W4UE7gFvhMmwTkW7UwM7pMX0CXM6ad5+RVZyWwyTf 5POJPA/zsjmV6EAwsgWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7flf-003AGy-31; Mon, 27 Nov 2023 17:51:36 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7fla-003AFC-0j for linux-arm-kernel@lists.infradead.org; Mon, 27 Nov 2023 17:51:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701107488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aer8fJjQ+wrrXZRz8cD/oMQGc4UteK4s0NzIKeWzWIQ=; b=GFt8tGj/Sdc1UuVAfllnJyVo5koniqzcaPgResrC9UvemzPe9aVC7XPgVN1oGWyRm6IqR9 AsdS9+jcDkwMqApcfRGSb3lzF8CdJhdwhITubv20CvNdmaIwYf+EQ6dNmAksC2S7L4CZb+ qDXYADPKSXHKe7eLyDAC5vvwRqWaA7s= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-L1TtYJ5BOceIrnvPOyvNjg-1; Mon, 27 Nov 2023 12:51:27 -0500 X-MC-Unique: L1TtYJ5BOceIrnvPOyvNjg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-332e899b927so2699603f8f.2 for ; Mon, 27 Nov 2023 09:51:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701107486; x=1701712286; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aer8fJjQ+wrrXZRz8cD/oMQGc4UteK4s0NzIKeWzWIQ=; b=aeplRA0PQb7fNWtpVPDi3whJWYt8yDDrWXS1Z9wn8VH9f7EXifMBVqEBy45xQKd420 BpdInzOFh/4JbQcwgdcdfnuH2NO2Jc68xeVA9hL8IE/PV2RfhjejafI7wZCL8MOCz21Z NcehWih5003QIb0EZCM8uvOLr3arNbL2hl/ZZrGMH+T4bF8fAASpVSX0wi9xtWMCGKQx UyG/Qg9j5hZMbV9BIa4p52Pz9SWLQ266hRRPv1MmFl/Cl3+IgvRqdDXS2WySZBNMaT7c v+ZSImK4DWpW5SUeIoTBhLWj1gZz5ZWgOTsIktIYPWfWdJXPfHsHk9/QSkF4lnP2fw7S 4YTQ== X-Gm-Message-State: AOJu0YxUr4ZROPmiD7pdQsp0uHVIJn2eTdwYQxHnTjYNEswdG5usJOy2 NqEEpI0WJ0iLPg6gYo3K/NRZ0wXaj5/GrK1f+14OWcZ5azo2VLPnbg0sC5Na4p4LHVE1qTvC9+l 6lvJF0KxmbxTRJbiIe7M6gHKJ5pei/OFgcWs= X-Received: by 2002:a5d:4108:0:b0:332:f3c9:1c95 with SMTP id l8-20020a5d4108000000b00332f3c91c95mr5128624wrp.21.1701107485998; Mon, 27 Nov 2023 09:51:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IEC7wCqmPwk5yODdC1mrKef2nYj1QWSCSCYwfha4Hq5cZB2h6iX52pz9LJctejYVMhpn+L9Kw== X-Received: by 2002:a5d:4108:0:b0:332:f3c9:1c95 with SMTP id l8-20020a5d4108000000b00332f3c91c95mr5128610wrp.21.1701107485706; Mon, 27 Nov 2023 09:51:25 -0800 (PST) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id z14-20020a05600c0a0e00b0040b47b5be25sm3149454wmp.48.2023.11.27.09.51.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Nov 2023 09:51:25 -0800 (PST) Message-ID: <5ebcbd88-bd2a-4853-a0c7-1c2f0f7dc592@redhat.com> Date: Mon, 27 Nov 2023 18:51:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/19] iommu/arm-smmu-v3: Add a type for the STE To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Michael Shavit , Nicolin Chen , Shameerali Kolothum Thodi References: <1-v2-de8b10590bf5+400-smmuv3_newapi_p1_jgg@nvidia.com> <0a2a9fb5-0506-4a46-9c93-3c4001d0b966@redhat.com> <20231127174235.GA1165737@nvidia.com> From: Eric Auger In-Reply-To: <20231127174235.GA1165737@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_095130_353670_3527A2B3 X-CRM114-Status: GOOD ( 12.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jason, On 11/27/23 18:42, Jason Gunthorpe wrote: > On Mon, Nov 27, 2023 at 05:03:36PM +0100, Eric Auger wrote: > >>> -static __le64 *arm_smmu_get_step_for_sid(struct arm_smmu_device *smmu, u32 sid) >>> +static struct arm_smmu_ste * >>> +arm_smmu_get_step_for_sid(struct arm_smmu_device *smmu, u32 sid) >>> { >>> - __le64 *step; >>> struct arm_smmu_strtab_cfg *cfg = &smmu->strtab_cfg; >>> >>> if (smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB) { >>> - struct arm_smmu_strtab_l1_desc *l1_desc; >>> int idx; >>> >>> /* Two-level walk */ >>> idx = (sid >> STRTAB_SPLIT) * STRTAB_L1_DESC_DWORDS; >>> - l1_desc = &cfg->l1_desc[idx]; >>> - idx = (sid & ((1 << STRTAB_SPLIT) - 1)) * STRTAB_STE_DWORDS; >>> - step = &l1_desc->l2ptr[idx]; >>> + return &cfg->l1_desc[idx].l2ptr[sid & ((1 << STRTAB_SPLIT) - 1)]; >> This looks less readable to me than it was before. > > You would like the idx calculation outside? > > idx1 = (sid >> STRTAB_SPLIT) * STRTAB_L1_DESC_DWORDS; > idx2 = sid & ((1 << STRTAB_SPLIT) - 1); > return &cfg->l1_desc[idx].l2ptr[idx2]; Yes this looks more readable to me Eric > > ? > > Thanks, > Jason > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel