From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 591D7C61DA4 for ; Fri, 3 Feb 2023 08:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:CC:References:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=MbAQKsUl311Ju68ZO23BPW2WYqLJkM+5rpQjid6/x6c=; b=XVwgT1+xHKcgQxb0hcK2fhz/kk zOHNK5UeLRFJpMlnHCF/vd+T4wcRiGOczd0AztrSxZTCSw+0t0lkhLzqA5qCrTxtvGt3FFThYskbL ipvEzlJ3gC40ePfDOvHrC1IiKS81JTeL+6y0h5RAN39OJmLpX0OApptJR4KvtNOaiKtUITjERoF0n 215S54y50ZB0Df1NGLNqPDExaI2b4u2M1hMZrOeGOfvVNd1z6zOnixmZCrt3V2kUPduxqeYpV5+Iu Y6LblZxTbr3cnqpsPAErGsaO4QDC0AbB2fNTPPKKqglJcCZhWuvanJNHa7+0BhZzx4I6cN5pNKgFP A+QrDYSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNrsT-0014xB-Or; Fri, 03 Feb 2023 08:57:01 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNrsO-0014uR-OB for linux-arm-kernel@lists.infradead.org; Fri, 03 Feb 2023 08:56:58 +0000 Received: from dggpemm100009.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4P7TzN5blxzfZ4D; Fri, 3 Feb 2023 16:56:32 +0800 (CST) Received: from [10.174.179.24] (10.174.179.24) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 3 Feb 2023 16:56:44 +0800 Subject: Re: [PATCH RFC] arm64/vmalloc: use module region only for module_alloc() if CONFIG_RANDOMIZE_BASE is set To: Ard Biesheuvel , Will Deacon References: <20221227092634.445212-1-liushixin2@huawei.com> <20230129134147.f19ca0641f1133f3e3bc185b@linux-foundation.org> <20230131150644.GA2605@willie-the-truck> <20230131150750.GB2605@willie-the-truck> CC: Andrew Morton , Catalin Marinas , Uladzislau Rezki , Christoph Hellwig , , , From: Liu Shixin Message-ID: <5ecc890a-453a-ba2d-9c5e-073127067799@huawei.com> Date: Fri, 3 Feb 2023 16:56:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_005657_169722_1C47F3D5 X-CRM114-Status: GOOD ( 20.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023/2/1 0:03, Ard Biesheuvel wrote: > On Tue, 31 Jan 2023 at 16:07, Will Deacon wrote: >> Now really adding Ard... >> >> On Tue, Jan 31, 2023 at 03:06:44PM +0000, Will Deacon wrote: >>> +Ard -- full thread here: >>> >>> https://lore.kernel.org/all/20221227092634.445212-1-liushixin2@huawei.com/ >>> >>> On Sun, Jan 29, 2023 at 01:41:47PM -0800, Andrew Morton wrote: >>>> On Sun, 29 Jan 2023 10:44:31 +0800 Liu Shixin wrote: >>>> >>>>> Hi, >>>>> >>>>> >>>>> This patch seems to have been lost in the corner. Recently I've meet this problem again >>>>> >>>>> on v6.1, so I would like to propose this patch again. >>>>> >>>>> >>>>> Thanks, >>>>> >>>>> >>>>> On 2022/12/27 17:26, Liu Shixin wrote: >>>>>> After I add a 10GB pmem device, I got the following error message when >>>>>> insert module: >>>>>> >>>>>> insmod: vmalloc error: size 16384, vm_struct allocation failed, >>>>>> mode:0xcc0(GFP_KERNEL), nodemask=(null),cpuset=/,mems_allowed=0 >>>>>> >>>>>> If CONFIG_RANDOMIZE_BASE is set, the module region can be located in the >>>>>> vmalloc region entirely. Although module_alloc() can fall back to a 2GB >>>>>> window if ARM64_MODULE_PLTS is set, the module region is still easily >>>>>> exhausted because the module region is located at bottom of vmalloc region >>>>>> and the vmalloc region is allocated from bottom to top. >>>>>> >>>>>> Skip module region if not calling from module_alloc(). >>>>>> >>>> I'll assume this is for the arm tree. >>>> >>>> Acked-by: Andrew Morton >>> This looks like the same issue previously reported at: >>> >>> https://lore.kernel.org/all/e6a804de-a5f7-c551-ffba-e09d04e438fc@hisilicon.com/ >>> >>> where Ard had a few suggestions but, afaict, they didn't help. >>> > Thanks for the cc. > > So this is a bit clunky, and I wonder whether we wouldn't be better > off just splitting the vmalloc region into two separate regions: one > for the kernel and modules, and one for everything else. That way, we > lose one bit of entropy in the randomized placement, but the default > 48-bit VA space is vast anway, and even on 39-bit VA configs (such as > Android), I seriously doubt that we come anywhere close to exhausting > the vmalloc space today. > . Thanks for your advice. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel