From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 955B7C4345F for ; Fri, 26 Apr 2024 00:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=38j2kLGUShfcAwLRWx9WeVIlSzgAO/qoyK7y/z1EIfY=; b=RrPz/i4kiyWt+/ ZNI+v4okYT+LSZNxn+jxevPfYQvEcBScYU+mpDtxBcK3KFt5pZbELNriZBQUlx657PFO+DR4ddvEY 3BbaA+LVdTHDZRrzQRId4wHwl2EcwL5aj6vkyx5IWA7tDOFI8+/5Vs57gS1EPlyCEApUTBlQ6j7IP cdX8dYBVVfxXkKYuGxF8sq7hGYTa0edhQmdrtjOLSBmXMTBe8h2HSIEI7iF/pId273DyoFtVf9BpT 99N3T6RNkdJ7FIavmDv6PzpQrj9cvGSvw+2g1omQoWtDOKmNE1BBA81vGFEvQGuBIQCGqYcn4kla0 O6YUfGIsJa2PDG6SPAyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s09fK-0000000AjMW-3BeU; Fri, 26 Apr 2024 00:42:14 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s09fI-0000000AjJL-2p1B for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2024 00:42:14 +0000 Received: from [192.168.68.112] (ppp14-2-127-66.adl-apt-pir-bras32.tpg.internode.on.net [14.2.127.66]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 9AF5520075; Fri, 26 Apr 2024 08:41:58 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1714092123; bh=yLN/Qb+eB/6AyNAKbEB/yMlsv9Gl2BYp81SCa6piTeg=; h=Subject:From:To:Date:In-Reply-To:References; b=MRPTWh6iLUPzVdEoN6OoxnclwEajv4PUZysrLyAeI30AMIhWlPLTwwk4v6ltGNUFN tHGXIKanZihdwzVoroKvOwGJNrc3ARd8koi0aUc9RQLUlBlDMnerfnrYWkLkHei1wV efSkxL9aqLaDWbMFYId3Xskp63kVqccJnm+VHVxOszpG/EVeMlaOyJc4wCrDWqyYan Bv/6v0Z/fBlR3wvFujD4bAScafK87c8QGR5ajjxDsGTjdoVCHNfFhjTALI5tOvAMHS vNK20+8DoBp4QsLP1jAAMsdxeuSwViKa7qRHWsZDVccbZzNEjKPtA+ccqkchMyBnhy B+fOhM5t4K0sg== Message-ID: <5ed8bfd6ce559a7d00ec89f1bd7ae1aea90e3ae7.camel@codeconstruct.com.au> Subject: Re: [PATCH v7 1/1] drivers: watchdog: revise watchdog bootstatus From: Andrew Jeffery To: Peter Yin , patrick@stwcx.xyz, Wim Van Sebroeck , Guenter Roeck , Joel Stanley , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Fri, 26 Apr 2024 10:11:57 +0930 In-Reply-To: <20240425090727.3787160-2-peteryin.openbmc@gmail.com> References: <20240425090727.3787160-1-peteryin.openbmc@gmail.com> <20240425090727.3787160-2-peteryin.openbmc@gmail.com> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_174212_957835_DF18B9A7 X-CRM114-Status: GOOD ( 11.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2024-04-25 at 17:07 +0800, Peter Yin wrote: > Regarding the AST2600 specification, the WDTn Timeout Status Register > (WDT10) has bit 1 reserved. Bit 1 of the status register indicates > on ast2500 if the boot was from the second boot source. > It does not indicate that the most recent reset was triggered by > the watchdog. The code should just be changed to set WDIOF_CARDRESET > if bit 0 of the status register is set. However, this bit can be clear when > watchdog register 0x0c bit1(Reset System after timeout) is enabled. > Thereforce include SCU register to veriy WDIOF_EXTERN1 and WDIOF_CARDRESET > in ast2600 SCU74 or ast2400/ast2500 SCU3C. > > Signed-off-by: Peter Yin > --- > drivers/watchdog/aspeed_wdt.c | 109 ++++++++++++++++++++++++++++++++-- > 1 file changed, 103 insertions(+), 6 deletions(-) After this patch the probe() implementation is ~250loc with a whole bunch of conditional behaviours based on the SoC version. Maybe it's time to break it up into version-specific functions that are called from the probe() implementation? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel