From: Krzysztof Kozlowski <krzk@kernel.org>
To: long.yunjian@zte.com.cn, sudeep.holla@arm.com
Cc: cristian.marussi@arm.com, peng.fan@nxp.com,
florian.fainelli@broadcom.com, fang.yumeng@zte.com.cn,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dan.carpenter@linaro.org,
christophe.jaillet@wanadoo.fr, mou.yi@zte.com.cn,
ouyang.maochun@zte.com.cn, xu.lifeng1@zte.com.cn
Subject: Re: [PATCH v2] firmware: arm_scmi: Use dev_err_probe() simplify the code
Date: Thu, 22 May 2025 10:41:37 +0200 [thread overview]
Message-ID: <5edf74a6-7d01-4e1f-8d85-1be879d48700@kernel.org> (raw)
In-Reply-To: <20250521161449954uFxEsoI6Zg_7wDu6IAfWk@zte.com.cn>
On 21/05/2025 10:14, long.yunjian@zte.com.cn wrote:
> From: Yumeng Fang <fang.yumeng@zte.com.cn>
>
> In the probe path, dev_err() can be replaced with dev_err_probe()
That's mailbox channel setup, not probe path.
Either this patch is wrong or commit msg is just not relevant.
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
You explain the basic stuff, we all know it, but you miss to explain
things which we do not know. Rewrite your commit msgs to explain the
non-obvious.
We all know how dev_err_probe works. What we do not know is ALWAYS that
chan setup is the probe path (so prove that it is ALWAYS probe path).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-22 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 8:14 [PATCH v2] firmware: arm_scmi: Use dev_err_probe() simplify the code long.yunjian
2025-05-22 8:41 ` Krzysztof Kozlowski [this message]
2025-05-23 16:30 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5edf74a6-7d01-4e1f-8d85-1be879d48700@kernel.org \
--to=krzk@kernel.org \
--cc=arm-scmi@vger.kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cristian.marussi@arm.com \
--cc=dan.carpenter@linaro.org \
--cc=fang.yumeng@zte.com.cn \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=long.yunjian@zte.com.cn \
--cc=mou.yi@zte.com.cn \
--cc=ouyang.maochun@zte.com.cn \
--cc=peng.fan@nxp.com \
--cc=sudeep.holla@arm.com \
--cc=xu.lifeng1@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox