Re: [PATCH v7 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp for MT8188

["Friday Yang (杨阳)" <Friday.Yang@mediatek.com>]

On Sun, 2025-05-04 at 15:40 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 30/04/2025 11:45, Friday Yang wrote:
> > From: "Friday Yang" <friday.yang@mediatek.com>
> > 
> > To prevent handling glitch signals during MTCMOS on/off
> > transitions,
> > SMI requires clamp and reset operations. Parse the reset settings
> > for
> > SMI LARBs and the clamp settings for the SMI Sub-Common. Register
> > genpd callback for the SMI LARBs located in image, camera and IPE
> > subsystems, and apply reset and clamp operations within the
> > callback.
> > 
> > Signed-off-by: Friday Yang <friday.yang@mediatek.com>
> > Tested-by: Friday Yang <friday.yang@mediatek.com>
> 
> How is this possible? Are you claiming that none of other authors
> test
> their patches? How testing would be not implied by authorship?
> 

OK, I will remove this tag in the new version.

> > Reviewed-by: Yong Wu <yong.wu@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> 
> Changelog says that v7 has only following changes:
> 
>   - Remove the 'devm_pm_runtime_enable' change.
> 
> While v6 had no such tags.
> 
> No clue what happened here, but looks like mess with the tags and
> really
> incomplete changelog.
> 

Apology for the miss, I will add more detailed descriptions and remove
the incorrect tags in the new version.

> Best regards,
> Krzysztof