From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41BCFC76195 for ; Tue, 28 Mar 2023 11:19:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Ye5Qq//PlJTpHNxquydovleWEGmU1my3g+hH5k96oI=; b=Dece8h5QAaCp1i xjSI8p8DQ5w/UCNM6LAdnglHIJ7bU85nw2OoLeFU5UaAoyl3gkciKbign4VuWB7NEnRtRJLclabOv pr59WsJIPdjmzeyjKE597ahJoPobyJSzC/SzPO56DzL5cMdvn2+Zc2BKTAlQ6QkpgYsGs3QcugE2g PWA0iGGQ3K8+JkTQ4gyYtdDJ4o4qSj+f4OafhW5eX1HQ6XqUvInxn0Cu17ViW+f6HfOhF1r1SvBMC U7xPygB8PhRHifFtpl6Z0p7VNzVL/A/+pTWqoozqqETeSpsu72+NlgacXtQ/zlplVz57dNUe8bpby rqABxW0lWidcY2TdjCUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ph7LT-00E6gF-2K; Tue, 28 Mar 2023 11:18:31 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ph7LQ-00E6fW-38 for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 11:18:30 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32SBIOQJ108738; Tue, 28 Mar 2023 06:18:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680002304; bh=MvPxFEFK7DB7/DNR0iURafVCw8yeSMx8U1lAbgRmuIk=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=hBy/3+JfxMMyMa7ivfv7bfqBwMmnqLhntbcRHvJETvfJWoD/VWanunb8mL7CKtIl2 Ool2koj8XtbbOAeiTOVK8s9PIAwrVyMkVBsLWUhEw0rYHRCCv1zv86dW774oNmyIUU tM4geHPdIwlYmaHc0mCNs188NE3srSUuA8auYJs0= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32SBIObN049510 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 28 Mar 2023 06:18:24 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 28 Mar 2023 06:18:23 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 28 Mar 2023 06:18:23 -0500 Received: from [10.24.69.141] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32SBIKNH008268; Tue, 28 Mar 2023 06:18:21 -0500 Message-ID: <5f08cb2f-d2de-8e4e-a9be-1ef3a5fd3a39@ti.com> Date: Tue, 28 Mar 2023 16:48:20 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH V3 1/2] arm64: dts: ti: k3-j721s2-mcu-wakeup: Fix IO PADCONFIG size for wakeup domain Content-Language: en-US To: Sinthu Raja , Nishanth Menon , Tero Kristo , Rob Herring CC: Vignesh Raghavendra , Krzysztof Kozlowski , , , , Sinthu Raja , Vaishnav Achath References: <20230316114102.3602-1-sinthu.raja@ti.com> <20230316114102.3602-2-sinthu.raja@ti.com> From: Vaishnav Achath In-Reply-To: <20230316114102.3602-2-sinthu.raja@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_041829_091388_C6A950E3 X-CRM114-Status: GOOD ( 22.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sinthu, On 16/03/23 17:11, Sinthu Raja wrote: > From: Sinthu Raja > > The size of wkup domain I/O PADCONFIG register set is incorrect for J721S2. > Therefore, update the PADCONFIG total offset size to the correct value for > J721S22 SoC. > > Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC") > Signed-off-by: Sinthu Raja > --- > > Changes in V3: > - Added Fix tag > > Changes in V2: > - Update commit description. > - Update the offset value to 0x194 because 0x190 is the last register of the > IO PADCONFIG register set. > The existing PADCONFIG register region descriptions in the pinctrl nodes seems to be incorrect for j721s2-main and j721s2-mcu-wakeup due to non-addressable holes in the region which causes bus aborts when the registers are read and causes system crash if we read something like, /sys/kernel/debug/pinctrl/4301c000.pinctrl-pinctrl-single/pins This is what I saw from inspection of the datasheet: * WKUP_PADCONFIG13, WKUP_PADCONFIG25 missing in WKUP_PADCONFIG region * MAIN_PADCONFIG 64-68 missing in MAIN_PADCONFIG region I have verified that your patch does not introduce new issues, but since it is a Fix patch, I will defer the decision to the maintainers on whether we should split the nodes to avoid non-addressable regions and fix it completely here or later do a fix for the split. Thanks and Regards, Vaishnav > arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > index 0af242aa9816..b10f1e8b98e6 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > @@ -50,7 +50,7 @@ mcu_ram: sram@41c00000 { > wkup_pmx0: pinctrl@4301c000 { > compatible = "pinctrl-single"; > /* Proxy 0 addressing */ > - reg = <0x00 0x4301c000 0x00 0x178>; > + reg = <0x00 0x4301c000 0x00 0x194>; > #pinctrl-cells = <1>; > pinctrl-single,register-width = <32>; > pinctrl-single,function-mask = <0xffffffff>; -- Regards, Vaishnav _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel