From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 530C4C531DC for ; Fri, 23 Aug 2024 08:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Sa2OTpQrBESkhM7AyFlojoPsyzzboKrANMMd0+jjBPI=; b=2qbJVM4upuDDln4eRdDm/lE5CR xDSK6rrDr2R74yt5neubGt8gXQYMoyfti5lVIx4E0qDIE9b56IYhDAkQX52ZyXfmXiJG/pCv1qUd3 c2SIIIF3kAuAwuL/xOyxP4N//RKjIj+urjGhuVF3SxMiasyZCBPQ6w+597W5OvvspfsJAuH6g+gA1 aDCWZG5SMkXnWkDzJvbGZMvdDEP/z2mmDW4W8HaUt05LUUJCDoe1wfsDbkyD24V9xzrvxqjAiIgN2 IK0guFqRiB40F9kPr5SH1rLZ5yPUZzYWC9cXPnxOCMmNpJ2PeEkYhrvNabfP0HWa10WObaD6iTmtR Raf29yNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shPPD-0000000Fnqx-3Dj8; Fri, 23 Aug 2024 08:12:23 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shPII-0000000Fl0k-3Hwl for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 08:05:17 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5bf009cf4c0so1988339a12.1 for ; Fri, 23 Aug 2024 01:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724400313; x=1725005113; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Sa2OTpQrBESkhM7AyFlojoPsyzzboKrANMMd0+jjBPI=; b=bf1d/plvO/qQ0atkqHrxNxpULJMki2brSD0OPWeDGJD3V+xc7Rx281dH1NYhAgzwaz 3kpm305AMWXyDrvRe2re3QLSSI7PMama2GGCnf1vfczAOchhOZiayT7LfNOPBdQmGY1d xMyG0bdGZMT8/EoiYCqtymAij0HMsa/aZkugaSD8ZrVN60CKe592oFFKdWDDbBBu0BHF XUVcEMFET+cJhbwJb1S48cJv0sTWfN+RwXsvYtwHCTzeuyjQuQbkHnDSnPwV7TECnFsO +hwWhX2eOyKuAd5WVodHBINaRfLi7ePZVQj0pcw6xlGiBCjgO3MiurqSAXt7sTgCs/g+ Zpew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724400313; x=1725005113; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Sa2OTpQrBESkhM7AyFlojoPsyzzboKrANMMd0+jjBPI=; b=EfrqIZb39UdaV+m4pA9941EWw/+DtTlCiPP/PYKmA+AFreMQo2ioKFTXlgeAXtCnpc 1gdeFn+bRR5HjlOgfFBfi+CIwNiuEaZ9PQi4WU0jbOo85Xz3kP2Bm2AgkRqiL8lhd1zQ tiMoS8yg4FvpnSvJ8NKjq/6qzR2AgpMa4/PZ3ac1++hC4UoBgYBuvWeBN85wb4wwM10n JKqMofcw+fbcd9HmMtZeFO+kb+u40WjhjPr6cCZ0alxRxKSQZS9antvMdMGqw3JFmfCZ JCb6r4D9TSJNbPtl/JF6MAtGMzRJXXgQAsbTiCX3VPu/DzfDEQ84iy+C4jU+OBkBe3kz FGbw== X-Forwarded-Encrypted: i=1; AJvYcCWHAKmd+KZa+EP65/tF1OFg2K7AXB8W9LQO91mn/TkD33KO8FhRyk/Pb6ODyXWZ7hccaSf21INlCasfM6vQWqM3@lists.infradead.org X-Gm-Message-State: AOJu0YyblGHgwJah37bkGRmEsEQdiVPsLJTxXGZFDuN/lrAg5zrdQ1k4 oV0PtYNII1eda5Jze94BbDk6+YNjFCiKoFj0foAnHcjYqoflpWCiWNSPMP+ov0E= X-Google-Smtp-Source: AGHT+IFLA0foch1GjV3sZ6TDbZaP3PbxJBTxdcJ9LvOUf0bBMIcrMOGIxsjxdcDtskzYa8CA/ntjuA== X-Received: by 2002:a05:6402:d06:b0:5be:df28:f6e3 with SMTP id 4fb4d7f45d1cf-5c08916a8aamr730964a12.13.1724400312895; Fri, 23 Aug 2024 01:05:12 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c0515ab2f1sm1756491a12.97.2024.08.23.01.05.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Aug 2024 01:05:12 -0700 (PDT) Message-ID: <5f14dc3a-edff-45f3-a162-3f6fd567777f@tuxon.dev> Date: Fri, 23 Aug 2024 11:05:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/16] reset: rzg2l-usbphy-ctrl: Get reset control array Content-Language: en-US To: Biju Das , "vkoul@kernel.org" , "kishon@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "p.zabel@pengutronix.de" , "geert+renesas@glider.be" , "magnus.damm@gmail.com" , "gregkh@linuxfoundation.org" , "mturquette@baylibre.com" , "sboyd@kernel.org" , Yoshihiro Shimoda , "ulf.hansson@linaro.org" Cc: "linux-phy@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-pm@vger.kernel.org" , Claudiu Beznea References: <20240822152801.602318-1-claudiu.beznea.uj@bp.renesas.com> <20240822152801.602318-8-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_010514_862393_2A6915AC X-CRM114-Status: GOOD ( 27.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Biju, On 23.08.2024 10:25, Biju Das wrote: > Hi Claudiu, > >> -----Original Message----- >> From: Claudiu >> Sent: Thursday, August 22, 2024 4:28 PM >> Subject: [PATCH 07/16] reset: rzg2l-usbphy-ctrl: Get reset control array >> >> From: Claudiu Beznea >> >> Before accessing the USB area of the RZ/G3S SoC the PWRRDY bit of the SYS_USB_PWRRDY register need to >> be cleared. When USB area is not used the PWRRDY bit of the SYS_USB_PWRRDY register need to be set. >> This register is in the SYSC controller address space and the assert/de-assert of the signal handled >> by SYSC_USB_PWRRDY was implemented as a reset signal. >> >> The USB modules available on the RZ/G3S SoC that need this bit set are: >> - USB ch0 (supporting host and peripheral mode) >> - USB ch2 (supporting host mode) >> - USBPHY control >> >> As the USBPHY control is the root device for all the other USB channels (USB ch0, USB ch1) add support >> to set the PWRRDY for the USB area when initializing the USBPHY control. As this is done though reset >> signals get the reset array in the USBPHY control driver. >> > > Comment applicable, if the USB PWRRDY signal is modelled as reset signal. > > There is no user for this patch. The first user is RZ/G3S and is there is no support yet. > I think you should merge this patch with next one so that there is a user(RZ/G3S) > for this patch. I have nothing against to squash it. I was seeing it differently: - this patch prepares the ground for the addition of RZ/G3S - the next patch just enables the support for RZ/G3S It looks to me more modular like this, patches are simpler, easier for review and each issue is described differently in patch description. I can do it either ways. Thank you, Claudiu Beznea > Cheers, > Biju > >> Signed-off-by: Claudiu Beznea >> --- >> drivers/reset/reset-rzg2l-usbphy-ctrl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c b/drivers/reset/reset-rzg2l-usbphy-ctrl.c >> index 1cd157f4f03b..8b64c12f3bec 100644 >> --- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c >> +++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c >> @@ -132,7 +132,7 @@ static int rzg2l_usbphy_ctrl_probe(struct platform_device *pdev) >> if (IS_ERR(regmap)) >> return PTR_ERR(regmap); >> >> - priv->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); >> + priv->rstc = devm_reset_control_array_get_exclusive(&pdev->dev); >> if (IS_ERR(priv->rstc)) >> return dev_err_probe(dev, PTR_ERR(priv->rstc), >> "failed to get reset\n"); >> -- >> 2.39.2 >