From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F39C433E2 for ; Wed, 2 Sep 2020 04:56:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98B26206F0 for ; Wed, 2 Sep 2020 04:56:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mQzlxFe3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="cSJtUtL1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98B26206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9NYNB0jhXI8jR/WmNn18GJTlxQcUrefOJkcZdWa9zeo=; b=mQzlxFe36UZSJ04p+CsSRb0Dk W/0yPT7Tw3HGv+NK1u0bXnJhFLc93mD4ukNDAk1wkaHd1EGSSD0HWk9wFBLWJbFuH4T53yaZN2qYQ PJHwqIPvZxiQIvlL+HtfmbCMO/GdMvUtecEeW8opeleehmbvElbEwctwG0CFERl3OtgSWRO+6oDfB /EouMEATuNol5oeEaAoDRb4hX0G6rv4KCbhzNA7bEysx8zxjfGCc6/n1uzwaE1Q2PpLqaVDQYQvZ+ sxnJuE540qijOoXTqzuDR8+pEuiYjKgo3wOqe4EEZ/LTZJKCxtBR/HC2Q2AfCkEioBjrr/TLEzDcB gUH9HE/Vw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDKnQ-0004UK-0B; Wed, 02 Sep 2020 04:54:56 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDKnL-0004Tr-Oa for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 04:54:53 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0824sm79014751; Tue, 1 Sep 2020 23:54:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1599022488; bh=w2iauvTkD+P1VkcMZ0fYC+zoLEESxxiRJVPTkakJ4qM=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=cSJtUtL1C7HwPhLVtKwRsA4LI24Im5sdvLnrZEidzdExFxENdjaLjG9WXWFU310dT vycIdXASeghzE3+i/5nsY2nFvCZ+BBZTVnW9zuG9y8JDbVH1hj43ha43xGVtmgB8Eq 0B5VFtZaLuSwCyW9wUUlBHnro1TqyGPeA1N1Lywo= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0824smKo031079 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 1 Sep 2020 23:54:48 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 1 Sep 2020 23:54:48 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 1 Sep 2020 23:54:48 -0500 Received: from [10.250.232.147] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0824sgm6036815; Tue, 1 Sep 2020 23:54:43 -0500 Subject: Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes To: Nishanth Menon References: <20200901140628.8800-1-kishon@ti.com> <20200901140628.8800-2-kishon@ti.com> <20200901145204.ayybrzqjcfhiqnfq@akan> From: Kishon Vijay Abraham I Message-ID: <5f23246a-a9d7-495d-a4ec-d392ad95a450@ti.com> Date: Wed, 2 Sep 2020 10:24:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200901145204.ayybrzqjcfhiqnfq@akan> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200902_005451_959717_B2E6245E X-CRM114-Status: GOOD ( 23.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tero Kristo , devicetree@vger.kernel.org, Rob Herring , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nishanth, On 01/09/20 8:22 pm, Nishanth Menon wrote: > On 19:36-20200901, Kishon Vijay Abraham I wrote: >> Add PCIe device tree node (both RC and EP) for the four >> PCIe instances here. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218 ++++++++++++++++++++++ >> arch/arm64/boot/dts/ti/k3-j721e.dtsi | 5 +- >> 2 files changed, 222 insertions(+), 1 deletion(-) > > > Did you look at the diff of the dtbs_check before and after this > series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/ I didn't see any errors when I checked for individual bindings a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml" SCHEMA Documentation/devicetree/bindings/processed-schema.yaml DTC arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml" SCHEMA Documentation/devicetree/bindings/processed-schema.yaml DTC arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml > >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >> index 00a36a14efe7..a36909d8b8c3 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >> @@ -28,6 +28,26 @@ >> #size-cells = <1>; >> ranges = <0x0 0x0 0x00100000 0x1c000>; >> >> + pcie0_ctrl: pcie-ctrl@4070 { > https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf > Section 2.2.2: why not use syscon@4070 and so on? okay, will change to generic name. > >> + compatible = "syscon"; >> + reg = <0x00004070 0x4>; >> + }; >> + >> + pcie1_ctrl: pcie-ctrl@4074 { >> + compatible = "syscon"; >> + reg = <0x00004074 0x4>; >> + }; >> + >> + pcie2_ctrl: pcie-ctrl@4078 { >> + compatible = "syscon"; >> + reg = <0x00004078 0x4>; >> + }; >> + >> + pcie3_ctrl: pcie-ctrl@407c { >> + compatible = "syscon"; >> + reg = <0x0000407c 0x4>; >> + }; >> + >> serdes_ln_ctrl: serdes-ln-ctrl@4080 { >> compatible = "mmio-mux"; >> reg = <0x00004080 0x50>; >> @@ -576,6 +596,204 @@ >> }; >> }; >> >> + pcie0_rc: pcie@2900000 { >> + compatible = "ti,j721e-pcie-host"; >> + reg = <0x00 0x02900000 0x00 0x1000>, >> + <0x00 0x02907000 0x00 0x400>, >> + <0x00 0x0d000000 0x00 0x00800000>, >> + <0x00 0x10000000 0x00 0x00001000>; >> + reg-names = "intd_cfg", "user_cfg", "reg", "cfg"; >> + interrupt-names = "link_state"; >> + interrupts = ; >> + device_type = "pci"; >> + ti,syscon-pcie-ctrl = <&pcie0_ctrl>; >> + max-link-speed = <3>; >> + num-lanes = <2>; >> + power-domains = <&k3_pds 239 TI_SCI_PD_EXCLUSIVE>; >> + clocks = <&k3_clks 239 1>; >> + clock-names = "fck"; >> + #address-cells = <3>; >> + #size-cells = <2>; >> + bus-range = <0x0 0xf>; >> + vendor-id = <0x104c>; >> + device-id = <0xb00d>; >> + msi-map = <0x0 &gic_its 0x0 0x10000>; >> + dma-coherent; >> + ranges = <0x01000000 0x0 0x10001000 0x0 0x10001000 0x0 0x0010000>, >> + <0x02000000 0x0 0x10011000 0x0 0x10011000 0x0 0x7fef000>; >> + dma-ranges = <0x02000000 0x0 0x0 0x0 0x0 0x10000 0x0>; >> + }; >> + >> + pcie0_ep: pcie-ep@2900000 { > Not related to this patch, but just a suggestion: pcie-ep -> do we > need to add that to the Generic names in DT spec? > > [...] >> diff --git a/arch/arm64/boot/dts/ti/k3-j721e.dtsi b/arch/arm64/boot/dts/ti/k3-j721e.dtsi >> index f787aa73aaae..eeb02115b966 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721e.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j721e.dtsi >> @@ -132,9 +132,12 @@ >> <0x00 0x06400000 0x00 0x06400000 0x00 0x00400000>, /* USBSS1 */ >> <0x00 0x01000000 0x00 0x01000000 0x00 0x0af02400>, /* Most peripherals */ >> <0x00 0x30000000 0x00 0x30000000 0x00 0x0c400000>, /* MAIN NAVSS */ >> - <0x00 0x0d000000 0x00 0x0d000000 0x00 0x01000000>, /* PCIe Core*/ >> + <0x00 0x0d000000 0x00 0x0d000000 0x00 0x01800000>, /* PCIe Core*/ >> + <0x00 0x0e000000 0x00 0x0e000000 0x00 0x01800000>, /* PCIe Core*/ >> <0x00 0x10000000 0x00 0x10000000 0x00 0x10000000>, /* PCIe DAT */ > ^^ > should be PCIe1? > Just because you are introducing PCIe2,3 in this patch, the net result > does'nt look consistent? Also might want to cover this change in the > $commit_message. yeah, we could have a separate patch for this change. Thanks Kishon > [...] >> <0x00 0x64800000 0x00 0x64800000 0x00 0x00800000>, /* C71 */ >> + <0x44 0x00000000 0x44 0x00000000 0x00 0x08000000>, /* PCIe2 DAT */ >> + <0x44 0x10000000 0x44 0x10000000 0x00 0x08000000>, /* PCIe3 DAT */ >> <0x4d 0x80800000 0x4d 0x80800000 0x00 0x00800000>, /* C66_0 */ >> <0x4d 0x81800000 0x4d 0x81800000 0x00 0x00800000>, /* C66_1 */ >> <0x4e 0x20000000 0x4e 0x20000000 0x00 0x00080000>, /* GPU */ >> -- >> 2.17.1 >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel