From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B90C4338F for ; Sat, 7 Aug 2021 00:36:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38A8260560 for ; Sat, 7 Aug 2021 00:36:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 38A8260560 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=725m0ZGNapfnR36hnD9HvXKbWDzSyPsbDnXHtVaQQfs=; b=B1ti16o0rKjq5gvfFspGbZcTo8 giD/hpLo77Pi5PpbmpKoeoMYgs4uBbamE8vTsBZ0X9jVx3Gm5ZXmmXVRIrsV2dAIZqf8jVNz8Zpcy LiCWMfC7vItoYKzWGEfoSMAxrqVxSCAzhAAeEellSv9BkAdqTJ3dIiDLJGcxK6EER4PZbtm4RzlSm 8x3a4vjmeaG9pdAZdWuHRqt33RmPVoxukXZOuQESbBFZjf7duq2nDJ9hnuMIV0lJigdKDjvEI+VfN mdZFxAzhKb9cX9p8MctcjNVbaU+AyFbHzV3FV2y2NO5vPORwzhHA4yFBG8IZUk/Y/wwsZEY0Vaxwi UXHxVcGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCAJ0-00Du85-Sd; Sat, 07 Aug 2021 00:35:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCAIv-00Du7M-UJ; Sat, 07 Aug 2021 00:35:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 870E731B; Fri, 6 Aug 2021 17:35:02 -0700 (PDT) Received: from [192.168.122.166] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A37FA3F66F; Fri, 6 Aug 2021 17:35:01 -0700 (PDT) Subject: Re: [PATCH 3/3] PCI/ACPI: Add new quirk detection, enable bcm2711 To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, nsaenz@kernel.org, bhelgaas@google.com, rjw@rjwysocki.net, lenb@kernel.org, robh@kernel.org, kw@linux.com, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210806221256.GA1891371@bjorn-Precision-5520> From: Jeremy Linton Message-ID: <5f4f484b-9eef-2722-405d-a7ff6259aa0f@arm.com> Date: Fri, 6 Aug 2021 19:34:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210806221256.GA1891371@bjorn-Precision-5520> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210806_173510_135212_7F162F23 X-CRM114-Status: GOOD ( 30.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Thanks for looking at this. On 8/6/21 5:12 PM, Bjorn Helgaas wrote: > In subject, this or similar would match history: > > PCI/ACPI: Add Broadcom bcm2711 MCFG quirk > > On Thu, Aug 05, 2021 at 04:12:00PM -0500, Jeremy Linton wrote: >> Now that we have a bcm2711 quirk, we need to be able to >> detect it when the MCFG is missing. Use a namespace >> property as an alternative to the MCFG OEM. > > Rewrap to use ~75 columns. > > Mention the DT namespace property here. > >> Signed-off-by: Jeremy Linton >> --- >> drivers/acpi/pci_mcfg.c | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c >> index 53cab975f612..7d77fc72c2a4 100644 >> --- a/drivers/acpi/pci_mcfg.c >> +++ b/drivers/acpi/pci_mcfg.c >> @@ -169,6 +169,9 @@ static struct mcfg_fixup mcfg_quirks[] = { >> ALTRA_ECAM_QUIRK(1, 13), >> ALTRA_ECAM_QUIRK(1, 14), >> ALTRA_ECAM_QUIRK(1, 15), >> + >> + { "bcm2711", "", 0, 0, MCFG_BUS_ANY, &bcm2711_pcie_ops, >> + DEFINE_RES_MEM(0xFD500000, 0xA000) }, >> }; >> >> static char mcfg_oem_id[ACPI_OEM_ID_SIZE]; >> @@ -198,8 +201,19 @@ static void pci_mcfg_apply_quirks(struct acpi_pci_root *root, >> u16 segment = root->segment; >> struct resource *bus_range = &root->secondary; >> struct mcfg_fixup *f; >> + const char *soc; >> int i; >> >> + /* >> + * This could be a machine with a PCI/SMC conduit, >> + * which means it doens't have MCFG. Get the machineid from >> + * the namespace definition instead. > > s/SMC/SMCCC/ ? Cover letter uses SMCCC (not sure it's relevant anyway) > s/doens't/doesn't/ > > Rewrap comment to use ~80 columns. > > Seems pretty reasonable that a platform without standard ECAM might > not have MCFG, since MCFG basically implies ECAM. Sure, on all the above comments. > > Is "linux,pcie-quirk" the right property to look for? It doesn't > sound very generic, and it doesn't sound like anything related to > ECAM. Is it new? I don't see it in the tree yet. Should it be in > Documentation/devicetree/bindings/pci/pci.txt so we don't get a > different property name for every new platform? Yes, I made it up. Someone else commented about the "linux," partially because it should be "linux-" to conform with https://github.com/UEFI/DSD-Guide. But also in the same context of it being linux specific. I think that guide is where it should end up, rather than the devicetree bindings. I guess we can request addition to the uefi- but that seems like a mistake this is really (hopefully?) a Linux specific properly as other OS's will simply use the SMC. I think we could request another prefix if we come up with a good one and think it belongs in that guide. > >> + */ >> + if (!fwnode_property_read_string(acpi_fwnode_handle(root->device), >> + "linux,pcie-quirk", &soc)) { >> + memcpy(mcfg_oem_id, soc, ACPI_OEM_ID_SIZE); >> + } >> + >> for (i = 0, f = mcfg_quirks; i < ARRAY_SIZE(mcfg_quirks); i++, f++) { >> if (pci_mcfg_quirk_matches(f, segment, bus_range)) { >> if (f->cfgres.start) >> -- >> 2.31.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel