Re: [PATCH v4 1/3] drm/rockchip: dsi: Add maximum per lane bit rate calculation

[Chaoyi Chen <chaoyi.chen@rock-chips.com>]

Hi Heiko,

On 9/12/2026 8:32 PM, Heiko Stuebner wrote:
> Am Mittwoch, 12. August 2026, 09:30:00 Mitteleuropäische Sommerzeit schrieb Chaoyi Chen:
>> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
>>
>> Different chips have varying support for the maximum bit rate per lane.
>>
>> Add calculation for the maximum per lane bit rate for various chip
>> platforms.
>>
>> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> 
> [...]
> 
>> @@ -573,6 +574,7 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode,
>>  	unsigned long _fbdiv, best_fbdiv;
>>  	unsigned long min_delta = ULONG_MAX;
>>  
>> +	max_mbps = dsi->cdata->max_bit_rate_per_lane / USEC_PER_SEC;
> 
> As the value is called max_bit_rate_per_lane, I guess Sashiko
> is correct in that the max_mbps check should use "<=" ?
> 

Thanks for pointing this out. I'll fix it in v5.

> 
> Heiko

-- 
Best, 
Chaoyi