public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: gary.hook@amd.com (Gary R Hook)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 9/9] crypto: ccp - Use IPAD/OPAD constant
Date: Fri, 19 May 2017 15:32:09 -0500	[thread overview]
Message-ID: <5f959f00-ca3b-0515-d743-33b251fb4b18@amd.com> (raw)
In-Reply-To: <20170519065331.27670-10-clabbe.montjoie@gmail.com>

On 5/19/2017 1:53 AM, Corentin Labbe wrote:
> This patch simply replace all occurrence of HMAC IPAD/OPAD value by their
> define.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Acked-by: Gary R Hook <gary.hook@amd.com>

> ---
>   drivers/crypto/ccp/ccp-crypto-sha.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/ccp-crypto-sha.c 
> b/drivers/crypto/ccp/ccp-crypto-sha.c
> index 6b46eea94932..ce97b3868f4a 100644
> --- a/drivers/crypto/ccp/ccp-crypto-sha.c
> +++ b/drivers/crypto/ccp/ccp-crypto-sha.c
> @@ -18,6 +18,7 @@
>   #include <linux/crypto.h>
>   #include <crypto/algapi.h>
>   #include <crypto/hash.h>
> +#include <crypto/hmac.h>
>   #include <crypto/internal/hash.h>
>   #include <crypto/sha.h>
>   #include <crypto/scatterwalk.h>
> @@ -308,8 +309,8 @@ static int ccp_sha_setkey(struct crypto_ahash *tfm, 
> const u8 *key,
>           }
> 
>           for (i = 0; i < block_size; i++) {
> -               ctx->u.sha.ipad[i] = ctx->u.sha.key[i] ^ 0x36;
> -               ctx->u.sha.opad[i] = ctx->u.sha.key[i] ^ 0x5c;
> +               ctx->u.sha.ipad[i] = ctx->u.sha.key[i] ^ HMAC_IPAD_VALUE;
> +               ctx->u.sha.opad[i] = ctx->u.sha.key[i] ^ HMAC_OPAD_VALUE;
>           }
> 
>           sg_init_one(&ctx->u.sha.opad_sg, ctx->u.sha.opad, block_size);
> -- 
> 2.13.0
> 

  reply	other threads:[~2017-05-19 20:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19  6:53 [PATCH v2 0/9] crypto: add HMAC IPAD/OPAD constant Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 1/9] crypto: add hmac " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 2/9] crypto: brcm - Use " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 3/9] crypto: ixp4xx " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 4/9] crypto: marvell " Corentin Labbe
2017-05-19  9:17   ` Boris Brezillon
2017-05-19  6:53 ` [PATCH v2 5/9] crypto: mv_cesa " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 6/9] crypto: omap-sham " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 7/9] crypto: qat " Corentin Labbe
2017-05-19  6:53 ` [PATCH v2 8/9] crypto: mediatek " Corentin Labbe
2017-05-19  9:11   ` Matthias Brugger
2017-05-19  6:53 ` [PATCH v2 9/9] crypto: ccp " Corentin Labbe
2017-05-19 20:32   ` Gary R Hook [this message]
2017-05-23  5:03 ` [PATCH v2 0/9] crypto: add HMAC " Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f959f00-ca3b-0515-d743-33b251fb4b18@amd.com \
    --to=gary.hook@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox