From: Markus Elfring <Markus.Elfring@web.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org,
kernel-janitors@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Ma Ke <make24@iscas.ac.cn>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>,
Julia Lawall <julia.lawall@inria.fr>,
Neal Liu <neal_liu@aspeedtech.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc
Date: Tue, 25 Jun 2024 17:20:07 +0200 [thread overview]
Message-ID: <5fa430f5-3e18-4c20-93d4-6733afd6bdcf@web.de> (raw)
In-Reply-To: <2024062532-strep-president-44d7@gregkh>
>>>>> We should verify the bound of the array to assure that host
>>>>> may not manipulate the index to point past endpoint array.
>>>>
>>>> Why did you not choose an imperative wording for your change description?
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94
>>>
>>> Markus, please stop reviewing USB patches. This is not helpful at all,
>>> and causes new developers extra work for no reason at all.
>>
>> How does this feedback fit to the linked information source?
>
> That is not what I wrote.
You indicated concerns according to patch review processes,
didn't you?
See also:
* Patch submission notes
https://elixir.bootlin.com/linux/v6.10-rc5/source/Documentation/process/maintainer-tip.rst#L100
* Contributor Covenant Code of Conduct
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/code-of-conduct.rst?h=v6.10-rc5#n3
> I wrote, "Please stop reviewing USB patches."
>
> Please stop now.
I might be going to influence evolution of this software area in other ways
under other circumstances.
Regards,
Markus
next prev parent reply other threads:[~2024-06-25 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 2:23 [PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc Ma Ke
2024-06-25 12:00 ` Markus Elfring
2024-06-25 12:29 ` Greg Kroah-Hartman
2024-06-25 12:30 ` Greg Kroah-Hartman
2024-06-25 12:50 ` Markus Elfring
2024-06-25 14:30 ` Greg Kroah-Hartman
2024-06-25 15:20 ` Markus Elfring [this message]
2024-06-25 15:25 ` Greg Kroah-Hartman
2024-06-25 16:12 ` [v4] " Markus Elfring
2024-06-26 8:55 ` [RFC] usb: Patch review processes? Markus Elfring
2024-06-26 0:07 ` [PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fa430f5-3e18-4c20-93d4-6733afd6bdcf@web.de \
--to=markus.elfring@web.de \
--cc=andrew@codeconstruct.com.au \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=neal_liu@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).