From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08D33C7EE2E for ; Fri, 9 Jun 2023 15:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CenvKL6bQIq8mj+kgzWbzQLWTIdBt5rxxijgELse4hA=; b=OQAIYrp44LyCNb wQeo9sLEMRs+YfCRBbLiPMSN/n/Vi6+CCwo3XojEsFW2pSeL91v/Z8je72ph16KfUsfv8tRuEN2yt LK08Hj7JIedZZGdq4qWx5MstQ+9vK4p4kQXKyHgJEz3Wq0H4bo6HD+xGUpuzm/BZaxjSKk3+m2cmb Y5CXz+whXYWXlRkY/S78p1B0JuaLwM3o99P0JHZbwUOLsMqVVR3UaIYZCg8lXrLWQGxXU16WewAP1 T57Gvhadc5WwCJplDmJc7/66HcRbT38PwFcT7ZfOgAxq9yZSs+SR8p1c59CXS2NQVSHTWrTcBZFEy vnwU8HJPddrrS1BDBeEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7ePt-00DWer-0m; Fri, 09 Jun 2023 15:52:45 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7ePq-00DWdS-17; Fri, 09 Jun 2023 15:52:44 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-30e57e0a0c7so1395992f8f.2; Fri, 09 Jun 2023 08:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686325957; x=1688917957; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kjQv+AKpm2A2yuAsyilt/YShNfzL1O/WlL6C0kaj11c=; b=Mz9/q2Bz2kxvWcu9mpwFN19bHSabAwti/2J9jRHSp9h6oRXzqvMjEP4Iru7KuP9zzn 8n43Fgh30mtQPCkybBtMULCToeqJlrbMlrCEi8pPvCbsrdVVzOF+knPUWPFy7hx8XEfz 94Myx5a9g91HpSCQeSRBDlqdrrbKxd0fCkyOfP3YotYuLmX8443EpVyjeQnj2MrXmjZr 52pa5HWsF08pyH4SdU4jaNsgNYDqmWbHPOkjC2oqArQWqjBm3RRznNdEIW6nJM/TxloP 9LAv0EnSsD7UvjMW6Oilm1lqjxP5ln1FzgkzeuOyRE465zke3SM7S+H2OaIQCcmJUBPZ CniQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686325957; x=1688917957; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kjQv+AKpm2A2yuAsyilt/YShNfzL1O/WlL6C0kaj11c=; b=JsUkJNtUS+OgAJEk5UjCKmvc9h+BQKtDnAeyIf8QS0l4ygAnIyBLidSIrV9OY4Q3jy OSO3gaJy32g1L4vCqqdhcCvInvmMvV37NTvA4wws+tWFxppDTL0V65C3BW3Xyl5S7oz3 zRSqqET9zKtS8fhdpcr2gLboT5Ld883/iVnjzZu+LW5Hn3jgZBCv5Pyss2maElTGS3vV RJRuBY6VdypsAquVdRpUja82ZPvP90cLLxbM+2xxaDSSVU7uYbeAcoe0vTDW7MISHwXZ ZqeyB6ISmArfYDVc0V6LKW8SL8B6Y78AN4uefAutIcdchpwLVZhJo0Wh89AzmG8gvher J/rg== X-Gm-Message-State: AC+VfDwBvlrUiqq3LXDqT703q8buuQK9tnnAmQ8HRs41IjPoF5GVqUHX RanuZUtDXme4cvwat5cUPEk= X-Google-Smtp-Source: ACHHUZ7zQlGBFYBKSby2rJSQtQXAyjtblUs/9IBWEtZL94NL7HTR5NhRWsb/bktjEUiWik5gZEW9lg== X-Received: by 2002:adf:e0cb:0:b0:30a:d8df:6800 with SMTP id m11-20020adfe0cb000000b0030ad8df6800mr1179872wri.33.1686325956846; Fri, 09 Jun 2023 08:52:36 -0700 (PDT) Received: from [192.168.2.177] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id o7-20020adfeac7000000b002fed865c55esm4826686wrn.56.2023.06.09.08.52.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 08:52:35 -0700 (PDT) Message-ID: <5fb4d78b-05a2-1a31-c1db-878c0a6d0380@gmail.com> Date: Fri, 9 Jun 2023 17:52:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 4/9] regulator: mt6358: Drop *_SSHUB regulators Content-Language: en-US, ca-ES, es-ES To: Chen-Yu Tsai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Liam Girdwood , AngeloGioacchino Del Regno Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230609083009.2822259-1-wenst@chromium.org> <20230609083009.2822259-5-wenst@chromium.org> From: Matthias Brugger In-Reply-To: <20230609083009.2822259-5-wenst@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230609_085242_387101_A2026AA1 X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/06/2023 10:30, Chen-Yu Tsai wrote: > The *_SSHUB regulators are actually alternate configuration interfaces > for their non *_SSHUB counterparts. They are not separate regulator > outputs. These registers are intended for the companion processor to > use to configure the power rails while the main processor is sleeping. > They are not intended for the main operating system to use. > > Since they are not real outputs they shouldn't be modeled separately. > Remove them. Luckily no device tree actually uses them. > > Signed-off-by: Chen-Yu Tsai Reviewed-by: Matthias Brugger > --- > drivers/regulator/mt6358-regulator.c | 14 -------------- > include/linux/regulator/mt6358-regulator.h | 4 ---- > 2 files changed, 18 deletions(-) > > diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c > index faf6b0757019..946a251a8b3a 100644 > --- a/drivers/regulator/mt6358-regulator.c > +++ b/drivers/regulator/mt6358-regulator.c > @@ -505,9 +505,6 @@ static struct mt6358_regulator_info mt6358_regulators[] = { > MT6358_BUCK("buck_vcore", VCORE, 500000, 1293750, 6250, > buck_volt_range1, 0x7f, MT6358_BUCK_VCORE_DBG0, 0x7f, > MT6358_VCORE_VGPU_ANA_CON0, 1), > - MT6358_BUCK("buck_vcore_sshub", VCORE_SSHUB, 500000, 1293750, 6250, > - buck_volt_range1, 0x7f, MT6358_BUCK_VCORE_SSHUB_ELR0, 0x7f, > - MT6358_VCORE_VGPU_ANA_CON0, 1), > MT6358_BUCK("buck_vpa", VPA, 500000, 3650000, 50000, > buck_volt_range3, 0x3f, MT6358_BUCK_VPA_DBG0, 0x3f, > MT6358_VPA_ANA_CON0, 3), > @@ -583,10 +580,6 @@ static struct mt6358_regulator_info mt6358_regulators[] = { > MT6358_LDO1("ldo_vsram_others", VSRAM_OTHERS, 500000, 1293750, 6250, > buck_volt_range1, MT6358_LDO_VSRAM_OTHERS_DBG0, 0x7f00, > MT6358_LDO_VSRAM_CON2, 0x7f), > - MT6358_LDO1("ldo_vsram_others_sshub", VSRAM_OTHERS_SSHUB, 500000, > - 1293750, 6250, buck_volt_range1, > - MT6358_LDO_VSRAM_OTHERS_SSHUB_CON1, 0x7f, > - MT6358_LDO_VSRAM_OTHERS_SSHUB_CON1, 0x7f), > MT6358_LDO1("ldo_vsram_gpu", VSRAM_GPU, 500000, 1293750, 6250, > buck_volt_range1, MT6358_LDO_VSRAM_GPU_DBG0, 0x7f00, > MT6358_LDO_VSRAM_CON3, 0x7f), > @@ -603,9 +596,6 @@ static struct mt6358_regulator_info mt6366_regulators[] = { > MT6366_BUCK("buck_vcore", VCORE, 500000, 1293750, 6250, > buck_volt_range1, 0x7f, MT6358_BUCK_VCORE_DBG0, 0x7f, > MT6358_VCORE_VGPU_ANA_CON0, 1), > - MT6366_BUCK("buck_vcore_sshub", VCORE_SSHUB, 500000, 1293750, 6250, > - buck_volt_range1, 0x7f, MT6358_BUCK_VCORE_SSHUB_ELR0, 0x7f, > - MT6358_VCORE_VGPU_ANA_CON0, 1), > MT6366_BUCK("buck_vpa", VPA, 500000, 3650000, 50000, > buck_volt_range3, 0x3f, MT6358_BUCK_VPA_DBG0, 0x3f, > MT6358_VPA_ANA_CON0, 3), > @@ -670,10 +660,6 @@ static struct mt6358_regulator_info mt6366_regulators[] = { > MT6366_LDO1("ldo_vsram_others", VSRAM_OTHERS, 500000, 1293750, 6250, > buck_volt_range1, MT6358_LDO_VSRAM_OTHERS_DBG0, 0x7f00, > MT6358_LDO_VSRAM_CON2, 0x7f), > - MT6366_LDO1("ldo_vsram_others_sshub", VSRAM_OTHERS_SSHUB, 500000, > - 1293750, 6250, buck_volt_range1, > - MT6358_LDO_VSRAM_OTHERS_SSHUB_CON1, 0x7f, > - MT6358_LDO_VSRAM_OTHERS_SSHUB_CON1, 0x7f), > MT6366_LDO1("ldo_vsram_gpu", VSRAM_GPU, 500000, 1293750, 6250, > buck_volt_range1, MT6358_LDO_VSRAM_GPU_DBG0, 0x7f00, > MT6358_LDO_VSRAM_CON3, 0x7f), > diff --git a/include/linux/regulator/mt6358-regulator.h b/include/linux/regulator/mt6358-regulator.h > index a4307cd9edd6..c71a6a9fce7a 100644 > --- a/include/linux/regulator/mt6358-regulator.h > +++ b/include/linux/regulator/mt6358-regulator.h > @@ -47,8 +47,6 @@ enum { > MT6358_ID_VLDO28, > MT6358_ID_VAUD28, > MT6358_ID_VSIM2, > - MT6358_ID_VCORE_SSHUB, > - MT6358_ID_VSRAM_OTHERS_SSHUB, > MT6358_ID_RG_MAX, > }; > > @@ -88,8 +86,6 @@ enum { > MT6366_ID_VMC, > MT6366_ID_VAUD28, > MT6366_ID_VSIM2, > - MT6366_ID_VCORE_SSHUB, > - MT6366_ID_VSRAM_OTHERS_SSHUB, > MT6366_ID_RG_MAX, > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel