From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15140C433F5 for ; Wed, 9 Feb 2022 09:44:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PzV2XmHisVoWSew+bX5C8ot1dyqzT4LT1IdaTG4JBoI=; b=EJGHOoAs+3hDv9 UEzraWp48/rO1iHLP3ayW1Jd2rFQyhSkNu6BY4p/92/jWyO+jD0sM7IMJ1NwzOUoxKCJCXHZquJ48 DNIXfZG8PChYubfagDyxme71IsTFy3u1x0NR0M2jFwq5ORZGQuC+3T0rgSahf5IIxLEiCMtc6yzz1 p99hYpI03Z9xVCHzdi2EpCMCsBYp9FZ5Dq1sxg+cbWGaU9LBSPC0Uy/5/M8b1gSTU3kHvvl97fmBR uUa7pQZBP1Fgd86gjhmhkMRC4pfSnHLrn48GqJDmt+6ZlyMF+qwA4Ml+1GxzVRcZDppoQiwPIHhiA X3lebqK8bujYLdkbOKtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHjUj-00Gypq-QY; Wed, 09 Feb 2022 09:42:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHjUf-00GyoT-Em for linux-arm-kernel@lists.infradead.org; Wed, 09 Feb 2022 09:42:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D25BF1FB; Wed, 9 Feb 2022 01:42:31 -0800 (PST) Received: from [10.57.88.251] (unknown [10.57.88.251]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A38703F73B; Wed, 9 Feb 2022 01:42:30 -0800 (PST) Message-ID: <5fbadc11-0371-7dec-3189-ef5908fb3122@arm.com> Date: Wed, 9 Feb 2022 09:42:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v2 RESEND 1/4] coresight: etm4x: Add lock for reading virtual context ID comparator To: Leo Yan Cc: Mathieu Poirier , Mike Leach , Alexander Shishkin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220204152403.71775-1-leo.yan@linaro.org> <20220204152403.71775-2-leo.yan@linaro.org> <6b91293a-1149-2c77-04a4-421a45d4e1e0@arm.com> <20220209093304.GA334894@leoy-ThinkPad-X240s> From: Suzuki K Poulose In-Reply-To: <20220209093304.GA334894@leoy-ThinkPad-X240s> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_014233_575915_B29C419B X-CRM114-Status: GOOD ( 19.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Leo On 09/02/2022 09:33, Leo Yan wrote: > Hi Suzuki, > > On Wed, Feb 09, 2022 at 05:47:24AM +0000, Suzuki Kuruppassery Poulose wrote: >> Hi Leo >> >> On 04/02/2022 15:24, Leo Yan wrote: >>> Updates to the values and the index are protected via the spinlock. >>> Ensure we use the same lock to read the value safely. >>> >>> Signed-off-by: Leo Yan >>> Reviewed-by: Suzuki K Poulose >>> --- >>> drivers/hwtracing/coresight/coresight-etm4x-sysfs.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c >>> index 10ef2a29006e..2f3b4eef8261 100644 >>> --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c >>> +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c >>> @@ -2111,7 +2111,9 @@ static ssize_t vmid_val_show(struct device *dev, >>> struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); >>> struct etmv4_config *config = &drvdata->config; >>> + spin_lock(&drvdata->spinlock); >>> val = (unsigned long)config->vmid_val[config->vmid_idx]; >>> + spin_unlock(&drvdata->spinlock); >>> return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); >>> } >> >> >> I have queued this patch. > > Thanks! > >> For the rest, we would need to wait until the helper lands in the rc. Sorry, that was not the exact argument, see below. > > The helper function patch has been landed on the mainline kernel, > it would be safe to merge the rest patches. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d7e4f8545b497b3f5687e592f1c355cbaee64c8c The coresight queue is based on rc1 and we already created a stable tag for TRBE erratas, which was pulled into arm64. So, (correct me if I am wrong), AFAIU, we cannot rebase the queue on to rc2 where the patch landed. But happy to proceed, if there is a solution. Mathieu, what do you think ? Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel