From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ACB6C3DA6E for ; Wed, 20 Dec 2023 14:01:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QCPIJYLRSF7RONHywzoHOETM2NyT4KBYQOtkUAZRygY=; b=qbAOrkDjIsC58m TEgociH2h6v5kD/LPqCZUDBeyqdsEk8ncmCYpJpHz/6EyVh3kAUQ6Lv0ouDIvpFnTLWJ+YYWmD+5a x1RqspHVsFOG3AQa9AIPLTcQnivtER4lsoYDEQ/l2Foti78Fdwg1jiLx7gT2MK1y4gf1MaNcSqkH0 8it9KSCvzBolXCFbP18Ga5c2wFJZ+KPgEwOsoc0uc/cjhvfwt4vQMdM+YySmA9gMvb9YgcQwKBkv+ yy8zmHyXwZvDG1nxGrNhwGAhQ9hxyPZ+Juksm3n0Bvmvc9yXkoaZrwx+JfuYVgNmhq66m/gQ/wU1v BOSm3lVP0c8LMHTJE1Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFx7i-00012R-2T; Wed, 20 Dec 2023 14:00:34 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFx7f-0000xx-24 for linux-arm-kernel@lists.infradead.org; Wed, 20 Dec 2023 14:00:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703080827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0O1MqgGGyvjOUiWkIFWdN3z01s+W1X+YTJyO/i9L0rQ=; b=ieNYl5qENJBUK5Qe9YABveQYaQgQ64iiOBZ0ZPO7F6f2lcu3dtB5TLczsbWNtNtOyi19HC 7lG/Fhd+ayKBijDGhOaYTFHT+6E+y/n7ElCie4zvZJEeTeJzTEuLtKnRz3QWEJ1j8+6stX 2Pbl7BRSQ9eHtfdjZq8RUWUlyGIaau4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-244-Hkxv8IRcPQyN_UgIt0jSdg-1; Wed, 20 Dec 2023 09:00:25 -0500 X-MC-Unique: Hkxv8IRcPQyN_UgIt0jSdg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40d1ffbc3b8so15685545e9.0 for ; Wed, 20 Dec 2023 06:00:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703080824; x=1703685624; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0O1MqgGGyvjOUiWkIFWdN3z01s+W1X+YTJyO/i9L0rQ=; b=Ed0TvsXrRSXxgl3/3WiktxI27KeK6FdW98ns93NI9/QUPdCLmKFwxiblpkiytKpmDS tEeH3a9CU9he8V+K1YtxMjkdtOUtk2ZdvUdIrI8HUL7SXFfX9tQAKZK0mWfrQdtOLez/ zKd5rS+fy4B3uH7miyTOoEgXyVDwcfXA6T838pUvlqU0alXTSkv7BdS7yAaPnYafSswv g9D0ssBI27Yv79DCaDz5v/3HpmkWbMzFojw+sasIBTApgyfXdSkUZa1x1S7MxIhIqECk 79VFtId5VNgKhkys31iRSDe7D31AuJr9XmrsA/ehPUhm7MAt2mzd1Ywn8GQX15iOa/9b rtBg== X-Gm-Message-State: AOJu0YyNooiZ6EqoDfhgcFCwrx0gQhKOB4bYliMk3+Hbw8MAByHz0A0N nQImquBK4HT8oHc1FJeJybQ0WaAGccQ6Ei6SFBEFI749ZkZTcfC+Xs1FIbn66gV7iuPC0wC+KYs twSq/So0tOqJQQn+aOKjaiU9CBf3SpFYHARg= X-Received: by 2002:a05:600c:16c4:b0:40c:3133:6f02 with SMTP id l4-20020a05600c16c400b0040c31336f02mr5427093wmn.342.1703080823694; Wed, 20 Dec 2023 06:00:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6tlnLiOllO1kDTgRnWerqGD3+JlJUXHDRI0Sb2gKLNNMCR86VcUGsW0uSAXRgPhFGMOLjyA== X-Received: by 2002:a05:600c:16c4:b0:40c:3133:6f02 with SMTP id l4-20020a05600c16c400b0040c31336f02mr5427069wmn.342.1703080823265; Wed, 20 Dec 2023 06:00:23 -0800 (PST) Received: from ?IPV6:2003:cb:c73b:eb00:8e25:6953:927:1802? (p200300cbc73beb008e25695309271802.dip0.t-ipconnect.de. [2003:cb:c73b:eb00:8e25:6953:927:1802]) by smtp.gmail.com with ESMTPSA id p2-20020a05600c1d8200b0040596352951sm8087777wms.5.2023.12.20.06.00.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 06:00:22 -0800 (PST) Message-ID: <5fcbf405-7e62-4b38-acc4-a9dd8cc91214@redhat.com> Date: Wed, 20 Dec 2023 15:00:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/16] mm: Batch-copy PTE ranges during fork() To: Ryan Roberts , Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Anshuman Khandual , Matthew Wilcox , Yu Zhao , Mark Rutland , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20231218105100.172635-1-ryan.roberts@arm.com> <7c0236ad-01f3-437f-8b04-125d69e90dc0@redhat.com> <9a58b1a2-2c13-4fa0-8ffa-2b3d9655f1b6@arm.com> <28968568-f920-47ac-b6fd-87528ffd8f77@redhat.com> <10b0b562-c1c0-4a66-9aeb-a6bff5c218f6@arm.com> <8f8023cb-3c31-4ead-a9e6-03a10e9490c6@redhat.com> <699cb1db-51eb-460e-9ceb-1ce08ca03050@redhat.com> <2a8c5b6c-f5ae-43b2-99aa-6d10e79b76e1@redhat.com> <3194b8a5-3f72-4d9e-a267-fbdad32ad864@redhat.com> <9f99a3ca-051e-4b1b-81e9-8456d8e422ad@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231220_060031_752285_902E7491 X-CRM114-Status: GOOD ( 10.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [...] >>> >> >> gcc version 13.2.1 20231011 (Red Hat 13.2.1-4) (GCC) >> >> From Fedora 38. So "a bit" newer :P >> > > I'll retry with newer toolchain. > > FWIW, with the code fix and the original compiler: > > Fork, order-0, Apple M2: > | kernel | mean_rel | std_rel | > |:----------------------|-----------:|----------:| > | mm-unstable | 0.0% | 0.8% | > | hugetlb-rmap-cleanups | 1.3% | 2.0% | > | fork-batching | 4.3% | 1.0% | > > Fork, order-9, Apple M2: > | kernel | mean_rel | std_rel | > |:----------------------|-----------:|----------:| > | mm-unstable | 0.0% | 0.8% | > | hugetlb-rmap-cleanups | 0.9% | 0.9% | > | fork-batching | -37.3% | 1.0% | > > Fork, order-0, Ampere Altra: > | kernel | mean_rel | std_rel | > |:----------------------|-----------:|----------:| > | mm-unstable | 0.0% | 0.7% | > | hugetlb-rmap-cleanups | 3.2% | 0.7% | > | fork-batching | 5.5% | 1.1% | > > Fork, order-9, Ampere Altra: > | kernel | mean_rel | std_rel | > |:----------------------|-----------:|----------:| > | mm-unstable | 0.0% | 0.1% | > | hugetlb-rmap-cleanups | 0.5% | 0.1% | > | fork-batching | -10.4% | 0.1% | > I just gave it another quick benchmark run on that Intel system. hugetlb-rmap-cleanups -> fork-batching order-0: 0.014114 -> 0.013848 -1.9% order-9: 0.014262 -> 0.009410 -34% Note that I disable SMT and turbo, and pin the test to one CPU, to make the results as stable as possible. My kernel config has anything related to debugging disabled. -- Cheers, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel