From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 793D4C433DB for ; Thu, 7 Jan 2021 01:49:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09CB62223E for ; Thu, 7 Jan 2021 01:49:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09CB62223E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Subject:References:In-Reply-To: Message-ID:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mk/OLtMS6kfLUpsE2iTE0ehZlD0Zr3RTLGaNGrBDDwM=; b=0mQPjuLW0HgXkOXEyNfbvo+EK febpwVXkN/5pqa54XZbjmV+z+c9brpDKve7OI/4oJb02fhppV+51JECjZpx9a38VRERERV8I43f3T kHsWIqhpMUD9b/dw5q0cTixfPA1pnYYnmJd4Zxqj3R3wQUEzOz9vRqEezG/9sAJXI4LeXVQK7Vy0g BgY3TCJo8JG1kUVOhkjJCziDJtJ83H+Ii+/T2nPqZXxgebrFTF3V4yTQxgfK+vIGK5rblNtdmrxaG gMadhg+lJrH5s2qkAU6HIO0AYrfbpQnzEyreZ3/Qtns/Cl1QNj907mtqKidbB7K2MKfeM9yE4BvuM FAg6NM2uw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxKNT-0004lI-UR; Thu, 07 Jan 2021 01:46:15 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxKNR-0004kp-Kq for linux-arm-kernel@lists.infradead.org; Thu, 07 Jan 2021 01:46:14 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1071kAKM091320; Wed, 6 Jan 2021 19:46:10 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1609983970; bh=U6pozSNSl59JRbQiGKQJ0thZfCYwqFaa9rVq2Uwo4NU=; h=Date:From:To:CC:In-Reply-To:References:Subject; b=IUzYL8wgN+9RbO8Cj5DCyPKNc5gLxQRCzskgJoLQXFzGL4TFNhMUjGE6Zrzf0Qoac AyUYg6e6JUOV+6o3v2pRDerunpV9AEYoYh8xd30TVFbkxzqbK5w4FbHHjjSQ1Lpn4X vWxDU5sKTz4fjmLcFevrspNvbdKKBW4Y1Zzz0h6w= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1071kAar116654 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 6 Jan 2021 19:46:10 -0600 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 6 Jan 2021 19:46:10 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 6 Jan 2021 19:46:10 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1071kA3X086039; Wed, 6 Jan 2021 19:46:10 -0600 Date: Wed, 6 Jan 2021 19:46:10 -0600 From: Gowtham A Tammana To: Nishanth Menon , Gowtham Tammana Message-ID: <5ff667e2275a0_51d12ad2269e30a42f@uda0271916b.notmuch> In-Reply-To: <20201218140213.gmgyahowalljvp3t@skittle> References: <20201217000716.11091-1-g-tammana@ti.com> <20201217000716.11091-2-g-tammana@ti.com> <20201218140213.gmgyahowalljvp3t@skittle> Subject: Re: [PATCH 1/2] dt-bindings: watchdog: change node name to generic MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_204613_790279_B156CD9C X-CRM114-Status: GOOD ( 23.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Nishanth Menon wrote: > On 18:07-20201216, Gowtham Tammana wrote: > > Modifying the example to use generic as node name to keep it consistent > ^^ Please don't state in commit message the actual change you are > doing.. We can see that from the diffstat. There are lots of > documentation now a days on smart commit messages, I suggest reading > those. > > > with the generic name recommendation. > > > I think what you are doing here is to fix a typo in the example > provided to match with the compatible that is supposed to be used. > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation//devicetree/bindings/watchdog/ti,rti-wdt.yaml#n26 > > While this change is valid, please: > a) Rewrite the commit message > b) Fix $subject "dt-bindings: watchdog: change node name to generic" > "dt-bindings: watchdog" is a huge range of watchdog driver scope, you > want to narrow it to the ti,rti > dt-bindings: watchdog: ti,rti:" or What ever wdt/dt maintainers may prefer. > > "change node name to generic" -> yes, diff tells us that, you are trying > to fix a typo in the example, so please use the word fix to indicate > this is a fixup, not a new 'change' .. > > c) Please CC subsystem maintainers.. I suppose these go through > subsystem maintainer trees once Rob Acks.. Thanks for the review here Nishant. Will make the suggested changes for v2. Gowtham > > > > > Signed-off-by: Gowtham Tammana > > --- > > Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml > > index c1348db59374..e21af390b3e9 100644 > > --- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml > > @@ -57,8 +57,8 @@ examples: > > */ > > #include > > > > - watchdog0: rti@2200000 { > > - compatible = "ti,rti-wdt"; > > + watchdog0: watchdog@2200000 { > > + compatible = "ti,j7-rti-wdt"; > > reg = <0x2200000 0x100>; > > clocks = <&k3_clks 252 1>; > > power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>; > > -- > > 2.29.0 > > > > -- > Regards, > Nishanth Menon > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel