From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6D30C35274 for ; Mon, 18 Dec 2023 12:03:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gg4Bmo1zLLn89/TskvjTIR914oTgr6n1N/YBKamUQ7A=; b=xj1aKrPxKn8CUc rwh72VzhQFYl8FXOQMSbJBR4X7joUvpDhfreQOoneq4CZnwiR0CBBNBFPSohLC7xAdJ4Zv88WLJ1X Z0GCTnSYTIcMEwUm+/PZ9nQx0RGeIQXFnjnMXSgbIe/02isW1OtP55rPLCqvNBkURJUOugEGTqEHd n8hQqZHTZFgzYKKbrXVQ1CSBfN2AK5GV5h9ISjoxIliMly9Q2A9X1hKthx9I6RP5YiwxhFrJ2+kDI BUfxbNpSxIokqPGhdia1tIQ9gnWoGaZkGBLk8HedQxcclq39bb2NEtGkwFTcwb1mL99fg2b4yxMJK X5yjYSjmMsce8/2Bc7Yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCLA-00AWBN-2Y; Mon, 18 Dec 2023 12:03:20 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCL7-00AW3a-0j for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 12:03:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1702900997; x=1734436997; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=W4RQmvsJRShbyg0yBw1LI7RK35V1/P7+WCpbSa+cNFk=; b=nAcg9lwxI/1IrcmPEmsr9QbXU28DcueSLe1TfULorPaO+AYWgA0+U0Ab 408vN+EZ5o4C6s2Udi+LRsXtgcJfAiZBzD6rwNeJhxVeimY/zWudgagPM k1DH2L7zbe7fXGeyPd9cdwzvLwBK56oYJU/W0cF3AekgPt/KlMPBUhilp W7n8rq1wpK1T8TiIDtwiCzXqfaKbHHnUPnfQJAMaoS/tIRfRqCWHk9ZRS c4Y+VlR3X93NNIAZwbpEB04EEPNbEIFnWR2+BYujUxTsFiFMPhuSDTF3W ASvYO4eLRKQ/YS8DY0pXRHqbY1A2QRfpOD5d+rglZblAKqBNIkkVf7wgO Q==; X-IronPort-AV: E=Sophos;i="6.04,285,1695679200"; d="scan'208";a="34561388" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 18 Dec 2023 13:03:10 +0100 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 2A88C280075; Mon, 18 Dec 2023 13:03:10 +0100 (CET) From: Alexander Stein To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Pengutronix Kernel Team , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/6] drm/bridge: dpu-dprc: Use dev_err_probe Date: Mon, 18 Dec 2023 13:03:12 +0100 Message-ID: <6003334.lOV4Wx5bFT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20231218105718.2445136-6-alexander.stein@ew.tq-group.com> References: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> <20231218105718.2445136-6-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040317_645945_CF1367B2 X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 18. Dezember 2023, 11:57:17 CET schrieb Alexander Stein: > This simplifies the code and gives additional information upon deferral. Please ignore. I just noticed this file is added in a locally applied serie= s. Thanks Alexander > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/imx/dpu/dpu-dprc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > = > diff --git a/drivers/gpu/drm/imx/dpu/dpu-dprc.c > b/drivers/gpu/drm/imx/dpu/dpu-dprc.c index 261c9566721e..6467ad960080 > 100644 > --- a/drivers/gpu/drm/imx/dpu/dpu-dprc.c > +++ b/drivers/gpu/drm/imx/dpu/dpu-dprc.c > @@ -612,7 +612,8 @@ static int dpu_dprc_probe(struct platform_device *pde= v) > = > dprc->prgs[i] =3D dpu_prg_lookup_by_phandle(dev, "fsl,prgs", = i); > if (!dprc->prgs[i]) > - return -EPROBE_DEFER; > + return dev_err_probe(dev, -EPROBE_DEFER, > + "Failed to lookup = fsl,prgs\n"); > = > if (i =3D=3D 1) > dpu_prg_set_auxiliary(dprc->prgs[i]); > @@ -623,11 +624,10 @@ static int dpu_dprc_probe(struct platform_device > *pdev) > = > ret =3D devm_request_irq(dev, wrap_irq, dpu_dprc_wrap_irq_handler, > IRQF_SHARED, dev_name(dev), dprc); > - if (ret < 0) { > - dev_err(dev, "failed to request dpr_wrap irq(%u): %d\n", > - wrap_irq, ret); > - return ret; > - } > + if (ret < 0) > + return dev_err_probe(dev, ret, > + "failed to request dpr_wrap = irq(%u)\n", > + wrap_irq); > = > platform_set_drvdata(pdev, dprc); -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel