From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Marek Vasut <marex@denx.de>, <linux-arm-kernel@lists.infradead.org>
Cc: <cniedermaier@dh-electronics.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] ARM: dts: stm32: Fix touchscreen IRQ line assignment on DHCOM
Date: Wed, 28 Jul 2021 09:31:55 +0200 [thread overview]
Message-ID: <600f2cba-f1be-7c43-46aa-c79a07a39d76@foss.st.com> (raw)
In-Reply-To: <d151bcf0-773c-d694-173f-84d138b309ce@denx.de>
On 7/23/21 7:39 PM, Marek Vasut wrote:
> On 7/23/21 5:18 PM, Alexandre TORGUE wrote:
>> Hi Marek
>>
>> On 7/21/21 8:10 PM, Marek Vasut wrote:
>>> While 7e5f3155dcbb4 ("ARM: dts: stm32: Fix LED5 on STM32MP1 DHCOM PDK2")
>>> fixed the LED0 assignment on the PDK2 board, the same commit did not
>>> update the touchscreen IRQ line assignment, which is the same GPIO line,
>>> shared between the LED0 output and touchscreen IRQ input. To make this
>>> more convoluted, the same EXTI input (not the same GPIO line) is shared
>>> between Button B which is Active-Low IRQ, and touchscreen IRQ which is
>>> Edge-Falling IRQ, which cannot be used at the same time. In case the LCD
>>> board with touchscreen is in use, which is the case here, LED0 must be
>>> disabled, Button B must be polled, so the touchscreen interrupt works as
>>> it should.
>>>
>>> Update the touchscreen IRQ line assignment, disable LED0 and use polled
>>> GPIO button driver for Button B, since the DT here describes baseboard
>>> with LCD board.
>>>
>>> Fixes: 7e5f3155dcbb4 ("ARM: dts: stm32: Fix LED5 on STM32MP1 DHCOM
>>> PDK2")
>>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM
>>> STM32MP1 SoM and PDK2 board")
>>
>> I think you need to keep only one fixes tag.
>
> Then it is the first one (LED5) if you want to pick it, or shall I
> resend it ?
I'll do it.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-28 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 18:10 [PATCH] ARM: dts: stm32: Fix touchscreen IRQ line assignment on DHCOM Marek Vasut
2021-07-23 15:18 ` Alexandre TORGUE
2021-07-23 17:39 ` Marek Vasut
2021-07-28 7:31 ` Alexandre TORGUE [this message]
2021-07-28 17:05 ` Marek Vasut
2021-07-30 13:39 ` Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=600f2cba-f1be-7c43-46aa-c79a07a39d76@foss.st.com \
--to=alexandre.torgue@foss.st.com \
--cc=cniedermaier@dh-electronics.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marex@denx.de \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).