From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C72E8C4338F for ; Wed, 28 Jul 2021 07:34:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 971FD60E78 for ; Wed, 28 Jul 2021 07:34:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 971FD60E78 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LP4E17ISCEvkRFU02WeHZTN737FVIDIF4MvvXRf9S/Q=; b=TFk1Fyftz/3u0WpfnNdkCF0VJV XMNt4nFipnxQXduNOCdpEKSeFUAef671r0qwN1UQKI6jJLC3ifr3+Czu28Y9sCIfWBcJenPYzAh1p EsXXY+MYlPBOWqB8CDPE7OP77lSHlwge+RjLobytIIzBbITHMS9thLcPKJtSpkWWpkRGrr7e1G+B4 eKUoasMePgW9qYgskLPIsSB4PnmdZsKNwfKZcXgS8p6z80cPaZCGrIBI662k2KgnTtMKAp6exdziN DcRgHMSIOpYmirlflTUOCifM8O5MJd0u1NGmltU/pMptaY+5CuD9J7oMXyNXKGUyNkBfiYZnjpPgg B0FRE48Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8e31-00HNdW-DZ; Wed, 28 Jul 2021 07:32:11 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8e2w-00HNcg-Jz for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 07:32:08 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16S7GS8K032279; Wed, 28 Jul 2021 09:31:58 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=YiN7Ert0P1D0sLmnMO0dOPrm2lLJdMkUW9cboyDkkH8=; b=wgEzoq8Pf1A7T2XdkhhiUcU4h6HBf2GSy3OjSxnfR6Y89Xr+dw0wII748g5jW+7mp2xU w5Kx7t3fRn6M+MvJUfhRe1uGQ2SOrz/YOgk4KzszUjWABcO4tVU7TJobW/D1RiBTGfEm 7yC8K0F20mW7Un3JLZ6XRlliCyS482+D45crhFwwVxW2Efv/BGEpNJ6ipF+R0BKKvtas azz9T4EVF+7fC87H6tfOZMnIOSQPV7poyLSpU/HVzCOdbeCrTA6XUGUdXWGyM2B/3yYe Qxlvtd7kgY3SY9zlPplIEnGykTLX5w8XCPHm+17D2o9DwFOAo+JrkJ0pr/7jZ8+OGQ88 EQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3a310b8pa6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jul 2021 09:31:58 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BE14510002A; Wed, 28 Jul 2021 09:31:56 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 674F12178D5; Wed, 28 Jul 2021 09:31:56 +0200 (CEST) Received: from lmecxl0912.lme.st.com (10.75.127.46) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 28 Jul 2021 09:31:55 +0200 Subject: Re: [PATCH] ARM: dts: stm32: Fix touchscreen IRQ line assignment on DHCOM To: Marek Vasut , CC: , Patrice Chotard , Patrick Delaunay , References: <20210721181040.126714-1-marex@denx.de> From: Alexandre TORGUE Message-ID: <600f2cba-f1be-7c43-46aa-c79a07a39d76@foss.st.com> Date: Wed, 28 Jul 2021 09:31:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-28_05:2021-07-27, 2021-07-28 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_003207_078557_AD785AE5 X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/23/21 7:39 PM, Marek Vasut wrote: > On 7/23/21 5:18 PM, Alexandre TORGUE wrote: >> Hi Marek >> >> On 7/21/21 8:10 PM, Marek Vasut wrote: >>> While 7e5f3155dcbb4 ("ARM: dts: stm32: Fix LED5 on STM32MP1 DHCOM PDK2") >>> fixed the LED0 assignment on the PDK2 board, the same commit did not >>> update the touchscreen IRQ line assignment, which is the same GPIO line, >>> shared between the LED0 output and touchscreen IRQ input. To make this >>> more convoluted, the same EXTI input (not the same GPIO line) is shared >>> between Button B which is Active-Low IRQ, and touchscreen IRQ which is >>> Edge-Falling IRQ, which cannot be used at the same time. In case the LCD >>> board with touchscreen is in use, which is the case here, LED0 must be >>> disabled, Button B must be polled, so the touchscreen interrupt works as >>> it should. >>> >>> Update the touchscreen IRQ line assignment, disable LED0 and use polled >>> GPIO button driver for Button B, since the DT here describes baseboard >>> with LCD board. >>> >>> Fixes: 7e5f3155dcbb4 ("ARM: dts: stm32: Fix LED5 on STM32MP1 DHCOM >>> PDK2") >>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM >>> STM32MP1 SoM and PDK2 board") >> >> I think you need to keep only one fixes tag. > > Then it is the first one (LED5) if you want to pick it, or shall I > resend it ? I'll do it. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel