From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 894F6C3DA4A for ; Mon, 19 Aug 2024 12:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k4kNH4THhZ5Nwg8AiZRRkhfef0lufAmi3R+L4j9cBb4=; b=bq0vJEVf41MeQfBuAv8hQ9kW4s a3Cor1Q/1rsNezz9uZt9flsVgBXBntenld3jTShRJspEPzoxULNmdiBTNcd1LAyeSzNEARqqh6M9U VNiifeH/nbA2HlYVae+mRTMGDHJzNlQ7pZWGpFq56riwPWZTOmRzrMX1G+OIApunwVayH2TeR/+Xu F7LOVHwhcXTmdoIt5/JA7TizIl4nOSt4QkeG5eXOP+onvRViqjj34XG5VV/0UmElGKQyuLY+K7S88 Z/KQDxlG0QhQwlhok4XB8oryCMHkk2YFiw1NdqBepvfCzT9gjb7iE7zcIDbwRSCDXMo9DXhTCny64 +SYSZ4hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg1Sn-00000001Qf7-342t; Mon, 19 Aug 2024 12:26:21 +0000 Received: from out30-118.freemail.mail.aliyun.com ([115.124.30.118]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg1S5-00000001QUx-3RFd for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 12:25:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1724070332; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=k4kNH4THhZ5Nwg8AiZRRkhfef0lufAmi3R+L4j9cBb4=; b=NTB8Kn2kR4roFj6SJmmUsoaxnEHJ/bLS27OgLwuBMvUi01DuBfcsUQi86ymLoB1bZsrS9V8kh7pjTJC8bZLSqllHhyA3JiZ5zNkTY1KI8u8jjcOgFMGJvtNUFIULAuFYj2cfe8ujSf8FeiFBKgFbke31M8n4JA4Z6LMH8ru4F0g= Received: from 30.246.160.136(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WDCu7VX_1724070330) by smtp.aliyun-inc.com; Mon, 19 Aug 2024 20:25:31 +0800 Message-ID: <601bf843-94c7-49f7-8fa3-536a118b4ae0@linux.alibaba.com> Date: Mon, 19 Aug 2024 20:25:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drivers/perf: Fix ali_drw_pmu driver interrupt status clearing To: Jing Zhang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland , Will Deacon References: <1724068110-45239-1-git-send-email-renyu.zj@linux.alibaba.com> From: Shuai Xue In-Reply-To: <1724068110-45239-1-git-send-email-renyu.zj@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_052538_404143_26316B90 X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 在 2024/8/19 19:48, Jing Zhang 写道: > The alibaba_uncore_pmu driver forgot to clear all interrupt status > in the interrupt processing function. After the PMU counter overflow > interrupt occurred, an interrupt storm occurred, causing the system > to hang. > > Therefore, clear the correct interrupt status in the interrupt handling > function to fix it. > > Signed-off-by: Jing Zhang > --- > drivers/perf/alibaba_uncore_drw_pmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c > index 38a2947..c6ff1bc 100644 > --- a/drivers/perf/alibaba_uncore_drw_pmu.c > +++ b/drivers/perf/alibaba_uncore_drw_pmu.c > @@ -400,7 +400,7 @@ static irqreturn_t ali_drw_pmu_isr(int irq_num, void *data) > } > > /* clear common counter intr status */ > - clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, 1); > + clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, status); > writel(clr_status, > drw_pmu->cfg_base + ALI_DRW_PMU_OV_INTR_CLR); > } Yes, it is a bug due to typo. Thank you. Reviewed-by: Shuai Xue Shuai