From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2E62C46467 for ; Wed, 11 Jan 2023 09:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PHViYoncaqaVPCp5Wd4xHvsAAPSuhyFVOfj7qhrbUYE=; b=jdVd++actIucsQ fdzcRrPFPgrwGIaBX0eXX8GJFf0TBYh1zhIVdjaea3sE9E2WUQi4MgFMSYmBpCLOyt2L8fbuyr56q /LYY2i6kHuwhXCDbSC+szg//q4kJwgdLtLNfCIz3BTLGKYfd1boQUIZhgxwJIl9FA1j6f4FKIINHO pq4Czi8cZpeIvdjTXk3Xbq74dE8VS/lFUL8gmrq6k55vnL7OJQiJOPFGVHYFhK6N7yUJztVb7ELrT 50Ji11jnGJEvgmLo1O5sl+W+NUka1PcSGKuDpX4Bpng6GOEHlwyjmktJIREjD3Lmm+XhwvsAcSKD4 Jj7OgBgQQQuZyJszKzLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFXWw-00AZBV-EU; Wed, 11 Jan 2023 09:36:22 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFXWt-00AZAE-8o for linux-arm-kernel@lists.infradead.org; Wed, 11 Jan 2023 09:36:20 +0000 Received: by mail-wm1-x335.google.com with SMTP id c4-20020a1c3504000000b003d9e2f72093so9069736wma.1 for ; Wed, 11 Jan 2023 01:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=agrBGzLEfDLBSaCHOLwWqzPW8aLKgXJ9Qn5pOrzQb5Y=; b=L1ew/2SCwJ61mAaiVWmR/o/h0rvj5/f8oWZHWzHzYRw3DibCnHMEDLdOE6f3JibAv4 TIbFr3b6wleD09DJbyz69vNg50+ZP+SzNowSevdxBHlyMEYmtkEs/cfgpI3fBLmNFK7R nj/kwt7wwkxVeqOcx6fTIfreTT7aXZpE185iHv1G3KCJnJjK4GbWVrbx2EC8H+LPLZO4 cbbthMcG4ULnar4283XFnePmqly+AR2Whbt32lHWAYJi4KAkQCudsQm8EvBNcH5Pn4bV LGXG9pwErge9lO8e+ELGjblOWgaA8i8KSoo0pcm6JEtRNmzguwM2yBmgb+xfeuMicRhs VcVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=agrBGzLEfDLBSaCHOLwWqzPW8aLKgXJ9Qn5pOrzQb5Y=; b=cdwrr80idnseOJzCQHTJ10gQ+a1OTqT690iDiUez4+TaCyZVEv1MYn246gIEqgY6Po ojBM9TSLq95WTRa/LTev00a8hmlvpo6BBRoccZduWp0183N8u6OSDMI+S4xNPD0q6INA Dy8n2WHzTmqVxp/YkeS5oOdQLuE0tz9UdACX43LiSFlZv6ldGEgNG7yOHmfwWHz3RycD Lhhs/vVsfbwWC9gwEn1wpzRwd9oGwiUOTVo1AZeFE2n3OJzP19XMpoq27sCxePIydv6q giO9svA5GSJ9Wf9zYRrDLeag/ub5E7vS0LNAhvPgTWL/JoKBGgf14LcHmdX9dw1ukFCp cn+w== X-Gm-Message-State: AFqh2kqgmtAdawZQ3rpYJimpH8oRJ7R3a2GeZT93E0d6VuykZVqWUb1S M8kz6e8r+cIWvbUDO3B9Su2kCg== X-Google-Smtp-Source: AMrXdXur2VYSsIb72rrxWp6CTmFDaeh2Stw30IqyKOpakPOnkVDT29DdV1AQ6EJLmwgaYmiy5MRsiw== X-Received: by 2002:a05:600c:4d25:b0:3d3:5b7a:1791 with SMTP id u37-20020a05600c4d2500b003d35b7a1791mr62592799wmp.41.1673429776076; Wed, 11 Jan 2023 01:36:16 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id he5-20020a05600c540500b003d9ed40a512sm13601488wmb.45.2023.01.11.01.36.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 01:36:15 -0800 (PST) Message-ID: <603f9c39-3e36-bb44-2305-1d37fe033dd5@linaro.org> Date: Wed, 11 Jan 2023 10:36:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/7] dt-bindings: arm64: ipq9574: Add binding descriptions for clock and reset Content-Language: en-US To: devi priya , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com, dmitry.baryshkov@linaro.org, nfraprado@collabora.com, broonie@kernel.org, tdas@codeaurora.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: quic_srichara@quicinc.com, quic_gokulsri@quicinc.com, quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com, quic_arajkuma@quicinc.com, quic_anusha@quicinc.com, quic_poovendh@quicinc.com References: <20230110121316.24892-1-quic_devipriy@quicinc.com> <20230110121316.24892-2-quic_devipriy@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230110121316.24892-2-quic_devipriy@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_013619_347654_DD7A1C10 X-CRM114-Status: GOOD ( 15.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/01/2023 13:13, devi priya wrote: > Adding support for the global clock controller found on > IPQ9574 based devices Subject: drop second/last, redundant "bindings descriptions for". The "dt-bindings" prefix is already stating that these are bindings. > > Co-developed-by: Anusha Rao > Signed-off-by: Anusha Rao > Signed-off-by: devi priya > --- > .../bindings/clock/qcom,gcc-other.yaml | 4 + > .../devicetree/bindings/clock/qcom,gcc.yaml | 9 +- > include/dt-bindings/clock/qcom,gcc-ipq9574.h | 226 ++++++++++++++++++ > include/dt-bindings/reset/qcom,gcc-ipq9574.h | 164 +++++++++++++ > 4 files changed, 402 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/clock/qcom,gcc-ipq9574.h > create mode 100644 include/dt-bindings/reset/qcom,gcc-ipq9574.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > index 2e8acca64af1..cc563d640336 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > @@ -18,6 +18,8 @@ description: | > include/dt-bindings/clock/qcom,gcc-ipq4019.h > include/dt-bindings/clock/qcom,gcc-ipq6018.h > include/dt-bindings/reset/qcom,gcc-ipq6018.h > + include/dt-bindings/clock/qcom,gcc-ipq9574.h > + include/dt-bindings/reset/qcom,gcc-ipq9574.h > include/dt-bindings/clock/qcom,gcc-msm8953.h > include/dt-bindings/clock/qcom,gcc-mdm9607.h > include/dt-bindings/clock/qcom,gcc-mdm9615.h > @@ -34,6 +36,8 @@ properties: > - qcom,gcc-mdm9607 > - qcom,gcc-msm8953 > - qcom,gcc-mdm9615 > + - qcom,gcc-ipq9574 Incorrect order but anyway let's switch to new naming style just like SM8550 and SA8775p. > + Not related change. > > required: > - compatible > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml > index 7129fbcf2b6c..5a71268538e6 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml > @@ -24,6 +24,14 @@ properties: > '#power-domain-cells': > const: 1 > > + clocks: > + minItems: 1 > + maxItems: 8 > + > + clock-names: > + minItems: 1 > + maxItems: 8 This does not look correct, neither related. > + > reg: > maxItems: 1 > > @@ -35,7 +43,6 @@ required: > - reg > - '#clock-cells' > - '#reset-cells' > - - '#power-domain-cells' Eee? Why? What's this? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel