public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: narmstrong@baylibre.com (Neil Armstrong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] dt-bindings: reset: oxnas: Update for OX820
Date: Fri, 9 Sep 2016 15:43:26 +0200	[thread overview]
Message-ID: <6045eda4-3a49-555b-9cf8-c321640bc98b@baylibre.com> (raw)
In-Reply-To: <1473428153.3023.34.camel@pengutronix.de>

Hi Philipp,

On 09/09/2016 03:35 PM, Philipp Zabel wrote:
> Hi Neil,
> 
> Am Freitag, den 09.09.2016, 15:19 +0200 schrieb Neil Armstrong:
>> Add new compatible string for reset and sys-ctrl for the Oxford
>> Semiconductor OX820 Support.
>> Drop the OX810SE indices since they moved in a dedicated include file.
> 
> Not sure if the OX820 reset controller should be considered "compatible"
> to OX810SE. The register layout and usage is the same, but the reset
> indices are different. Does this warrant a new compatible string, or
> should this be
> 	compatible = "oxsemi,ox820-reset", "oxsemi,ox810se-reset"?

As indicated on the cover letter, I'll like to have each supported SoC
as a specific compatible, to ease maintaining the drivers and
clarify what HW is supported.

Having an include file per SoC is also part of the process.

> 
[...]
> 
> Please add a pointer to include/dt-bindings/reset/oxsemi,ox8{10se,20}.h

OK, will do in v2.

> 
> Otherwise I'm fine with the series, pending DT maintainer approval.
> 
> regards
> Philipp
> 

Thanks,
Neil

  reply	other threads:[~2016-09-09 13:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 13:19 [PATCH 0/3] reset: Add support for OX820 SoC Neil Armstrong
2016-09-09 13:19 ` [PATCH 1/3] reset: oxnas: Add OX820 support Neil Armstrong
2016-09-09 13:19 ` [PATCH 2/3] dt-bindings: reset: oxnas: Add include file with reset indexes Neil Armstrong
2016-09-09 13:19 ` [PATCH 3/3] dt-bindings: reset: oxnas: Update for OX820 Neil Armstrong
2016-09-09 13:35   ` Philipp Zabel
2016-09-09 13:43     ` Neil Armstrong [this message]
2016-09-19 21:18     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6045eda4-3a49-555b-9cf8-c321640bc98b@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox