From mboxrd@z Thu Jan 1 00:00:00 1970 From: rjw@rjwysocki.net (Rafael J. Wysocki) Date: Mon, 17 Apr 2017 18:40:08 +0200 Subject: [PATCH V2] PM / OPP: Use - instead of @ for DT entries In-Reply-To: <22966574.2zMrIUgKz4@aspire.rjw.lan> References: <70e7c7ee13722ab9c73cb073f88502eaf1ada5f5.1491816050.git.viresh.kumar@linaro.org> <22966574.2zMrIUgKz4@aspire.rjw.lan> Message-ID: <6048149.VQXQ7HobDf@aspire.rjw.lan> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday, April 17, 2017 06:35:25 PM Rafael J. Wysocki wrote: > On Monday, April 17, 2017 11:07:51 AM Masahiro Yamada wrote: > > 2017-04-15 7:47 GMT+09:00 Rafael J. Wysocki : > > > On Monday, April 10, 2017 02:51:35 PM Viresh Kumar wrote: > > >> Compiling the DT file with W=1, DTC warns like follows: > > >> > > >> Warning (unit_address_vs_reg): Node /opp_table0/opp at 1000000000 has a > > >> unit name, but no reg property > > >> > > >> Fix this by replacing '@' with '-' as the OPP nodes will never have a > > >> "reg" property. > > >> > > >> Reported-by: Krzysztof Kozlowski > > >> Reported-by: Masahiro Yamada > > >> Suggested-by: Mark Rutland > > >> Signed-off-by: Viresh Kumar > > >> Acked-by: Maxime Ripard (sunxi) > > >> Reviewed-by: Chanwoo Choi > > >> Reviewed-by: Krzysztof Kozlowski > > > > > > OK, so any ACKs from the DT side? Rob? > > > > > > Thanks, > > > Rafael > > > > > > > > I see Rob's Acked-by. > > > > https://lkml.org/lkml/2017/4/13/648 > > Indeed. Thanks! But it doesn't apply on top of -rc7 for me, so I guess there is new 4.12-candidate material in the DTS tree that conflicts with this, in which case it is better to route it through the DTS tree IMO. Thanks, Rafael