From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5435DC4829B for ; Mon, 12 Feb 2024 12:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vfRhmAQWfDqjYgZm1njEDcZYT1jS0UuB3CSCtELSBOE=; b=1/74VLYho39EQ9 YMgjeIav2Bt1BpPfmX3PRJG9i2MuiwAqXCac/+aTij+NxpKNUyI5pDP6Pl48johUFbiu2zvq/Wsc4 pTeCoC0IDKVRmoLJ2VcybPAJBC50EWSXIiIHIQzHtIWmRiqDYwcBfNlV3hKSwG7hmgeWWRXGPLkt2 ORPLOK80F89d77MavQN0h0dgSEM+JBozJWpEOb9zZh7nn1gwoXJ3DCDOQa8sQWEn5DD5RkzzBPqzh iA4AzOZnJgWIregAIg8mIrQUZCjV2CnhLKNUjqsQCYf+9b5L0Wls11Gkkbm8GaNHaiRnR3ZMCMj2Z DN3bHGvmtoy6JHlHnGNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZV1d-00000005B0c-3Jow; Mon, 12 Feb 2024 12:03:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZV1b-00000005AzS-2Cy8 for linux-arm-kernel@lists.infradead.org; Mon, 12 Feb 2024 12:03:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0AC2EDA7; Mon, 12 Feb 2024 04:03:41 -0800 (PST) Received: from [192.168.1.100] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 808D63F7BD; Mon, 12 Feb 2024 04:02:57 -0800 (PST) Message-ID: <60499829-a5fa-54e6-42e3-bd48f25a65dc@arm.com> Date: Mon, 12 Feb 2024 12:02:55 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH V4 00/11] coresight: Move remaining AMBA ACPI devices into platform driver To: Anshuman Khandual , linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com Cc: Lorenzo Pieralisi , Sudeep Holla , Mike Leach , Maxime Coquelin , Alexandre Torgue , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-stm32@st-md-mailman.stormreply.com References: <20240123054608.1790189-1-anshuman.khandual@arm.com> Content-Language: en-US From: James Clark In-Reply-To: <20240123054608.1790189-1-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240212_040303_746421_0586A3B5 X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/01/2024 05:45, Anshuman Khandual wrote: > This moves remaining AMBA ACPI devices into respective platform drivers for > enabling ACPI based power management support. This series applies on kernel > v6.8-rc1 release. This series has been built, and boot tested on a DT based > coresight platform. Although this still requires some more testing on ACPI > based coresight platforms. > > https://git.gitlab.arm.com/linux-arm/linux-anshuman.git (amba_other_acpi_migration_v4) > > Cc: Lorenzo Pieralisi > Cc: Sudeep Holla > Cc: Suzuki K Poulose > Cc: Mike Leach > Cc: James Clark > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: linux-acpi@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: coresight@lists.linaro.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Reviewed-by: James Clark > Changes in V4: > > - Fixed PM imbalance in etm4_probe() error path with pm_runtime_disable() > - Restored back the pm_runtime_disable() on platform probe error paths > in replicator, funnel, catu, tpiu, tmc and stm devices > - Dropped dev_caps argument from __tmc_probe() > - Changed xxxx_platform_remove() for platform_driver->remove_new() callback > > Changes in V3: > > https://lore.kernel.org/all/20231208053939.42901-1-anshuman.khandual@arm.com/ > > - Split coresight_init_driver/remove_driver() helpers into a separate patch > - Added 'drvdata->pclk' comments in replicator, funnel, tpiu, tmc, and stm devices > - Updated funnel, and replicator drivers to use these new helpers > - Check for drvdata instead of drvdata->pclk in suspend and resume paths in catu, > tmc and debug devices > - Added patch to extract device name from AMBA pid based table lookup for stm > - Added patch to extract device properties from AMBA pid based table look for tmc > - Dropped pm_runtime_put() from common __probe() functions > - Handled pm_runtime_put() in AMBA driver in success path > - Handled pm_runtime_put() in platform driver in both success and error paths > > Changes in V2: > > https://lore.kernel.org/all/20231201062053.1268492-1-anshuman.khandual@arm.com/ > > - Dropped redundant devm_ioremap_resource() hunk from tmc_platform_probe() > - Defined coresight_[init|remove]_driver() for both AMBA/platform drivers > - Changed catu, tmc, tpiu, stm and debug coresight drivers to use the new > helpers avoiding build issues arising from module_amba_driver(), and > module_platform_driver() being on the same file > > Changes in V1: > > https://lore.kernel.org/all/20231027072943.3418997-1-anshuman.khandual@arm.com/ > > - Replaced all IS_ERR() instances with IS_ERR_OR_NULL() as per Suzuki > > Changes in RFC: > > https://lore.kernel.org/all/20230921042040.1334641-1-anshuman.khandual@arm.com/ > > Anshuman Khandual (11): > coresight: etm4x: Fix unbalanced pm_runtime_enable() > coresight: stm: Extract device name from AMBA pid based table lookup > coresight: tmc: Extract device properties from AMBA pid based table lookup > coresight: Add helpers registering/removing both AMBA and platform drivers > coresight: replicator: Move ACPI support from AMBA driver to platform driver > coresight: funnel: Move ACPI support from AMBA driver to platform driver > coresight: catu: Move ACPI support from AMBA driver to platform driver > coresight: tpiu: Move ACPI support from AMBA driver to platform driver > coresight: tmc: Move ACPI support from AMBA driver to platform driver > coresight: stm: Move ACPI support from AMBA driver to platform driver > coresight: debug: Move ACPI support from AMBA driver to platform driver > > drivers/acpi/arm64/amba.c | 8 - > drivers/hwtracing/coresight/coresight-catu.c | 142 +++++++++++++--- > drivers/hwtracing/coresight/coresight-catu.h | 1 + > drivers/hwtracing/coresight/coresight-core.c | 29 ++++ > .../hwtracing/coresight/coresight-cpu-debug.c | 141 ++++++++++++++-- > .../coresight/coresight-etm4x-core.c | 3 + > .../hwtracing/coresight/coresight-funnel.c | 86 +++++----- > drivers/hwtracing/coresight/coresight-priv.h | 10 ++ > .../coresight/coresight-replicator.c | 81 ++++----- > drivers/hwtracing/coresight/coresight-stm.c | 117 +++++++++++-- > .../hwtracing/coresight/coresight-tmc-core.c | 158 +++++++++++++++--- > drivers/hwtracing/coresight/coresight-tmc.h | 2 + > drivers/hwtracing/coresight/coresight-tpiu.c | 102 +++++++++-- > include/linux/coresight.h | 7 + > 14 files changed, 726 insertions(+), 161 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel