public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM64: enable CONFIG_KEYS_COMPAT in Kconfig
Date: Wed, 25 Jan 2017 22:22:37 +0100	[thread overview]
Message-ID: <6063453.l76hsdyeRH@wuerfel> (raw)
In-Reply-To: <1485190992-86476-1-git-send-email-bilal.amarni@gmail.com>

On Monday, January 23, 2017 6:03:12 PM CET Bilal Amarni wrote:
> Currently in 32-bit userspace calling the keyctl syscall returns an ENOSYS error.
> 
> This makes sure the compatibility wrapper is registered.
> 
> Signed-off-by: Bilal Amarni <bilal.amarni@gmail.com>

While this looks technically correct, it doesn't seem very nice to the
other 64-bit architectures that may also be missing this.

> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 1117421..d76f70b 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1030,6 +1030,10 @@ config SYSVIPC_COMPAT
>         def_bool y
>         depends on COMPAT && SYSVIPC
>  
> +config KEYS_COMPAT
> +       def_bool y
> +       depends on COMPAT && KEYS
> +

I see four copies of this in existing architectures, but none for
mips, parisc or tile. How about just moving this next to CONFIG_KEYS?

	Arnd

  reply	other threads:[~2017-01-25 21:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23 17:03 [PATCH] ARM64: enable CONFIG_KEYS_COMPAT in Kconfig Bilal Amarni
2017-01-25 21:22 ` Arnd Bergmann [this message]
2017-01-26 11:49   ` [PATCH] security/keys: add CONFIG_KEYS_COMPAT to Kconfig Bilal Amarni
2017-01-26 12:55     ` kbuild test robot
2017-01-26 13:27       ` Bilal Amarni
2017-02-08 13:01         ` Bilal Amarni
2017-02-08 13:25           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6063453.l76hsdyeRH@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox