Re: [PATCH v3 4/6] arm64: dts: rockchip: Add ArmSoM Sige1

Jonas Karlman
2025-07-15T19:14:49Z

Hi Chukun,

On 7/15/2025 4:01 PM, Chukun Pan wrote:
> Hi,
>
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/rk3528-armsom-sige1.dts
>> ...
>> +&sdio0 {
>> + bus-width = <4>;
>> + cap-sd-highspeed;
>> + cap-sdio-irq;
>> + disable-wp;
>
> I don't think sdio needs disable-wp?

I thinks your are correct:

disable-wp:
$ref: /schemas/types.yaml#/definitions/flag
description:
When set, no physical write-protect line is present. This
property should only be specified when the controller has a
dedicated write-protect detection logic. If a GPIO is always used
for the write-protect detection logic, it is sufficient to not
specify the wp-gpios property in the absence of a write-protect
line. Not used in combination with eMMC or SDIO.

It mention 'not used in combination with eMMC or SDIO', yet I see
multiple boards where disable-wp is currently used with eMMC and SDIO.

Do you have anything else to remark before I send a v4 with this prop
removed?

Regards,
Jonas

>
> Thanks,
> Chukun
>
> --
> 2.25.1
>