From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD95C2D0A3 for ; Mon, 9 Nov 2020 13:57:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DFB22068D for ; Mon, 9 Nov 2020 13:57:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A+YXiwko"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="DPMYvOi0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DFB22068D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CcjcMTbErafw0XHGNGJ3bKVwBMwep0+ms6eXoza22sw=; b=A+YXiwkoqtzL8/SvC4jWzdkkq DYtDtl7+YSpTHjifYQn2E7yR1wyI2/UgAXA9UHuN/pdYt73C19eXv1si5nz9HtHnRJ8icumK7PV4s 4M4wHolnHFCxmwtkcMAzNWzJuukmHBT9B8Wvp6hImh6ZTSa8enBR8XMZjyv7d8bmte3yQBlNmdbls QKV1wF3FoOTdOcqJEpEu9orrRP/OxwUtOW/CImMdTB1uHH7gACKQrxjh7z4cBEe1PA+ahAXdY/TKK nuzSWnXtWEdQU1Z9TzEBT0/yuVsAcl4ua6jc8l9qrsh2RNkCsMlLveDNN6FMY36O0VpcnZJ7ucKXu znCCWNddA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc7eX-0008AE-TH; Mon, 09 Nov 2020 13:56:13 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc7eV-00089E-Ba for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 13:56:12 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A9Dkg3X027383; Mon, 9 Nov 2020 14:56:09 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=uNjIsuooWc4CXF9GNeC8W/zbLVHgmBjAP8/7oakrBUM=; b=DPMYvOi0BfWM2oWDd9jnFQCKveK03z2FLxZJZlnqh2aX5ZyDyhwarYS4p2ZCpE9UBjdY PgQ50PcbTS9TyVM6G5dZBDmjKVwxolzn5aBkj5sXtohbj7NrZPtK36kbf4UZPyxs4Foy QTcCxdDGHo79dVVXSXLk6qnonqnJ1ja7Ci/3HeTucHtJqmXDQKD5vTzSTzZn6qS7SLYs NHI7ht/fd2Jcylbt130VafWKVguQ6sTm4WORm5YJCbTc6aeaYOMRM50fJxPZjPiiFjQu gUppdN1zvg6RF5hau68jLtdt6gMY7mVpIAchDtauWCw7E3do+nXSM87gOvmCd+bRFjyO RQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 34nkbmtdue-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Nov 2020 14:56:09 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8C095100038; Mon, 9 Nov 2020 14:56:08 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 7F93F2C38BD; Mon, 9 Nov 2020 14:56:08 +0100 (CET) Received: from lmecxl0912.lme.st.com (10.75.127.51) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 9 Nov 2020 14:56:08 +0100 Subject: Re: [PATCH] ARM: dts: stm32: Enable thermal sensor support on stm32mp15xx-dhcor To: Manivannan Sadhasivam , Marek Vasut References: <20200923232535.241437-1-marex@denx.de> <0D1E174A-2217-4785-B4E5-79135AAF76F1@linaro.org> <5d0c9b8f-8f6b-a4c7-dc80-638e23749310@denx.de> <20200925162040.GA4746@linux> From: Alexandre Torgue Message-ID: <606b6905-54d4-1a7a-8cfd-01f6818ec18a@st.com> Date: Mon, 9 Nov 2020 14:55:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200925162040.GA4746@linux> Content-Language: en-US X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-09_02:2020-11-05, 2020-11-09 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_085611_670628_5E2F4E66 X-CRM114-Status: GOOD ( 23.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, Mani On 9/25/20 6:20 PM, Manivannan Sadhasivam wrote: > On Fri, Sep 25, 2020 at 01:12:12PM +0200, Marek Vasut wrote: >> On 9/25/20 4:21 AM, Manivannan Sadhasivam wrote: >>> >>> >>> On 24 September 2020 4:11:11 PM IST, Marek Vasut wrote: >>>> On 9/24/20 7:16 AM, Manivannan Sadhasivam wrote: >>>>> >>>>> >>>>> On 24 September 2020 4:55:35 AM IST, Marek Vasut >>>> wrote: >>>>>> Enable STM32 Digital Thermal Sensor driver for stm32mp15xx-dhcor >>>> SoMs. >>>>>> >>>>>> Fixes: 94cafe1b6482 ("ARM: dts: stm32: Add Avenger96 devicetree >>>> support >>>>>> based on STM32MP157A") >>>>> >>>>> The change looks good but what does this patch fixes? >>>> >>>> The missing temp sensor, which helps you detect overheat of the SoC. >>>> That is esp. important on the 800 MHz AV96. >>> >>> This doesn't quality as a "fix". Essentially you're just adding a missing feature and not fixing any issues. So please remove the fixes tag and resubmit. >> >> I would argue that if the system overheats and crashes, we want to know >> about that, possibly in advance so thermal throttling can be applied. >> Currently this is not possible and I think that is a bug. > > No, this is not a _bug_. This is a missing feature that the current kernel > doesn't support and you know about that! The fact that you can trigger a crash > due to hw limitation doesn't qualify as a bug IMO. And you can do that by other > means also (CPU throttling without CPUFreq support etc...) > > Anyway, I'll stop here and let Alex to make a call. I take this patch as fix this time. I understand your argument Mani, but to avoid unexplained crashes at boot it's better to get also on older version. So applied on stm32-dt-for-v5.10-fixes. regards alex > Either case, feel free to add: > > Reviewed-by: Manivannan Sadhasivam > > Thanks, > Mani > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel