From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pcmcia: db1xxx: use correct irq_to_gpio helper
Date: Wed, 02 Mar 2016 09:58:07 +0100 [thread overview]
Message-ID: <60750044.6kqqL7c64M@wuerfel> (raw)
In-Reply-To: <CAOLZvyHH4-uq_fnpjrRptkMfjR1+1kzxXM+AUtj_Zb5V3AL-yQ@mail.gmail.com>
On Wednesday 02 March 2016 07:50:28 Manuel Lauss wrote:
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: stable at vger.kernel.org # v4.3
> > Fixes: 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h")
> > ---
> > I think this is now the last holdout of the irq_to_gpio function,
> > and it's been broken for a while. Maybe Ralf can queue it up through
> > the MIPS tree along with the other fix for irq_to_gpio?
>
> It's not broken though.. this driver on current linus-git works fine!
Ah, so it doesn't actually need the gpio line then?
irq_to_gpio() unconditionally returns -EINVAL since 4.3, so the easiest
fix would be to remove the card-detect function in the driver, right?
Arnd
prev parent reply other threads:[~2016-03-02 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 22:12 [PATCH] pcmcia: db1xxx: use correct irq_to_gpio helper Arnd Bergmann
2016-03-02 6:50 ` Manuel Lauss
2016-03-02 8:58 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60750044.6kqqL7c64M@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox